Re: [tomcat] branch 7.0.x updated: Fix resource leak on exception path

2019-04-18 Thread Rainer Jung
Am 19.04.2019 um 00:27 schrieb Mark Thomas: On 18/04/2019 21:48, Rainer Jung wrote: This results in a compiler error. See below for details. Whoops. Should be fixed now. Sorry about that. NP. Confirmed, compiles now. Thanks and regards, Rainer

Re: [tomcat] branch 7.0.x updated: Fix resource leak on exception path

2019-04-18 Thread Rainer Jung
This results in a compiler error. See below for details. Am 17.04.2019 um 18:56 schrieb ma...@apache.org: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following

Re: [VOTE] Release Apache Tomcat 9.0.18

2019-04-11 Thread Rainer Jung
Am 11.04.2019 um 16:15 schrieb Mark Thomas: On 11/04/2019 15:11, Rémy Maucherat wrote: I already made the fix but the commit emails is stuck. https://github.com/apache/tomcat/commit/4c6c3e9f434ca1a5cecf04f1b9148fb221b3af37 Great. Thanks. What other things do we need to take care of before

Re: [VOTE] Release Apache Tomcat 9.0.18

2019-04-11 Thread Rainer Jung
Am 11.04.2019 um 14:51 schrieb Rémy Maucherat: On Thu, Apr 11, 2019 at 2:00 PM Rainer Jung wrote: Am 10.04.2019 um 15:44 schrieb Mark Thomas: The proposed Apache Tomcat 9.0.18 release is now available for voting. The major changes compared to the 9.0.17 release are: - Fix for CVE-2019-0232

Re: [VOTE] Release Apache Tomcat 9.0.18

2019-04-11 Thread Rainer Jung
Am 10.04.2019 um 15:44 schrieb Mark Thomas: The proposed Apache Tomcat 9.0.18 release is now available for voting. The major changes compared to the 9.0.17 release are: - Fix for CVE-2019-0232 a RCE vulnerability on Windows - Add support for Java 11 to the JSP compiler. Java 12 and 13 are

Re: Tagging 9.0.18

2019-04-10 Thread Rainer Jung
Am 09.04.2019 um 19:45 schrieb Mark Thomas: Hi all, I'm a bit behind again this month - mainly because I was at the http workshop last week (very useful - a write-up is on the way). I'm very keen on reading your notes. On the httpd dev list Bill mentioned three links to notes taken by Daniel

Re: [tomcat] branch master updated (267b8d8 -> b35d947)

2019-03-05 Thread Rainer Jung
Am 05.03.2019 um 14:45 schrieb ma...@apache.org: This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 267b8d8 Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63206

Re: Building and Testing Tomcat 7

2019-03-04 Thread Rainer Jung
Thanks Igal. Am 02.03.2019 um 23:08 schrieb Igal Sapir: Rainer, On Sat, Feb 16, 2019 at 2:42 PM Rainer Jung wrote: Hi Igal, Am 16.02.2019 um 22:10 schrieb Igal Sapir: Violeta, On Sat, Feb 16, 2019 at 9:41 AM Violeta Georgieva wrote: The proposed Apache Tomcat 7.0.93 release is now

Re: New git based merging workflow?

2019-02-28 Thread Rainer Jung
ne. I can probably do more in the IDE than I am currently doing. I'm still finding my way a bit and figuring out what process works best for me. HTH, Mark On 28/02/2019 10:04, Rainer Jung wrote: Hi there, I am struggling a bit with the new merging workflow from master to the branches. I did a

New git based merging workflow?

2019-02-28 Thread Rainer Jung
Hi there, I am struggling a bit with the new merging workflow from master to the branches. I did a short read on the workspaces and tried cherry-picking with and without workspaces. It seems workspaces are not for doing actual commits that should at the end et pushed to origin. And when

Re: [tomcat] branch master updated: Remove further remains of the extras package.

2019-02-26 Thread Rainer Jung
/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 0752512 Remove further remains of the extras package. 0752512 is described below commit 0752512ac27ab338371b72ded2b216d972091196 Author: Rainer Jung AuthorDate: Wed Feb 27 00:26:03 2019 +0100

Re: [VOTE] Release Apache Tomcat 7.0.93

2019-02-16 Thread Rainer Jung
Hi Igal, Am 16.02.2019 um 22:10 schrieb Igal Sapir: Violeta, On Sat, Feb 16, 2019 at 9:41 AM Violeta Georgieva wrote: The proposed Apache Tomcat 7.0.93 release is now available for voting. I know that this is an issue with my environment, and not with Tomcat, but I wonder how you get it

Re: OpenSSL session caching defaults

2019-02-11 Thread Rainer Jung
Am 11.02.2019 um 10:18 schrieb Mark Thomas: The OpenSSL defaults are: - session caching enabled - sessions timeout 300 (seconds) r1686258 changed those to: - session caching disabled - session timeout 14400 (4 hours) This was part of the netty changes. I think the timeout change is OK but I

TC test suite results non-native

2019-02-01 Thread Rainer Jung
Hi there, I ran the test suite for a wide range of combinations of TC versions (7, 8.5 and 9 head), Java versions (1.7.0, 1.8.0 and 11 - where applicable) and OpenSSL (1.1.1a, 1.1.1, 1.1.0i, 1.1.0e, 1.0.2q, 1.0.2). tc revision was 1852637, tcnative was always 1.2.21, platforms where Solaris

Re: TC trunk on SLES 11 with APR and Java 11: to many threads during TestDefaultServletEncodingWith*Bom

2019-01-29 Thread Rainer Jung
Am 29.01.2019 um 10:12 schrieb Rémy Maucherat: On Tue, Jan 29, 2019 at 12:01 AM Rainer Jung wrote: Thanks Rémy, that seems to have fixed it. As a much smaller annoyance, now every single executing test writes one new line: WARNING [main] org.apache.tomcat.util.net.AprEndpoint$Sendfile.stop

Re: TC trunk on SLES 11 with APR and Java 11: to many threads during TestDefaultServletEncodingWith*Bom

2019-01-28 Thread Rainer Jung
Am 28.01.2019 um 11:49 schrieb Rémy Maucherat: On Mon, Jan 28, 2019 at 11:16 AM Rainer Jung wrote: Am 28.01.2019 um 10:50 schrieb Rémy Maucherat: On Sun, Jan 27, 2019 at 2:18 AM Rainer Jung wrote: When running the unit tests for trunk using Java 11 and APR connector I run out of memory

Re: TC trunk on SLES 11 with APR and Java 11: to many threads during TestDefaultServletEncodingWith*Bom

2019-01-28 Thread Rainer Jung
Am 28.01.2019 um 10:50 schrieb Rémy Maucherat: On Sun, Jan 27, 2019 at 2:18 AM Rainer Jung wrote: When running the unit tests for trunk using Java 11 and APR connector I run out of memory, first in threads, later in heap. The prpoblematic tests are TestDefaultServletEncodingWithBom

Re: TC trunk on SLES 11 with APR and Java 11: to many threads during TestDefaultServletEncodingWith*Bom

2019-01-27 Thread Rainer Jung
probably a bit excessive. I don't understand the lifecycle of the embedded TC during the unit tests and the sendfile threads in APR well enough to be able to suggest a fix. Regards, Rainer Am 27.01.2019 um 15:10 schrieb Rainer Jung: I see the same problem on RHEL 6, but only the thread part

Re: TC trunk on SLES 11 with APR and Java 11: to many threads during TestDefaultServletEncodingWith*Bom

2019-01-27 Thread Rainer Jung
ad problem. Regards, Rainer Am 27.01.2019 um 02:18 schrieb Rainer Jung: When running the unit tests for trunk using Java 11 and APR connector I run out of memory, first in threads, later in heap. The prpoblematic tests are TestDefaultServletEncodingWithBom and TestDefaultServletEncoding

TC trunk on SLES 11 with APR and Java 11: to many threads during TestDefaultServletEncodingWith*Bom

2019-01-26 Thread Rainer Jung
When running the unit tests for trunk using Java 11 and APR connector I run out of memory, first in threads, later in heap. The prpoblematic tests are TestDefaultServletEncodingWithBom and TestDefaultServletEncodingWithoutBom. A thread dumps shows 540 sendfile threads like the following:

TC 9 plus Java 11 illegal reflective access during unit tests

2019-01-26 Thread Rainer Jung
Hi there, FYI: during unit tests run (testing tcnative) for TC trunk I get the following warnings when testing with Java 11: 166 x WARNING: Illegal reflective access by org.apache.catalina.loader.WebappClassLoaderBase (file:/.../output/classes/) to field

Re: svn commit: r1852152 - /tomcat/native/trunk/xdocs/miscellaneous/changelog.xml

2019-01-25 Thread Rainer Jung
Thanks for adding, I forgot it. Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Checked in as 1852036. My tests looked good (no crashes), but it would be useful to rerun the original memleak checks against the patched code. Regards, Rainer Am 24.01.2019 um 15:54 schrieb Rainer Jung: Am 24.01.2019 um 15:51 schrieb Rainer Jung: Am 24.01.2019 um 14:16 schrieb Mark Thomas

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Am 24.01.2019 um 15:51 schrieb Rainer Jung: Am 24.01.2019 um 14:16 schrieb Mark Thomas: On 24/01/2019 13:01, Rainer Jung wrote: Am 24.01.2019 um 13:37 schrieb Mark Thomas: It can happen in normal usage. I saw it once. It happens on Connector stop so it could be worse. My memory leak fix

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Am 24.01.2019 um 14:16 schrieb Mark Thomas: On 24/01/2019 13:01, Rainer Jung wrote: Am 24.01.2019 um 13:37 schrieb Mark Thomas: It can happen in normal usage. I saw it once. It happens on Connector stop so it could be worse. My memory leak fix is definitely the root cause. Any thoughts

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Am 24.01.2019 um 13:37 schrieb Mark Thomas: On 24/01/2019 12:18, Rainer Jung wrote: Am 21.01.2019 um 15:49 schrieb Mark Thomas: Version 1.2.20 includes the following changes compared to 1.2.19: - Fixed memory leak associated with the use of OpenSSL BIO (used when    OpenSSL provides the TLS

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Am 21.01.2019 um 15:49 schrieb Mark Thomas: Version 1.2.20 includes the following changes compared to 1.2.19: - Fixed memory leak associated with the use of OpenSSL BIO (used when OpenSSL provides the TLS functionality for the NIO and NIO2 connectors) Various other fixes and

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
I added some debug logging to native and the Java classes and the picture looks understandable now. Here the example from NIO and TestCustomSsl: - test testCustomTrustManagerNone creates OpenSSLEngine 7f560c39, ssl 4298850656 and con->pool 4309969128 from parent pool aprPool = c->pool

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Am 24.01.2019 um 11:17 schrieb Rémy Maucherat: On Thu, Jan 24, 2019 at 10:49 AM Rainer Jung wrote: The other possibility - since the crash often happens in the finalizer - that there is double destruction between normal code and finalizer code. OpenSSLEngine.shutdown is obviously very

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
ere) but I expect that it will need to be cancelled and a 1.2.21 will be required. I'll try and figure out where r1851094 went wrong. Any help gratefully received. Mark On 24/01/2019 09:41, Rainer Jung wrote: Addition: - running the same tests just replacing tcnative 1.2.20 by 1.2.19 does n

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
- since the crash often happens in the finalizer - that there is double destruction between normal code and finalizer code. But since I ran the 1.2.20 and 1.2.19 tests against the same tc 8.5 head, I doubt that. Regards, Rainer Am 24.01.2019 um 00:13 schrieb Rainer Jung: Am 21.01.2019 um 15:49

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-23 Thread Rainer Jung
Am 21.01.2019 um 15:49 schrieb Mark Thomas: Version 1.2.20 includes the following changes compared to 1.2.19: - Fixed memory leak associated with the use of OpenSSL BIO (used when OpenSSL provides the TLS functionality for the NIO and NIO2 connectors) Various other fixes and

Re: Extras

2019-01-10 Thread Rainer Jung
Am 10.01.2019 um 15:01 schrieb Rémy Maucherat: On Thu, Jan 10, 2019 at 2:53 PM Rainer Jung wrote: Am 10.01.2019 um 13:16 schrieb Rémy Maucherat: On Thu, Jan 10, 2019 at 1:09 PM Mark Thomas wrote: There is the possibility that an alternative logging JAR could return. https://markmail.org

Re: Extras

2019-01-10 Thread Rainer Jung
Am 10.01.2019 um 13:16 schrieb Rémy Maucherat: On Thu, Jan 10, 2019 at 1:09 PM Mark Thomas wrote: There is the possibility that an alternative logging JAR could return. https://markmail.org/message/gdmffcyporhcmqge Whether that needs an optional / alternative JAR or whether it could be

Re: buildbot failure in on tomcat-85-trunk

2019-01-06 Thread Rainer Jung
Hi Chris, Am 05.01.2019 um 22:25 schrieb Christopher Schultz: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Hmm... this my fault. The EncryptInterceptor tests pass on my local machine but not on the buildbot server, apparently. How can I get the log file from the test failure? junit's

Re: New design for the Tomcat website

2019-01-03 Thread Rainer Jung
Thanks Igal, Am 03.01.2019 um 02:59 schrieb Igal Sapir: Hi Tomcat team, I am working on a new design for the Tomcat website and wanted some preliminary feedback. You can see the first mockup at http://people.apache.org/~isapir/mockups/tomcat-site-1/ Please let me know your thoughts. I

Re: svn commit: r1849118 [1/9] - in /tomcat/site/trunk/docs/connectors-doc: ./ ajp/ ajp/printer/ common_howto/ common_howto/printer/ miscellaneous/ miscellaneous/printer/ news/ news/printer/ printer/

2018-12-17 Thread Rainer Jung
Looks great, thanks! Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Current problems with TLS 1.0 and NIO(2)+native+openssl 1.1.1

2018-11-29 Thread Rainer Jung
Am 29.11.2018 um 15:55 schrieb Mark Thomas: On 29/11/2018 13:27, Rémy Maucherat wrote: On Sun, Nov 25, 2018 at 10:42 AM Rainer Jung wrote: In our Java code, what happens is a call to unwrap() in OpenSSLEngine. This call writes I think 146 bytes, then checks pendingReadableBytesInSSL

Current problems with TLS 1.0 and NIO(2)+native+openssl 1.1.1

2018-11-25 Thread Rainer Jung
I observed that when building tcnative against OpenSSL 1.1.1 I ran into hangs when talking TLS 1.0 with Tomcat trunk using that tcnative plus Nio(2). A simple "GET /" request eg. send with curl, hangs for 60 seconds after a successful TLS handshake, then the client ends with an "empty reply

Re: Tagging Tomcat Native 1.2.19

2018-11-24 Thread Rainer Jung
20:37 schrieb Rainer Jung: One correction: using openssl s_client correctly does not hang. Only curl build with OpenSSL hangs. I tried my old curl builds and it seems it starts to hang with curl 7.24.0. Version 7.23.1 does not hang. The OpenSSL lib version on the client side does not seem

Re: Tagging Tomcat Native 1.2.19

2018-11-23 Thread Rainer Jung
debugging (eg. check whether APR also hangs or only NIO+native) but eventually this might end up being a curl bug. Regards, Rainer Am 23.11.2018 um 17:19 schrieb Rainer Jung: Short addition: When using Apache httpd 2.4.37 build with OpenSSL 1.1.1a, there are no hangs with TLS 1.0. So it seems

Re: Tagging Tomcat Native 1.2.19

2018-11-23 Thread Rainer Jung
Short addition: When using Apache httpd 2.4.37 build with OpenSSL 1.1.1a, there are no hangs with TLS 1.0. So it seems we have a relevant difference in our server-side use of the OpenSSL API. Easy to reproduce, but not easy to debug ... Regards, Rainer Am 23.11.2018 um 15:50 schrieb Rainer

Re: Tagging Tomcat Native 1.2.19

2018-11-23 Thread Rainer Jung
Am 23.11.2018 um 14:54 schrieb Mark Thomas: Hi all, Given bugs 62662 and 62944, I plan to tag 1.2.19 early next week with a view to including 1.2.19 in the next round of Tomcat releases. I observed a problem with TLS 1.0 under the following conditions: - using 9.0.13 with NIO plus tcnative

[Solved] Problems running TC 7 with Log4J 1.2 and Java 11

2018-11-22 Thread Rainer Jung
Am 22.11.2018 um 16:45 schrieb Rainer Jung: I have a problem running TC 7.0.92 with Log4J 1.2.17 and Java 11 when trying to load the config from ${catalina.base}/somedir/log4j.properties via server.loader=${catalina.base}/somedir in conf/catalina.properties. It works with Java 9 and 10

Re: Problems running TC 7 with Log4J 1.2 and Java 11

2018-11-22 Thread Rainer Jung
application-development/java-ee-8-high-performance> Le jeu. 22 nov. 2018 à 17:40, Rainer Jung <mailto:rainer.j...@kippdata.de>> a écrit : Hi Romain, Am 22.11.2018 um 16:53 schrieb Romain Manni-Bucau: > Hi Rainer, > > did you open some java.base modules

Re: Problems running TC 7 with Log4J 1.2 and Java 11

2018-11-22 Thread Rainer Jung
nt/java-ee-8-high-performance> Le jeu. 22 nov. 2018 à 16:45, Rainer Jung a écrit : Hi all, I have a problem running TC 7.0.92 with Log4J 1.2.17 and Java 11 when trying to load the config from ${catalina.base}/somedir/log4j.properties via server.loader=${catalina.base}/somedir in conf/cat

Problems running TC 7 with Log4J 1.2 and Java 11

2018-11-22 Thread Rainer Jung
Hi all, I have a problem running TC 7.0.92 with Log4J 1.2.17 and Java 11 when trying to load the config from ${catalina.base}/somedir/log4j.properties via server.loader=${catalina.base}/somedir in conf/catalina.properties. It works with Java 9 and 10 and it also works when using the

Re: AccessLogValve using STDOUT

2018-11-12 Thread Rainer Jung
cation-development/java-ee-8-high-performance> Le lun. 12 nov. 2018 à 10:51, Rainer Jung a écrit : Hi Mark, Am 12.11.2018 um 10:40 schrieb Mark Thomas: On 11/11/2018 10:48, Rainer Jung wrote: Hi Romain, Am 11.11.2018 um 11:16 schrieb Romain Manni-Bucau: Hi Rainer, There is an abstract

Re: AccessLogValve using STDOUT

2018-11-12 Thread Rainer Jung
Hi Mark, Am 12.11.2018 um 10:40 schrieb Mark Thomas: On 11/11/2018 10:48, Rainer Jung wrote: Hi Romain, Am 11.11.2018 um 11:16 schrieb Romain Manni-Bucau: Hi Rainer, There is an abstract access valve do providing a log impl (like [1]) can enable that - plus other standard stuff like pushing

Principal user names and JAAS

2018-11-11 Thread Rainer Jung
Hi again, in the various realm implementations we generate our own GenericPrincipal nearly always using the user name supplied by the authenticate() call. In the JAAS case there could be implementations which provide their own "real" user names in the userPrincipal they return. We do make

Re: AccessLogValve using STDOUT

2018-11-11 Thread Rainer Jung
org/apache/meecrowave/tomcat/LoggingAccessLogPattern.java Le dim. 11 nov. 2018 11:06, Rainer Jung a écrit : Hi all, I don't like it but in managed container environments application instances tend to get configured to write any log output to STDOUT (than everything is caught and redirecte

AccessLogValve using STDOUT

2018-11-11 Thread Rainer Jung
Hi all, I don't like it but in managed container environments application instances tend to get configured to write any log output to STDOUT (than everything is caught and redirected to a log concentrator). I could be wrong, but I think there is no appropriate way of doing it with our

Re: libtcnative w/custom OpenSSL on MacOS

2018-11-05 Thread Rainer Jung
Hi Chris, Am 05.11.2018 um 18:44 schrieb Christopher Schultz: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I'm trying to run tests locally (macos mojave) with a custom openssl version. I have OpenSSL (installed via brew) in /usr/local/Cellar/openssl@1.1/1.1.1, and I've copied all

Re: Mime types

2018-11-01 Thread Rainer Jung
Am 31.10.2018 um 20:15 schrieb Konstantin Kolinko: ср, 31 окт. 2018 г. в 19:38, Rémy Maucherat : ... And then all the badly maintained content from web.xml and the Tomcat class can be deleted. Comments ? 1. "badly maintained content from web.xml" Do not call them "bad". AFAIK, Those are

Re: buildbot failure in on tomcat-trunk

2018-10-23 Thread Rainer Jung
Am 23.10.2018 um 07:08 schrieb Igal Sapir: I am able to build locally on that same revision. Any ideas? You can see the reason by looking at the link included in the mail: https://ci.apache.org/builders/tomcat-trunk/builds/3677 On that page there's a red entry for "compile_1" and a link to

Re: Tomcat Native 1.2.18

2018-10-17 Thread Rainer Jung
Am 17.10.2018 um 09:47 schrieb Rainer Jung: Am 16.10.2018 um 23:01 schrieb Mark Thomas: Hi, I've been working on building this with OpenSSL 1.1.1. It wasn't as simple as I expected as there is quite a lot of clean-up in 1.1.1. I now have a working build although it required a handful

Re: Tomcat Native 1.2.18

2018-10-17 Thread Rainer Jung
Am 16.10.2018 um 23:01 schrieb Mark Thomas: Hi, I've been working on building this with OpenSSL 1.1.1. It wasn't as simple as I expected as there is quite a lot of clean-up in 1.1.1. I now have a working build although it required a handful of tweaks to the OpenSSL source. Some are bugs that

Re: svn commit: r1844066 - in /tomcat/tc8.5.x/trunk: ./ build.xml java/org/apache/tomcat/jni/Library.java res/ide-support/idea/inspections.xml res/ide-support/idea/misc.xml res/ide-support/idea/module

2018-10-17 Thread Rainer Jung
Hi Igal, yes, doing the commit after the merge is necessary. The svn merge command does not merge the commit log message. You can edit the (empty) log message even after the commit using svn propedit -r 1844066 --revprop svn:log . assuming you are inside the tc8.5.x/trunk directory

Re: TLSv1.3 and 9.0.next

2018-10-12 Thread Rainer Jung
Am 12.10.2018 um 19:39 schrieb Mark Thomas: On 12/10/18 15:55, George Stanchev wrote: Mark, Can you elaborate around the following: All combinations support server initiated requests for client certificates apart from NIO[2]+JSSE on Java 11 as the Java 11 TLSv1.3 implementation does not

Re: svn commit: r1843514 - in /tomcat/native/trunk/native: include/ssl_private.h src/sslnetwork.c src/sslutils.c

2018-10-12 Thread Rainer Jung
Am 12.10.2018 um 14:40 schrieb Rainer Jung: Am 12.10.2018 um 14:02 schrieb Mark Thomas: On 12/10/18 12:11, Rainer Jung wrote: Am 10.10.2018 um 23:54 schrieb Mark Thomas: On 10/10/18 22:49, ma...@apache.org wrote: Author: markt Date: Wed Oct 10 21:49:55 2018 New Revision: 1843514 URL: http

Re: svn commit: r1843514 - in /tomcat/native/trunk/native: include/ssl_private.h src/sslnetwork.c src/sslutils.c

2018-10-12 Thread Rainer Jung
Am 12.10.2018 um 14:15 schrieb Rémy Maucherat: On Fri, Oct 12, 2018 at 1:11 PM Rainer Jung wrote: Am 10.10.2018 um 23:54 schrieb Mark Thomas: On 10/10/18 22:49, ma...@apache.org wrote: Author: markt Date: Wed Oct 10 21:49:55 2018 New Revision: 1843514 URL: http://svn.apache.org/viewvc

Re: svn commit: r1843514 - in /tomcat/native/trunk/native: include/ssl_private.h src/sslnetwork.c src/sslutils.c

2018-10-12 Thread Rainer Jung
Am 12.10.2018 um 14:02 schrieb Mark Thomas: On 12/10/18 12:11, Rainer Jung wrote: Am 10.10.2018 um 23:54 schrieb Mark Thomas: On 10/10/18 22:49, ma...@apache.org wrote: Author: markt Date: Wed Oct 10 21:49:55 2018 New Revision: 1843514 URL: http://svn.apache.org/viewvc?rev=1843514=rev Log

Re: svn commit: r1843514 - in /tomcat/native/trunk/native: include/ssl_private.h src/sslnetwork.c src/sslutils.c

2018-10-12 Thread Rainer Jung
Am 10.10.2018 um 23:54 schrieb Mark Thomas: On 10/10/18 22:49, ma...@apache.org wrote: Author: markt Date: Wed Oct 10 21:49:55 2018 New Revision: 1843514 URL: http://svn.apache.org/viewvc?rev=1843514=rev Log: Implement TLS 1.3 support for CLIENT-CERT when the APR/native connector is not

Re: SVN Workflow and Backporting

2018-10-09 Thread Rainer Jung
Am 09.10.2018 um 06:55 schrieb Igal Sapir: On Mon, Oct 8, 2018 at 3:04 AM Mark Thomas wrote: On 06/10/18 23:08, Igal Sapir wrote: I am rather new to SVN, and actually use it mostly via GIT, i.e. `git svn rebase` and `git svn dcommit`. What is the best way to backport specific patches from

Re: [VOTE] Release JK 1.2.46

2018-10-05 Thread Rainer Jung
Am 01.10.2018 um 17:30 schrieb Mark Thomas: Tag: http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_46/ Source: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/ This is a maintenance release with a handful of bug fixes (compared to 1.2.44) and some clean-up. It also

Re: SSL Unit Tests Failing

2018-10-05 Thread Rainer Jung
Am 05.10.2018 um 00:03 schrieb Igal Sapir:> And with tcnative I get: 04-Oct-2018 14:52:14.231 INFO [main] org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case [testOpenSSLConfCmdCipher] 04-Oct-2018 14:52:14.434 INFO [main]

Re: svn commit: r1842657 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java catalina/webresources/TestAbstractArchiveResource.java catalina/webresources/TestFileResource.java coy

2018-10-02 Thread Rainer Jung
Hi Igal, Am 02.10.2018 um 23:39 schrieb isa...@apache.org: Author: isapir Date: Tue Oct 2 21:39:57 2018 New Revision: 1842657 URL: http://svn.apache.org/viewvc?rev=1842657=rev Log: Fixed test cases that errored due to path case sentsitivity on Windows ... Modified:

Re: svn commit: r1842656 - in /tomcat/trunk: java/org/apache/tomcat/util/compat/TLS.java java/org/apache/tomcat/util/net/SSLHostConfig.java webapps/docs/changelog.xml

2018-10-02 Thread Rainer Jung
Some remarks for this: Am 02.10.2018 um 23:34 schrieb rj...@apache.org: Author: rjung Date: Tue Oct 2 21:34:11 2018 New Revision: 1842656 URL: http://svn.apache.org/viewvc?rev=1842656=rev Log: Add TLSv1.3 to the default protocols and to the "all" alias for JSSE based TLS connectors when

Re: [VOTE] Release JK 1.2.45

2018-10-01 Thread Rainer Jung
s/1.2.45/1.2.46/g ? - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1841069 - in /tomcat/trunk: java/org/apache/jasper/JspC.java webapps/docs/changelog.xml

2018-09-24 Thread Rainer Jung
Am 17.09.2018 um 14:19 schrieb ma...@apache.org: Author: markt Date: Mon Sep 17 12:19:37 2018 New Revision: 1841069 URL: http://svn.apache.org/viewvc?rev=1841069=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62674 Correct a regression in the stand-alone JSP compiler utility, JspC,

Re: [VOTE] Release JK 1.2.45

2018-09-24 Thread Rainer Jung
Am 24.09.2018 um 14:27 schrieb Mark Thomas: On 24/09/2018 05:36, Rainer Jung wrote: What should we do in the light of BZ 62751 (r1841817)? It is a regression in 1.2.44 when the timeout based on poll() was added. The bug means, that a short connect (=connection setup) timeout someone might

Re: [VOTE] Release JK 1.2.45

2018-09-24 Thread Rainer Jung
What should we do in the light of BZ 62751 (r1841817)? It is a regression in 1.2.44 when the timeout based on poll() was added. The bug means, that a short connect (=connection setup) timeout someone might have configured actually results in a long timeout (using seconds instead of

Re: [VOTE] Release JK 1.2.45

2018-09-24 Thread Rainer Jung
Am 18.09.2018 um 13:21 schrieb Mark Thomas: Tag: http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_45/ Source: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/ This is a maintenance release to address a regression in 1.2.44 and to provide general improvements to the

Re: [VOTE] Release JK 1.2.45

2018-09-21 Thread Rainer Jung
Am 21.09.2018 um 14:58 schrieb Mark Thomas: On 21/09/18 13:55, Rainer Jung wrote: Am 21.09.2018 um 14:37 schrieb Mark Thomas: On 20/09/18 12:19, Mark Thomas wrote: On 20/09/18 11:27, Rainer Jung wrote: Partial results (IMHO no show-stoppers so far): - the following zip files previously

Re: [VOTE] Release JK 1.2.45

2018-09-21 Thread Rainer Jung
Am 21.09.2018 um 14:37 schrieb Mark Thomas: On 20/09/18 12:19, Mark Thomas wrote: On 20/09/18 11:27, Rainer Jung wrote: Partial results (IMHO no show-stoppers so far): - the following zip files previously contained LICENSE, NOTICE That is a show-stopper. But at least I can rebuild

Re: [VOTE] Release JK 1.2.45

2018-09-20 Thread Rainer Jung
Partial results (IMHO no show-stoppers so far): - the following zip files previously contained LICENSE, NOTICE and do no longer contain them. The symbol files in addition miss the previously contained README file: -

Re: Gump, Tomcat Native, OpenSSL and Tomcat versions

2018-09-12 Thread Rainer Jung
Am 12.09.2018 um 13:12 schrieb Mark Thomas: Gump currently tests 7.0.x, 8.5.x and 9.0.x Support for OpenSSL cipher names is available in 8.5.x onwards and we have various unit tests to ensure that our parsing code remains in sync with OpenSSL. All versions have TLS unit tests that check the

Re: tomcat-native trunk

2018-09-03 Thread Rainer Jung
Am 03.09.2018 um 11:41 schrieb Mark Thomas: On 03/09/18 09:38, jean-frederic clere wrote: Hi, I am working on a jar to laod the libraries in tomcat-native. I have noted that the examples don't compile and that the test directory is empty. I am planning to clean that and go for maven build for

Re: [VOTE] Release JK 1.2.44

2018-08-27 Thread Rainer Jung
Am 24.08.2018 um 18:56 schrieb Mark Thomas: Tag: http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_44/ Source: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/ This is a maintenance release with a handful of bug fixes and some clean-up. It also includes Windows binaries

Re: svn commit: r1838882 - /tomcat/jk/trunk/native/common/jk_lb_worker.c

2018-08-24 Thread Rainer Jung
That happens often, the MS compiler requires vars to be declared at the beginning of the block, gcc is more forgiving. Am 24.08.2018 um 17:38 schrieb ma...@apache.org: Author: markt Date: Fri Aug 24 15:38:23 2018 New Revision: 1838882 URL: http://svn.apache.org/viewvc?rev=1838882=rev Log: Fix

Re: Help with windows tcnative crash

2018-08-22 Thread Rainer Jung
Am 22.08.2018 um 15:47 schrieb Mark Thomas: On 22/08/18 13:41, Christopher Schultz wrote: All, Can someone take a quick look at my analysis of the tcnative crash described here: https://bz.apache.org/bugzilla/show_bug.cgi?id=62626 Without a debugger in Windows, I don't think I'll be able to

Re: Removing check for WEB-INF and META-INF from JK ISAPI redirector

2018-08-21 Thread Rainer Jung
Am 21.08.2018 um 14:05 schrieb Mark Thomas: Hi, I've been looking into [1] which is - essentially - that a request for http:///examples/servlets/servlet/RequestInfoExample/WEB-INF will fail when it should be allowed. Currently the JK ISAPI redirector rejects any request with a path segment

Re: [INFRA] Tomcat cannot be built due to back mirrors

2018-08-12 Thread Rainer Jung
Am 26.07.2018 um 09:03 schrieb Michael Osipov: Am 2018-07-26 um 00:55 schrieb Konstantin Kolinko: 2018-07-25 22:33 GMT+03:00 Michael Osipov : Folks, we need to inquire this with INFRA: PS D:\Entwicklung\Projekte\tomcat-8.5.x> ant Buildfile: D:\Entwicklung\Projekte\tomcat-8.5.x\build.xml

Re: Plans for AJP

2018-07-05 Thread Rainer Jung
Hi Martin, Am 05.07.2018 um 17:40 schrieb Martin Knoblauch: Hi Rainer, chiming in late... SSL support on the connector between loadbalancer and Tomcat is something that is requested from time to time. Usually from over-conscious security types. We are using mod_jk today, because of: 1) we

Re: svn commit: r1835090 - in /tomcat/trunk: bin/catalina.sh bin/ciphers.sh bin/configtest.sh bin/daemon.sh bin/digest.sh bin/makebase.sh bin/setclasspath.sh bin/shutdown.sh bin/startup.sh bin/tool-wr

2018-07-05 Thread Rainer Jung
Am 04.07.2018 um 23:46 schrieb Mark Thomas: On July 4, 2018 9:34:36 PM UTC, Rainer Jung wrote: Am 04.07.2018 um 23:05 schrieb ma...@apache.org: Author: markt Date: Wed Jul 4 21:05:58 2018 New Revision: 1835090 URL: http://svn.apache.org/viewvc?rev=1835090=rev Log: Consistently use

Re: svn commit: r1835090 - in /tomcat/trunk: bin/catalina.sh bin/ciphers.sh bin/configtest.sh bin/daemon.sh bin/digest.sh bin/makebase.sh bin/setclasspath.sh bin/shutdown.sh bin/startup.sh bin/tool-wr

2018-07-04 Thread Rainer Jung
Am 04.07.2018 um 23:05 schrieb ma...@apache.org: Author: markt Date: Wed Jul 4 21:05:58 2018 New Revision: 1835090 URL: http://svn.apache.org/viewvc?rev=1835090=rev Log: Consistently use $(...) rather than `...` The uglyness of shell: Backticks work in many shells, "$(..)" only in

Re: Slides for ApacheCon EU Roadshow 2018

2018-07-01 Thread Rainer Jung
=PLU2OcwpQkYCyuV8Fza7dVAEg5FW2Pzg-8=219s Regards, Rainer On Wed, Jun 27, 2018 at 3:39 PM, Rainer Jung wrote: Am 27.06.2018 um 01:40 schrieb Huxing Zhang: Hi All, I have check the presentation page[1] but could only find slide of Mark's "State of the Cat" topic. Do we have slides/recordings for the other t

Re: Plans for AJP

2018-06-27 Thread Rainer Jung
Am 27.06.2018 um 21:49 schrieb Igal Sapir: On 6/27/2018 11:28 AM, Rémy Maucherat wrote: On Wed, Jun 27, 2018 at 7:09 PM Mark Thomas wrote: On 27/06/18 17:50, Rainer Jung wrote: Since encryption would be most of the most useful features and IMHO we won't get there, I suggest we discuss

Plans for AJP

2018-06-27 Thread Rainer Jung
Hi there, BZ56402 is an AJP feature request and Remy postet "IMO, with each day that passes, this enhancement becomes more unrealistic and less useful. I think the decision must now be made to either start it immediately (with a volunteer ) or pass on it and freeze AJP for good." and Chris

Re: Slides for ApacheCon EU Roadshow 2018

2018-06-27 Thread Rainer Jung
Am 27.06.2018 um 01:40 schrieb Huxing Zhang: Hi All, I have check the presentation page[1] but could only find slide of Mark's "State of the Cat" topic. Do we have slides/recordings for the other topics? [1] http://tomcat.apache.org/presentations.html Thanks for asking. I just added my two

Re: svn commit: r1834060 - in /tomcat/tc8.5.x/trunk: ./ build.xml

2018-06-22 Thread Rainer Jung
Thanks for the info. I wasn't expecting that. Will check the file tomorrow (can't do it right now). Hopefully that will be in time before a 7.0 gets cut. For 8.5 the tag was before the inclusion of the md README file. Thanks and regards, Rainer Am 22.06.2018 um 00:11 schrieb Konstantin

Re: svn commit: r1833978 - /tomcat/trunk/build.xml

2018-06-21 Thread Rainer Jung
Noticed the missing ciphers.sh when doing the 9.0.10 check. Looking at the list of file mode setting in the package-tgz target of build.xml, I wonder: - shouldn't we just use name="bin/*.sh" like we do for *.exe instead of listing each file individually? I don't see any "*.sh" we would not

Re: [VOTE] Release Apache Tomcat Native 1.2.17

2018-06-12 Thread Rainer Jung
Am 07.06.2018 um 17:50 schrieb jean-frederic clere: Version 1.2.17 includes the following changes compared to 1.2.16: - Windows binaries built with OpenSSL 1.0.2o and APR 1.6.3 Various other fixes and improvements. See the changelog for details. The proposed release artefacts can be found at

Re: [VOTE] Release Apache Tomcat Native 1.2.17

2018-06-08 Thread Rainer Jung
Some early observations, at least the broken signature needs fixing: - previously sources where in a download folder named "source", now they are in "sources" (plural form). - sha1 and sha512 checksums not there, only md5. 1.2.16 had all three - file

Re: Tagging tc-native 1.2.17

2018-06-06 Thread Rainer Jung
Did you notice my reply to your r1832987? Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1832987 - /tomcat/native/trunk/native/src/sslcontext.c

2018-06-06 Thread Rainer Jung
Am 06.06.2018 um 10:25 schrieb jfcl...@apache.org: Author: jfclere Date: Wed Jun 6 08:25:53 2018 New Revision: 1832987 URL: http://svn.apache.org/viewvc?rev=1832987=rev Log: Fix for PR#62094 Modified: tomcat/native/trunk/native/src/sslcontext.c Modified:

Re: svn commit: r1830251 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/http/parser/HttpParser.java res/maven/mvn-pub.xml test/org/apache/tomcat/util/http/parser/TestHttpParserHost.java we

2018-05-14 Thread Rainer Jung
Am 30.04.2018 um 10:28 schrieb Mark Thomas: On 29/04/18 23:14, Violeta Georgieva wrote: On Sun, 29 Apr 2018 at 17:10, Violeta Georgieva wrote: On Sun, 29 Apr 2018 at 6:54, Mark Thomas wrote: On 28/04/18 17:50, Violeta Georgieva wrote: Is this

Re: Two especially slow performance tests on trunk

2018-05-14 Thread Rainer Jung
Am 11.05.2018 um 15:23 schrieb Mark Thomas: On 11/05/18 10:17, Rainer Jung wrote: Running the unit tests for trunk on my relatively slow Solaris machine, two of the performance tests run especially long: javax.websocket.TestContainerProviderPerformance: about 25 minutes per connector

Two especially slow performance tests on trunk

2018-05-11 Thread Rainer Jung
Running the unit tests for trunk on my relatively slow Solaris machine, two of the performance tests run especially long: javax.websocket.TestContainerProviderPerformance: about 25 minutes per connector. org.apache.jasper.runtime.TestTagHandlerPoolPerformance: about 5 minutes per connector.

Re: svn commit: r1830547 - in /tomcat/trunk: java/org/apache/coyote/Response.java java/org/apache/coyote/http11/Http11InputBuffer.java webapps/docs/changelog.xml

2018-05-11 Thread Rainer Jung
Am 11.05.2018 um 10:31 schrieb Mark Thomas: On 11/05/18 08:58, Rainer Jung wrote: Am 30.04.2018 um 12:57 schrieb ma...@apache.org: Author: markt Date: Mon Apr 30 10:57:27 2018 New Revision: 1830547 URL: http://svn.apache.org/viewvc?rev=1830547=rev Log: Correct a regression in the error page

  1   2   3   4   5   6   7   8   9   10   >