Re: [VOTE] Release Apache Tomcat Connectors 1.2.35

2012-03-23 Thread Henri Gomez
Due to one bug that can crash httpd in case someone has typo in JkMount directive, 1.2.34 was cancelled and here is 1.2.35. The VOTE will remain open for at least 48 hours. The Apache Tomcat Connectors 1.2.35 is  [X] Stable, go ahead and release  [ ] Broken because of ... Works for me on

svn commit: r1304249 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2012-03-23 Thread markt
Author: markt Date: Fri Mar 23 09:48:34 2012 New Revision: 1304249 URL: http://svn.apache.org/viewvc?rev=1304249view=rev Log: Remove unused code after upgrade was refactored Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java

svn commit: r1304250 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/Http11AprProcessor.java java/org/apache/coyote/http11/Http11NioProcessor.java java/org/apache/coyote/http11/Http11Proc

2012-03-23 Thread markt
Author: markt Date: Fri Mar 23 09:49:08 2012 New Revision: 1304250 URL: http://svn.apache.org/viewvc?rev=1304250view=rev Log: Remove unused code after upgrade was refactored Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1304253 - in /tomcat/trunk/java/org/apache/tomcat/util/net: NioEndpoint.java res/LocalStrings.properties

2012-03-23 Thread markt
Author: markt Date: Fri Mar 23 09:55:08 2012 New Revision: 1304253 URL: http://svn.apache.org/viewvc?rev=1304253view=rev Log: kkolinko review of r1304011: Always close selector Additionally, ensure that an exception during the close does not prevent the poller loop from ending Modified:

svn commit: r1304255 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/NioEndpoint.java java/org/apache/tomcat/util/net/res/LocalStrings.properties

2012-03-23 Thread markt
Author: markt Date: Fri Mar 23 09:56:35 2012 New Revision: 1304255 URL: http://svn.apache.org/viewvc?rev=1304255view=rev Log: kkolinko review of r1304011: Always close selector Additionally, ensure that an exception during the close does not prevent the poller loop from ending Modified:

svn commit: r1304259 - in /tomcat/site/trunk: docs/index.html xdocs/index.xml

2012-03-23 Thread kkolinko
Author: kkolinko Date: Fri Mar 23 10:09:28 2012 New Revision: 1304259 URL: http://svn.apache.org/viewvc?rev=1304259view=rev Log: Add mod_jk 1.2.33 issues warning to the front page. Modified: tomcat/site/trunk/docs/index.html tomcat/site/trunk/xdocs/index.xml Modified:

svn commit: r1304260 - /tomcat/tc7.0.x/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

2012-03-23 Thread markt
Author: markt Date: Fri Mar 23 10:11:59 2012 New Revision: 1304260 URL: http://svn.apache.org/viewvc?rev=1304260view=rev Log: Remove unused code after upgrade was refactored Modified: tomcat/tc7.0.x/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java Modified:

svn commit: r1304261 - /tomcat/tc7.0.x/trunk/

2012-03-23 Thread markt
Author: markt Date: Fri Mar 23 10:12:51 2012 New Revision: 1304261 URL: http://svn.apache.org/viewvc?rev=1304261view=rev Log: Remove unused code after upgrade was refactored Modified: tomcat/tc7.0.x/trunk/ (props changed) Propchange: tomcat/tc7.0.x/trunk/

svn commit: r1304263 - in /tomcat/site/trunk: docs/ci.html xdocs/ci.xml

2012-03-23 Thread kkolinko
Author: kkolinko Date: Fri Mar 23 10:25:12 2012 New Revision: 1304263 URL: http://svn.apache.org/viewvc?rev=1304263view=rev Log: Add links to Taglibs-All at Jenkins and tomcat-taglibs at Gump Modified: tomcat/site/trunk/docs/ci.html tomcat/site/trunk/xdocs/ci.xml Modified:

Re: svn commit: r1304261 - /tomcat/tc7.0.x/trunk/

2012-03-23 Thread Konstantin Kolinko
2012/3/23 ma...@apache.org: Author: markt Date: Fri Mar 23 10:12:51 2012 New Revision: 1304261 URL: http://svn.apache.org/viewvc?rev=1304261view=rev Log: Remove unused code after upgrade was refactored Modified:    tomcat/tc7.0.x/trunk/   (props changed) Propchange:

svn commit: r1304271 - /tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

2012-03-23 Thread markt
Author: markt Date: Fri Mar 23 10:38:42 2012 New Revision: 1304271 URL: http://svn.apache.org/viewvc?rev=1304271view=rev Log: Remove unused code after upgrade was refactored Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java Modified:

svn commit: r1304273 - /tomcat/tc7.0.x/trunk/

2012-03-23 Thread markt
Author: markt Date: Fri Mar 23 10:40:01 2012 New Revision: 1304273 URL: http://svn.apache.org/viewvc?rev=1304273view=rev Log: Update merge info Modified: tomcat/tc7.0.x/trunk/ (props changed) Propchange: tomcat/tc7.0.x/trunk/

svn commit: r1304275 - in /tomcat/trunk/java/org/apache/tomcat/util/http/parser: AstMediaType.java HttpParser.java HttpParser.jjt HttpParserConstants.java HttpParserTokenManager.java

2012-03-23 Thread markt
Author: markt Date: Fri Mar 23 10:43:17 2012 New Revision: 1304275 URL: http://svn.apache.org/viewvc?rev=1304275view=rev Log: kkolinko review of r1300154 Correctly parse quoted-pair 'charset' parameter name should be case insensitive Modified:

Re: svn commit: r1300154 [1/2] - in /tomcat/trunk: ./ java/org/apache/coyote/ java/org/apache/tomcat/util/http/parser/ test/org/apache/tomcat/util/http/parser/

2012-03-23 Thread Mark Thomas
On 23/03/2012 01:41, Konstantin Kolinko wrote: 2012/3/13 ma...@apache.org: Author: markt Date: Tue Mar 13 14:39:24 2012 New Revision: 1300154 1) It seems that quoted text handling (IN_QUOTED_TEXT TOKEN construct) is slightly wrong in its handling of backslash character. Agreed. Fixed.

buildbot failure in ASF Buildbot on tomcat-trunk

2012-03-23 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2886 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

buildbot failure in ASF Buildbot on tomcat-7-trunk

2012-03-23 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/500 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

AJP13: response message with container remote user

2012-03-23 Thread Issa.GORISSEN
Hi All, I have several web applications running on distinct tomcat instances. Apache httpd is in front of all the tomcat instances, running as a reverse proxy. Authentication is realized at the container side. Access log files are active on the httpd side. What I am missing in the httpd log

Re: AJP13: response message with container remote user

2012-03-23 Thread Konstantin Kolinko
2012/3/23 issa.goris...@ext.ec.europa.eu: Hi All, I have several web applications running on distinct tomcat instances. Apache httpd is in front of all the tomcat instances, running as a reverse proxy. Authentication is realized at the container side. Access log files are active on the

RE: AJP13: response message with container remote user

2012-03-23 Thread Issa.GORISSEN
I have several web applications running on distinct tomcat instances. Apache httpd is in front of all the tomcat instances, running as a reverse proxy. Authentication is realized at the container side. Access log files are active on the httpd side. at the container side = in Tomcat? Yes

Re: svn commit: r1300154 [1/2] - in /tomcat/trunk: ./ java/org/apache/coyote/ java/org/apache/tomcat/util/http/parser/ test/org/apache/tomcat/util/http/parser/

2012-03-23 Thread Konstantin Kolinko
2012/3/23 Mark Thomas ma...@apache.org: On 23/03/2012 01:41, Konstantin Kolinko wrote: 2012/3/13  ma...@apache.org: Author: markt Date: Tue Mar 13 14:39:24 2012 New Revision: 1300154 1)  It seems that quoted text handling (IN_QUOTED_TEXT TOKEN construct) is slightly wrong in its handling

Re: AJP13: response message with container remote user

2012-03-23 Thread Konstantin Kolinko
2012/3/23 issa.goris...@ext.ec.europa.eu: That works only if authentication is done by Tomcat.  In many cases authentication is done by 3-rd party frameworks e.g. Spring Security, inside the web application itself. I think patching the connectors and mod_jk is not a good idea here.

Re: svn commit: r1304011 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2012-03-23 Thread Konstantin Kolinko
2012/3/23 Konstantin Kolinko knst.koli...@gmail.com: 2012/3/22  ma...@apache.org: URL: http://svn.apache.org/viewvc?rev=1304011view=rev Comparing (1) and (2),  both are terminating the loop, but the (2)nd block has selector.close() call and (1)st does not have the call. I suspect that both

svn commit: r1304468 - /tomcat/trunk/java/org/apache/naming/SelectorContext.java

2012-03-23 Thread kkolinko
Author: kkolinko Date: Fri Mar 23 16:38:43 2012 New Revision: 1304468 URL: http://svn.apache.org/viewvc?rev=1304468view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=52830#c6 Alternative implementation of the fix, which does not require that name were an instance of CompositeName.

svn commit: r1304471 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/naming/SelectorContext.java

2012-03-23 Thread kkolinko
Author: kkolinko Date: Fri Mar 23 16:41:38 2012 New Revision: 1304471 URL: http://svn.apache.org/viewvc?rev=1304471view=rev Log: Merged revision 1304468 from tomcat/trunk: https://issues.apache.org/bugzilla/show_bug.cgi?id=52830#c6 Alternative implementation of the fix, which does not require

svn commit: r1304472 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-03-23 Thread kkolinko
Author: kkolinko Date: Fri Mar 23 16:44:00 2012 New Revision: 1304472 URL: http://svn.apache.org/viewvc?rev=1304472view=rev Log: update Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

DO NOT REPLY [Bug 52830] DataSource JNDI lookup with javax.naming.Name failed

2012-03-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52830 --- Comment #7 from Konstantin Kolinko knst.koli...@gmail.com 2012-03-23 16:44:30 UTC --- (In reply to comment #6) I've applied this alternative implementation in r1304468 (trunk), r1304471 (TC7) -- Configure bugmail:

svn commit: r1304483 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/loader/WebappClassLoader.java webapps/docs/changelog.xml

2012-03-23 Thread kkolinko
Author: kkolinko Date: Fri Mar 23 17:00:20 2012 New Revision: 1304483 URL: http://svn.apache.org/viewvc?rev=1304483view=rev Log: Merged revision 1298140 from tomcat/trunk: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52719 Correct theoretical resource leak during Jar validation

DO NOT REPLY [Bug 52719] An incomplete fix for the resource leak bug in WebappClassLoader.java

2012-03-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52719 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|NEW

svn commit: r1304509 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/tomcat/jni/Library.java java/org/apache/tomcat/util/net/AprEndpoint.java webapps/docs/apr.xml webapps/docs/changelog.xml

2012-03-23 Thread kkolinko
Author: kkolinko Date: Fri Mar 23 17:25:38 2012 New Revision: 1304509 URL: http://svn.apache.org/viewvc?rev=1304509view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51477 Support all SSL/TLS protocol combinations in APR connector. (rjung) Modified:

DO NOT REPLY [Bug 51477] Support all protocol combinations in SSLProtocol of APR Connector

2012-03-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51477 --- Comment #20 from Konstantin Kolinko knst.koli...@gmail.com 2012-03-23 17:27:16 UTC --- Applied to 6.0 in r1304509 and will be in 6.0.36 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are

Re: svn commit: r1304011 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2012-03-23 Thread Mark Thomas
Konstantin Kolinko knst.koli...@gmail.com wrote: 2012/3/23 Konstantin Kolinko knst.koli...@gmail.com: 2012/3/22  ma...@apache.org: URL: http://svn.apache.org/viewvc?rev=1304011view=rev Comparing (1) and (2),  both are terminating the loop, but the (2)nd block has selector.close() call

[jira] [Created] (MTOMCAT-131) maven-Tomcat-plugin Overlay Task execution fails in windows with java.io.IOException[The filename, directory name, or volume label syntax is incorrect], when targetPath

2012-03-23 Thread Tony Kollamparambil (Created) (JIRA)
maven-Tomcat-plugin Overlay Task execution fails in windows with java.io.IOException[The filename, directory name, or volume label syntax is incorrect], when targetPath is present

[jira] [Updated] (MTOMCAT-131) maven-Tomcat-plugin Overlay Task execution fails in windows with java.io.IOException[The filename, directory name, or volume label syntax is incorrect], when targetPath

2012-03-23 Thread Tony Kollamparambil (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tony Kollamparambil updated MTOMCAT-131: Description: Thanks for introducing the Overlay concept, which is very helpful.

[jira] [Updated] (MTOMCAT-131) maven-Tomcat-plugin Overlay Task execution fails in windows with java.io.IOException[The filename, directory name, or volume label syntax is incorrect], when targetPath

2012-03-23 Thread Tony Kollamparambil (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tony Kollamparambil updated MTOMCAT-131: Description: Thanks for introducing the Overlay concept, which is very helpful.

[jira] [Updated] (MTOMCAT-131) maven-Tomcat-plugin Overlay Task execution fails in windows with java.io.IOException[The filename, directory name, or volume label syntax is incorrect], when targetPath

2012-03-23 Thread Tony Kollamparambil (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tony Kollamparambil updated MTOMCAT-131: Description: Thanks for introducing the Overlay concept, which is very helpful.

[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2012-03-23 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test has an issue affecting its community integration.

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-03-23 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This