Re: svn commit: r1302479 - /tomcat/jk/trunk/native/common/jk_lb_worker.c

2012-03-27 Thread Mladen Turk
On 03/26/2012 11:46 PM, Rainer Jung wrote: Hi Mladen, for (i = 0; i p-num_of_workers; i++) { lb_sub_worker_t *w =p-lb_workers[i]; - if (w-sequence != w-s-h.sequence) { + if (w-sequence w-s-h.sequence) { I think this one is wrong. It is inside push not pull, so it should be if (local

svn commit: r1305756 - in /tomcat/jk/trunk/native/common: jk_pool.c jk_pool.h

2012-03-27 Thread mturk
Author: mturk Date: Tue Mar 27 07:33:18 2012 New Revision: 1305756 URL: http://svn.apache.org/viewvc?rev=1305756view=rev Log: Add pool_calloc so we don't need to call alloc/memzero. Also make sure that excess realloced memory is zeroed Modified: tomcat/jk/trunk/native/common/jk_pool.c

svn commit: r1305758 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/ha/authenticator/ webapps/docs/

2012-03-27 Thread kfujino
Author: kfujino Date: Tue Mar 27 07:39:45 2012 New Revision: 1305758 URL: http://svn.apache.org/viewvc?rev=1305758view=rev Log: Replicate Principal in ClusterSingleSignOn. Modified: tomcat/tc6.0.x/trunk/STATUS.txt

svn commit: r1305768 - in /tomcat/jk/trunk/native/common: jk_map.c jk_pool.c

2012-03-27 Thread mturk
Author: mturk Date: Tue Mar 27 08:04:53 2012 New Revision: 1305768 URL: http://svn.apache.org/viewvc?rev=1305768view=rev Log: Use realloc instead alloc/copy. We have that API exactly for that Modified: tomcat/jk/trunk/native/common/jk_map.c tomcat/jk/trunk/native/common/jk_pool.c

svn commit: r1305771 - in /tomcat/jk/trunk/native/common: jk_ajp12_worker.c jk_connect.c jk_lb_worker.c jk_map.c jk_shm.c jk_url.c jk_util.h

2012-03-27 Thread mturk
Author: mturk Date: Tue Mar 27 08:16:32 2012 New Revision: 1305771 URL: http://svn.apache.org/viewvc?rev=1305771view=rev Log: Unify ctype's isxxx as global macros instead those cryptic casts all over the place. No functional change Modified: tomcat/jk/trunk/native/common/jk_ajp12_worker.c

[JK] Shared memory design problems

2012-03-27 Thread Mladen Turk
Just wanted to note the problems we have with shared memory ... Currently we presume that 'someone' will initialize the shared memory and setup all struct data before the first request. This is wrong presumption, cause shared memory on IIS is initialized on first request, and with multiple

Re: AccessLogValve enhancement

2012-03-27 Thread Mark Claassen
Ok. I am back working on this again. From the previous comments, I am not sure my efforts are going in the right direction. However, I have a working implementation that uses the standard logging mechanism now, while addressing some of the previous concerns. I did a quick performance test, and

svn commit: r1305835 - /tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/DefaultProperties.java

2012-03-27 Thread markt
Author: markt Date: Tue Mar 27 13:38:15 2012 New Revision: 1305835 URL: http://svn.apache.org/viewvc?rev=1305835view=rev Log: Fix warning Modified: tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/DefaultProperties.java Modified:

buildbot failure in ASF Buildbot on tomcat-trunk

2012-03-27 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2892 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

DO NOT REPLY [Bug 52318] Version in tomcat-jdbc POM is conflicted with Version in MANIFEST for JULI JAR

2012-03-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52318 --- Comment #7 from Filip Hanik fha...@apache.org 2012-03-27 14:41:40 UTC --- (In reply to comment #6) [6.0.18, 7.0.0) means all versions from including 6.0.18 to except 7.0.0 - not including versions under 6.0.18 or above 7.0.0. To

svn commit: r1305859 - /tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/DefaultTestCase.java

2012-03-27 Thread fhanik
Author: fhanik Date: Tue Mar 27 14:59:03 2012 New Revision: 1305859 URL: http://svn.apache.org/viewvc?rev=1305859view=rev Log: Account for known missing properties Modified: tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/DefaultTestCase.java Modified:

svn commit: r1305861 - in /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool: DisposableConnectionFacade.java JdbcInterceptor.java PoolProperties.java

2012-03-27 Thread fhanik
Author: fhanik Date: Tue Mar 27 15:04:29 2012 New Revision: 1305861 URL: http://svn.apache.org/viewvc?rev=1305861view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=52002 Improvements to the pool - the default should be that multi thread close should not affect the connection

svn commit: r1305862 - /tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml

2012-03-27 Thread fhanik
Author: fhanik Date: Tue Mar 27 15:05:31 2012 New Revision: 1305862 URL: http://svn.apache.org/viewvc?rev=1305862view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=52002 Documentation change to reflect the new default value Modified:

svn commit: r1305866 - in /tomcat/tc7.0.x/trunk: modules/ webapps/docs/changelog.xml

2012-03-27 Thread fhanik
Author: fhanik Date: Tue Mar 27 15:12:13 2012 New Revision: 1305866 URL: http://svn.apache.org/viewvc?rev=1305866view=rev Log: Complete the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=52002 useDisposableConnectionFacade is by default true Modified:

DO NOT REPLY [Bug 52002] Pool re-opens and re-issues closed connection

2012-03-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52002 Filip Hanik fha...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED

DO NOT REPLY [Bug 52066] ConnectionPool.borrowConnection swallows interrupt state.

2012-03-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52066 Filip Hanik fha...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED

Re: AccessLogValve enhancement

2012-03-27 Thread Mark Claassen
That improved my timings considerably. Instead of between 300 - 1100, they are between 100 - 330. However, they are still slower than the current mechanism. (Although, I am not sure how much this benchmark is worth, anyway.) I would imagine that the Async logger has lots of optimizations in it

buildbot success in ASF Buildbot on tomcat-trunk

2012-03-27 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2893 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

buildbot failure in ASF Buildbot on tomcat-7-trunk

2012-03-27 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/507 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

buildbot failure in ASF Buildbot on tomcat-trunk

2012-03-27 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2894 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-03-27 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This

DO NOT REPLY [Bug 52066] ConnectionPool.borrowConnection swallows interrupt state.

2012-03-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52066 Alexander Pogrebnyak alex-pub.apache-...@reflexion.net changed: What|Removed |Added Status|RESOLVED

svn commit: r1305921 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java

2012-03-27 Thread fhanik
Author: fhanik Date: Tue Mar 27 17:32:49 2012 New Revision: 1305921 URL: http://svn.apache.org/viewvc?rev=1305921view=rev Log: simplify logic, less comparisons on each call Modified: tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java

svn commit: r1305931 - in /tomcat/trunk/modules/jdbc-pool: doc/ src/main/java/org/apache/tomcat/jdbc/pool/ src/main/java/org/apache/tomcat/jdbc/pool/jmx/

2012-03-27 Thread fhanik
Author: fhanik Date: Tue Mar 27 17:55:41 2012 New Revision: 1305931 URL: http://svn.apache.org/viewvc?rev=1305931view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=52066 Add in a configuration attribute to allow a thread interrupt state to be retained for the calling library to see

svn commit: r1305933 - in /tomcat/tc7.0.x/trunk: modules/ webapps/docs/changelog.xml

2012-03-27 Thread fhanik
Author: fhanik Date: Tue Mar 27 17:58:41 2012 New Revision: 1305933 URL: http://svn.apache.org/viewvc?rev=1305933view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=52066 Add in configuration option to allow a thread to retain its interrupt state. Modified:

DO NOT REPLY [Bug 52066] ConnectionPool.borrowConnection swallows interrupt state.

2012-03-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52066 Filip Hanik fha...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED

buildbot success in ASF Buildbot on tomcat-trunk

2012-03-27 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2895 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

DO NOT REPLY [Bug 52744] [Jasper] JSP files are always recompiled in development mode

2012-03-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52744 --- Comment #9 from Mark Thomas ma...@apache.org 2012-03-27 18:10:33 UTC --- I can't reproduce this. What tool on what platform is being used to create zip files with entries with a precision of better than 1s? -- Configure bugmail:

DO NOT REPLY [Bug 52744] [Jasper] JSP files are always recompiled in development mode

2012-03-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52744 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|NEEDINFO --

DO NOT REPLY [Bug 52853] @HandlesTypes not resolving classes when added as repository directory

2012-03-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52853 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|NEEDINFO ---

svn commit: r1305943 - /tomcat/trunk/java/org/apache/catalina/core/StandardServer.java

2012-03-27 Thread markt
Author: markt Date: Tue Mar 27 18:28:35 2012 New Revision: 1305943 URL: http://svn.apache.org/viewvc?rev=1305943view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52833 Fix NPE in some embedded / osgi scenarios where the class loader my not have the system class loader as a

buildbot failure in ASF Buildbot on tomcat-trunk

2012-03-27 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2896 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1305949 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/StandardServer.java webapps/docs/changelog.xml

2012-03-27 Thread markt
Author: markt Date: Tue Mar 27 18:41:42 2012 New Revision: 1305949 URL: http://svn.apache.org/viewvc?rev=1305949view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52833 Fix NPE in some embedded / osgi scenarios where the class loader my not have the system class loader as a

DO NOT REPLY [Bug 52833] NPE with 7.0.26

2012-03-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52833 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1305951 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java

2012-03-27 Thread markt
Author: markt Date: Tue Mar 27 18:49:51 2012 New Revision: 1305951 URL: http://svn.apache.org/viewvc?rev=1305951view=rev Log: Fix unused import Modified: tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java Modified:

buildbot success in ASF Buildbot on tomcat-trunk

2012-03-27 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2897 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

DO NOT REPLY [Bug 52318] Version in tomcat-jdbc POM is conflicted with Version in MANIFEST for JULI JAR

2012-03-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52318 --- Comment #8 from pan4o ssku4...@web.de 2012-03-27 19:20:09 UTC --- (In reply to comment #7) Yes, because ... tomcat-jdbc in the version 7.0.22 has a dependency in the pom file to tomcat-juli in the version 7.0.22 ... soo MANIFEST:

svn commit: r1305965 - /tomcat/trunk/java/org/apache/catalina/startup/WebAnnotationSet.java

2012-03-27 Thread markt
Author: markt Date: Tue Mar 27 19:20:10 2012 New Revision: 1305965 URL: http://svn.apache.org/viewvc?rev=1305965view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52974 Fix NameNotFoundException when field/method is annotated with @Resource annotation Patch provided by Violet

svn commit: r1305966 - /tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml

2012-03-27 Thread markt
Author: markt Date: Tue Mar 27 19:20:22 2012 New Revision: 1305966 URL: http://svn.apache.org/viewvc?rev=1305966view=rev Log: Whitespace police Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml URL:

svn commit: r1305971 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/WebAnnotationSet.java webapps/docs/changelog.xml

2012-03-27 Thread markt
Author: markt Date: Tue Mar 27 19:27:39 2012 New Revision: 1305971 URL: http://svn.apache.org/viewvc?rev=1305971view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52974 Fix NameNotFoundException when field/method is annotated with @Resource annotation Patch provided by Violet

DO NOT REPLY [Bug 52974] NameNotFoundException is thrown when field/method is annotated with @Resource annotation

2012-03-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52974 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

buildbot failure in ASF Buildbot on tomcat-trunk

2012-03-27 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2898 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

Time for 7.0.27

2012-03-27 Thread Mark Thomas
The 7.0.x change log is looking long again and with the only open TC7 bugs in NEEDINFO state, I am going to start the process of rolling the 7.0.27 release. I'm not going to tag 7.0.27 until I've confirmed that all the various tests pass and they'll probably take a day or so to run. Mark

svn commit: r1305976 - /tomcat/tc7.0.x/trunk/modules/

2012-03-27 Thread markt
Author: markt Date: Tue Mar 27 19:35:13 2012 New Revision: 1305976 URL: http://svn.apache.org/viewvc?rev=1305976view=rev Log: Pick-up clean-up Modified: tomcat/tc7.0.x/trunk/modules/ (props changed) Propchange: tomcat/tc7.0.x/trunk/modules/

Re: [VOTE] Release Apache Taglibs Parent POM 3

2012-03-27 Thread Olivier Lamy
+1 2012/3/26 Jeremy Boynes jboy...@apache.org: The proposed 3 release of Apache Taglibs Parent POM is now available for voting. This release addresses issues found during the 1 release process including duplicate LICENSE files and poor site configuration, and updates the copyright date

buildbot success in ASF Buildbot on tomcat-trunk

2012-03-27 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/2899 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

DO NOT REPLY [Bug 51744] JNDI Lookup Error after a Context is closed

2012-03-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51744 --- Comment #15 from mmaure...@gmail.com 2012-03-27 22:03:48 UTC --- I'm using Tomcat 7.0.25 and am still seeing this same issue. Any attempt to close a Context object results in the exception Context is read only, and I am unable to

DO NOT REPLY [Bug 51744] JNDI Lookup Error after a Context is closed

2012-03-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51744 mmaure...@gmail.com changed: What|Removed |Added CC||mmaure...@gmail.com --

Re: Time for 7.0.27

2012-03-27 Thread Konstantin Kolinko
2012/3/27 Mark Thomas ma...@apache.org: The 7.0.x change log is looking long again and with the only open TC7 bugs in NEEDINFO state, I am going to start the process of rolling the 7.0.27 release. I'm not going to tag 7.0.27 until I've confirmed that all the various tests pass and they'll

svn commit: r1306130 - in /tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties UserConfig.java

2012-03-27 Thread kfujino
Author: kfujino Date: Wed Mar 28 02:51:21 2012 New Revision: 1306130 URL: http://svn.apache.org/viewvc?rev=1306130view=rev Log: Add support for multi-thread deployment in UserConfig. Modified: tomcat/trunk/java/org/apache/catalina/startup/LocalStrings.properties

svn commit: r1306131 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/startup/LocalStrings.properties java/org/apache/catalina/startup/UserConfig.java webapps/docs/changelog.xml

2012-03-27 Thread kfujino
Author: kfujino Date: Wed Mar 28 02:55:37 2012 New Revision: 1306131 URL: http://svn.apache.org/viewvc?rev=1306131view=rev Log: Add support for multi-thread deployment in UserConfig. Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/LocalStrings.properties

[jira] [Updated] (MTOMCAT-131) maven-Tomcat-plugin Overlay Task execution fails in windows with java.io.IOException[The filename, directory name, or volume label syntax is incorrect], when targetPath

2012-03-27 Thread Tony Kollamparambil (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tony Kollamparambil updated MTOMCAT-131: Priority: Critical (was: Minor) Overlay is failing in windows. And its/Overlay

[jira] [Updated] (MTOMCAT-131) maven-Tomcat-plugin Overlay Task execution fails in windows with java.io.IOException[The filename, directory name, or volume label syntax is incorrect], when targetPath

2012-03-27 Thread Tony Kollamparambil (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tony Kollamparambil updated MTOMCAT-131: Environment: Windows (was: Fails in Windows, it works fine in Mac Linux/Unix)

[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2012-03-27 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test has an issue affecting its community integration.

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-03-27 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This