Re: writing tomcat filters

2012-06-26 Thread Mark Thomas
On 25/06/2012 23:04, Varrun Ramani wrote: Hi I am in the process developing a web application firewall(WAF) for tomcat similar to what mod security does, and am planning to use the filter API already present in tomcat to intercept requests and do the filtering. While going through the

svn commit: r1353976 - /tomcat/jk/trunk/native/configure.in

2012-06-26 Thread mturk
Author: mturk Date: Tue Jun 26 12:02:26 2012 New Revision: 1353976 URL: http://svn.apache.org/viewvc?rev=1353976view=rev Log: First step in IPv6 support -- add configure bits Modified: tomcat/jk/trunk/native/configure.in Modified: tomcat/jk/trunk/native/configure.in URL:

[Bug 53469] New: possible bug in Response.normalize(CharChunk cc)

2012-06-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53469 Priority: P2 Bug ID: 53469 Assignee: dev@tomcat.apache.org Summary: possible bug in Response.normalize(CharChunk cc) Severity: normal Classification: Unclassified Reporter:

[Bug 53460] Use error handling when TooManyActiveSessionsException happens in JSP

2012-06-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53460 --- Comment #1 from Mark Thomas ma...@apache.org --- I'm leaning towards: - re-throwing the original exception if a PageContext can't be created - modifying the generated JSP code so if no PageContext is present any error is wrapped in a

svn commit: r1354021 - in /tomcat/jk/trunk: native/common/jk_status.c xdocs/miscellaneous/changelog.xml

2012-06-26 Thread mturk
Author: mturk Date: Tue Jun 26 13:58:27 2012 New Revision: 1354021 URL: http://svn.apache.org/viewvc?rev=1354021view=rev Log: Fix status worker not updating parameters for all members Modified: tomcat/jk/trunk/native/common/jk_status.c tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml

svn commit: r1354101 - /tomcat/jk/trunk/native/configure.in

2012-06-26 Thread mturk
Author: mturk Date: Tue Jun 26 16:32:51 2012 New Revision: 1354101 URL: http://svn.apache.org/viewvc?rev=1354101view=rev Log: More config functions we'll use Modified: tomcat/jk/trunk/native/configure.in Modified: tomcat/jk/trunk/native/configure.in URL:

svn commit: r1354107 - /tomcat/jk/trunk/native/configure.in

2012-06-26 Thread mturk
Author: mturk Date: Tue Jun 26 16:48:06 2012 New Revision: 1354107 URL: http://svn.apache.org/viewvc?rev=1354107view=rev Log: Be consistent in HAVE_foo naming Modified: tomcat/jk/trunk/native/configure.in Modified: tomcat/jk/trunk/native/configure.in URL:

Re: svn commit: r1353709 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/ssl-howto.xml

2012-06-26 Thread Konstantin Kolinko
2012/6/25 ma...@apache.org: Author: markt Date: Mon Jun 25 19:29:44 2012 New Revision: 1353709 URL: http://svn.apache.org/viewvc?rev=1353709view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53459 Fix SSLVerifyClient option in APR SSL example and further clarify how to

svn commit: r1354112 - in /tomcat/trunk/java/javax/servlet: ./ http/

2012-06-26 Thread fhanik
Author: fhanik Date: Tue Jun 26 17:07:22 2012 New Revision: 1354112 URL: http://svn.apache.org/viewvc?rev=1354112view=rev Log: In preparation for next servlet revision Align with the servlet specification signatures as they are defined by the spec itself. These do not represent any functional

Re: svn commit: r1354112 - in /tomcat/trunk/java/javax/servlet: ./ http/

2012-06-26 Thread Konstantin Kolinko
2012/6/26 fha...@apache.org: Author: fhanik Date: Tue Jun 26 17:07:22 2012 New Revision: 1354112 URL: http://svn.apache.org/viewvc?rev=1354112view=rev Log: In preparation for next servlet revision Align with the servlet specification signatures as they are defined by the spec itself.

svn commit: r1354137 - /tomcat/trunk/webapps/docs/ssl-howto.xml

2012-06-26 Thread markt
Author: markt Date: Tue Jun 26 17:59:06 2012 New Revision: 1354137 URL: http://svn.apache.org/viewvc?rev=1354137view=rev Log: Align protocol values with the surrounding text Modified: tomcat/trunk/webapps/docs/ssl-howto.xml Modified: tomcat/trunk/webapps/docs/ssl-howto.xml URL:

svn commit: r1354138 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/ssl-howto.xml

2012-06-26 Thread markt
Author: markt Date: Tue Jun 26 18:00:01 2012 New Revision: 1354138 URL: http://svn.apache.org/viewvc?rev=1354138view=rev Log: Align protocol values with the surrounding text Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/webapps/docs/ssl-howto.xml Propchange:

Re: svn commit: r1353709 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/ssl-howto.xml

2012-06-26 Thread Mark Thomas
On 26/06/2012 17:56, Konstantin Kolinko wrote: 2012/6/25 ma...@apache.org: - The example above will throw an error if you have the APR and the Tomcat Native libraries in your path, - as Tomcat will try to use the APR connector. The APR connector uses different attributes for - SSL

RE: svn commit: r1354112 - in /tomcat/trunk/java/javax/servlet: ./ http/

2012-06-26 Thread Filip Hanik (mailing lists)
-Original Message- From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] Sent: Tuesday, June 26, 2012 11:38 AM To: Tomcat Developers List Subject: Re: svn commit: r1354112 - in /tomcat/trunk/java/javax/servlet: ./ http/ 2012/6/26 fha...@apache.org: Author: fhanik Date:

svn commit: r1354158 - in /tomcat/trunk/java: javax/servlet/ javax/servlet/http/ org/apache/catalina/connector/ org/apache/catalina/filters/ org/apache/catalina/ssi/ org/apache/jasper/tagplugins/jstl/

2012-06-26 Thread fhanik
Author: fhanik Date: Tue Jun 26 18:38:09 2012 New Revision: 1354158 URL: http://svn.apache.org/viewvc?rev=1354158view=rev Log: Add in stub methods from servlet draft per http://java.net/projects/servlet-spec/lists/jsr340-experts/archive/2012-06/message/9 Note this may change at which point we

buildbot failure in ASF Buildbot on tomcat-trunk

2012-06-26 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3122 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1354166 - in /tomcat/trunk/java/javax/servlet: ReadListener.java WriteListener.java http/ProtocolHandler.java http/WebConnection.java

2012-06-26 Thread fhanik
Author: fhanik Date: Tue Jun 26 18:56:52 2012 New Revision: 1354166 URL: http://svn.apache.org/viewvc?rev=1354166view=rev Log: Add missing classes Added: tomcat/trunk/java/javax/servlet/ReadListener.java (with props) tomcat/trunk/java/javax/servlet/WriteListener.java (with props)

svn commit: r1354170 - /tomcat/trunk/webapps/docs/setup.xml

2012-06-26 Thread markt
Author: markt Date: Tue Jun 26 19:02:55 2012 New Revision: 1354170 URL: http://svn.apache.org/viewvc?rev=1354170view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53464 Correct file location (it was moved from Commons Daemon to bin/) Modified:

svn commit: r1354171 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/setup.xml

2012-06-26 Thread markt
Author: markt Date: Tue Jun 26 19:04:50 2012 New Revision: 1354171 URL: http://svn.apache.org/viewvc?rev=1354171view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53464 Correct file location (it was moved from Commons Daemon to bin/) Modified: tomcat/tc7.0.x/trunk/ (props

[Bug 53464] Tomcat installation instructions reference init.d file that does not exist / document init.d

2012-06-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53464 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1354173 - in /tomcat/trunk/modules/jdbc-pool: doc/ src/main/java/org/apache/tomcat/jdbc/pool/ src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ src/test/java/org/apache/tomcat/jdbc/t

2012-06-26 Thread fhanik
Author: fhanik Date: Tue Jun 26 19:08:27 2012 New Revision: 1354173 URL: http://svn.apache.org/viewvc?rev=1354173view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53445 by allowing a) override the getObjectName method of the SlowQueryReportJmx class b) specify the

[Bug 53445] Support consistent Jmx object naming strategy across managed resources

2012-06-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53445 Filip Hanik fha...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1354174 - in /tomcat/tc7.0.x/trunk: modules/ webapps/docs/changelog.xml

2012-06-26 Thread fhanik
Author: fhanik Date: Tue Jun 26 19:12:07 2012 New Revision: 1354174 URL: http://svn.apache.org/viewvc?rev=1354174view=rev Log: Fixed https://issues.apache.org/bugzilla/show_bug.cgi?id=53445 Modified: tomcat/tc7.0.x/trunk/modules/ (props changed)

[Bug 53445] Support consistent Jmx object naming strategy across managed resources

2012-06-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53445 --- Comment #2 from Filip Hanik fha...@apache.org --- Will be available in Tomcat 7.0.29 and onwards through r1354174 -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1354176 - /tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml

2012-06-26 Thread markt
Author: markt Date: Tue Jun 26 19:13:58 2012 New Revision: 1354176 URL: http://svn.apache.org/viewvc?rev=1354176view=rev Log: Whitespace police Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml Modified: tomcat/trunk/modules/jdbc-pool/doc/jdbc-pool.xml URL:

svn commit: r1354177 - /tomcat/tc7.0.x/trunk/modules/

2012-06-26 Thread markt
Author: markt Date: Tue Jun 26 19:15:10 2012 New Revision: 1354177 URL: http://svn.apache.org/viewvc?rev=1354177view=rev Log: whitespace police Modified: tomcat/tc7.0.x/trunk/modules/ (props changed) Propchange: tomcat/tc7.0.x/trunk/modules/

svn commit: r1354178 - in /tomcat/trunk: test/org/apache/catalina/filters/TesterResponse.java webapps/examples/WEB-INF/classes/compressionFilters/CompressionResponseStream.java

2012-06-26 Thread fhanik
Author: fhanik Date: Tue Jun 26 19:15:32 2012 New Revision: 1354178 URL: http://svn.apache.org/viewvc?rev=1354178view=rev Log: Add in test and examples to compile with 3.1 additions Modified: tomcat/trunk/test/org/apache/catalina/filters/TesterResponse.java

svn commit: r1354197 - in /tomcat/trunk/java/org/apache/jasper: compiler/Generator.java runtime/JspFactoryImpl.java

2012-06-26 Thread markt
Author: markt Date: Tue Jun 26 19:57:07 2012 New Revision: 1354197 URL: http://svn.apache.org/viewvc?rev=1354197view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53460 There are two parts to this fix: - don't swallow exceptions when the PageContext can't be created - if the

buildbot success in ASF Buildbot on tomcat-trunk

2012-06-26 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3126 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

svn commit: r1354200 - in /tomcat/trunk/java: javax/servlet/jsp/PageContext.java org/apache/jasper/runtime/JspContextWrapper.java org/apache/jasper/runtime/JspFactoryImpl.java org/apache/jasper/runtim

2012-06-26 Thread markt
Author: markt Date: Tue Jun 26 20:06:21 2012 New Revision: 1354200 URL: http://svn.apache.org/viewvc?rev=1354200view=rev Log: Simplify. Modified: tomcat/trunk/java/javax/servlet/jsp/PageContext.java tomcat/trunk/java/org/apache/jasper/runtime/JspContextWrapper.java

svn commit: r1354202 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/Generator.java java/org/apache/jasper/runtime/JspFactoryImpl.java webapps/docs/changelog.xml

2012-06-26 Thread markt
Author: markt Date: Tue Jun 26 20:09:37 2012 New Revision: 1354202 URL: http://svn.apache.org/viewvc?rev=1354202view=rev Log: There are two parts to this fix: - don't swallow exceptions when the PageContext can't be created - if the PageContext is null when an error occurs (and therefore can't be

[Bug 53460] Use error handling when TooManyActiveSessionsException happens in JSP

2012-06-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53460 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

Timing for 7.0.29

2012-06-26 Thread Mark Thomas
I'm sure circumstances will conspire against me but I am currently planning to start the 7.0.29 release process early next week. That aligns with my general aim of getting a release out at the start of each month and there are some regressions in 7.0.28 that I'd rather fix sooner than later. Mark

Re: svn commit: r1354200 - in /tomcat/trunk/java: javax/servlet/jsp/PageContext.java org/apache/jasper/runtime/JspContextWrapper.java org/apache/jasper/runtime/JspFactoryImpl.java org/apache/jasper/ru

2012-06-26 Thread Konstantin Kolinko
2012/6/27 ma...@apache.org: Author: markt Date: Tue Jun 26 20:06:21 2012 New Revision: 1354200 URL: http://svn.apache.org/viewvc?rev=1354200view=rev Log: Simplify. Modified:    tomcat/trunk/java/javax/servlet/jsp/PageContext.java PageContext belongs to javax.servlet.jsp.*. I doubt

RE: Timing for 7.0.29

2012-06-26 Thread Filip Hanik (mailing lists)
+1 -Original Message- From: Mark Thomas [mailto:ma...@apache.org] Sent: Tuesday, June 26, 2012 2:12 PM To: Tomcat Developers List Subject: Timing for 7.0.29 I'm sure circumstances will conspire against me but I am currently planning to start the 7.0.29 release process early next

Re: svn commit: r1354200 - in /tomcat/trunk/java: javax/servlet/jsp/PageContext.java org/apache/jasper/runtime/JspContextWrapper.java org/apache/jasper/runtime/JspFactoryImpl.java org/apache/jasper/ru

2012-06-26 Thread Mark Thomas
On 26/06/2012 21:19, Konstantin Kolinko wrote: 2012/6/27 ma...@apache.org: Author: markt Date: Tue Jun 26 20:06:21 2012 New Revision: 1354200 URL: http://svn.apache.org/viewvc?rev=1354200view=rev Log: Simplify. Modified: tomcat/trunk/java/javax/servlet/jsp/PageContext.java

svn commit: r1354208 - in /tomcat/trunk/java: javax/servlet/jsp/PageContext.java org/apache/jasper/runtime/JspContextWrapper.java org/apache/jasper/runtime/JspFactoryImpl.java org/apache/jasper/runtim

2012-06-26 Thread markt
Author: markt Date: Tue Jun 26 20:26:39 2012 New Revision: 1354208 URL: http://svn.apache.org/viewvc?rev=1354208view=rev Log: Revert r1354200. As much as I'd like to be able to unilaterally change the JSP API, I can't. Modified: tomcat/trunk/java/javax/servlet/jsp/PageContext.java

svn commit: r1354211 - in /tomcat/trunk/java/org/apache/jasper/runtime: JspFactoryImpl.java PageContextImpl.java

2012-06-26 Thread markt
Author: markt Date: Tue Jun 26 20:30:27 2012 New Revision: 1354211 URL: http://svn.apache.org/viewvc?rev=1354211view=rev Log: Clean up Modified: tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java Modified:

[Bug 53416] Two datasources with the same name in different web applications results in javax.management.InstanceAlreadyExistsException

2012-06-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53416 --- Comment #1 from Filip Hanik fha...@apache.org --- Created attachment 29000 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29000action=edit JMX Registration of two pools The name of the JMX bean that gets registered is unique

[Bug 53416] Two datasources with the same name in different web applications results in javax.management.InstanceAlreadyExistsException

2012-06-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53416 Filip Hanik fha...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 53283] Add Support for Externalized Data Source Credentials

2012-06-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53283 --- Comment #7 from Filip Hanik fha...@apache.org --- No need for the patch, if you implement an object that has the interface: org.apache.tomcat.util.IntrospectionUtils.PropertySource and set the PROPERTY_SOURCE system variable as

[Bug 53416] Two datasources with the same name in different web applications results in javax.management.InstanceAlreadyExistsException

2012-06-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53416 Anthony Gerrard anthonygerrard+apache@gmail.com changed: What|Removed |Added Status|RESOLVED

[Bug 53416] Two datasources with the same name in different web applications results in javax.management.InstanceAlreadyExistsException

2012-06-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53416 --- Comment #4 from Mark Thomas ma...@apache.org --- Use of multiple versions of a web application may also trigger the issue (I haven't tested it). -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1354255 - in /tomcat/trunk: java/org/apache/catalina/startup/WebRuleSet.java test/org/apache/naming/resources/TestNamingContext.java test/webapp-3.0/WEB-INF/web.xml

2012-06-26 Thread markt
Author: markt Date: Tue Jun 26 22:02:04 2012 New Revision: 1354255 URL: http://svn.apache.org/viewvc?rev=1354255view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53465 Populate mapped-name property for resources defined in web.xml Based on a patch by Violeta Georgieva

svn commit: r1354258 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/WebRuleSet.java test/org/apache/naming/resources/TestNamingContext.java test/webapp-3.0/WEB-INF/web.xml webapps/doc

2012-06-26 Thread markt
Author: markt Date: Tue Jun 26 22:04:17 2012 New Revision: 1354258 URL: http://svn.apache.org/viewvc?rev=1354258view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53465 Populate mapped-name property for resources defined in web.xml Based on a patch by Violeta Georgieva

[Bug 53465] mapped-name is read when in @Resource, but not when in web.xml

2012-06-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53465 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: Timing for 7.0.29

2012-06-26 Thread Jess Holle
Do you have a list of known regressions (vs. bugs just discovered since 7.0.27)? On 6/26/2012 3:11 PM, Mark Thomas wrote: I'm sure circumstances will conspire against me but I am currently planning to start the 7.0.29 release process early next week. That aligns with my general aim of getting

Re: Timing for 7.0.29

2012-06-26 Thread Mark Thomas
On 26/06/2012 23:12, Jess Holle wrote: Do you have a list of known regressions (vs. bugs just discovered since 7.0.27)? Look at the open bugs against 7.0.x in Bugzilla and search the changelog for the word regression. Of the top of my head: BZ 53450, 53467, 53469 I haven't investigated the

buildbot failure in ASF Buildbot on tomcat-trunk

2012-06-26 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3129 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

buildbot failure in ASF Buildbot on tomcat-7-trunk

2012-06-26 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/707 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-06-26 Thread Konstantin Kolinko
2012/6/27 build...@apache.org: The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at:  http://ci.apache.org/builders/tomcat-trunk/builds/3129 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu

[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2012-06-26 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test has an issue affecting its community integration.

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-06-26 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This