Re: Timing for 7.0.29

2012-06-27 Thread Mladen Turk
+1 On 06/26/2012 10:11 PM, Mark Thomas wrote: and there are some regressions in 7.0.28 that I'd rather fix sooner than later. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2012-06-27 Thread Mark Thomas
On 27/06/2012 05:48, Konstantin Kolinko wrote: 2012/6/27 build...@apache.org: The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3129 Buildbot URL:

svn commit: r1354362 - /tomcat/trunk/test/webapp-3.0/bug53465.jsp

2012-06-27 Thread markt
Author: markt Date: Wed Jun 27 08:17:14 2012 New Revision: 1354362 URL: http://svn.apache.org/viewvc?rev=1354362view=rev Log: Add file missed in r1354255 Added: tomcat/trunk/test/webapp-3.0/bug53465.jsp (with props) Added: tomcat/trunk/test/webapp-3.0/bug53465.jsp URL:

svn commit: r1354364 - in /tomcat/tc7.0.x/trunk: ./ test/webapp-3.0/bug53465.jsp

2012-06-27 Thread markt
Author: markt Date: Wed Jun 27 08:18:06 2012 New Revision: 1354364 URL: http://svn.apache.org/viewvc?rev=1354364view=rev Log: Add file missed in r1354258 Added: tomcat/tc7.0.x/trunk/test/webapp-3.0/bug53465.jsp - copied unchanged from r1354362,

[Bug 53473] New: Error in isVirtualWebappRelative param configuration

2012-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53473 Priority: P2 Bug ID: 53473 Assignee: dev@tomcat.apache.org Summary: Error in isVirtualWebappRelative param configuration Severity: minor Classification: Unclassified

svn commit: r1354375 - in /tomcat/trunk/java/org/apache/catalina/websocket: WebSocketServlet.java WsFrame.java WsInputStream.java

2012-06-27 Thread markt
Author: markt Date: Wed Jun 27 08:51:57 2012 New Revision: 1354375 URL: http://svn.apache.org/viewvc?rev=1354375view=rev Log: Add some finals Modified: tomcat/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java tomcat/trunk/java/org/apache/catalina/websocket/WsFrame.java

[Bug 53454] Default doHead implementation overrides 'Content-Length' header

2012-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53454 --- Comment #3 from Nikita Skvortsov n.s.skvort...@gmail.com --- Christopher, Thank you for provided workaround. I will use it. Still, I agree with Mark, that it is Tomcat's implementation of API, and it violates API specification in part

buildbot success in ASF Buildbot on tomcat-trunk

2012-06-27 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3130 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

buildbot success in ASF Buildbot on tomcat-7-trunk

2012-06-27 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/708 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

svn commit: r1354469 - in /tomcat/trunk: java/org/apache/catalina/websocket/ test/org/apache/catalina/websocket/ webapps/examples/WEB-INF/classes/websocket/chat/ webapps/examples/WEB-INF/classes/webso

2012-06-27 Thread markt
Author: markt Date: Wed Jun 27 12:46:05 2012 New Revision: 1354469 URL: http://svn.apache.org/viewvc?rev=1354469view=rev Log: Make the request available when the WebSocket connection is being created Added: tomcat/trunk/java/org/apache/catalina/websocket/WsHttpServletRequestWrapper.java

svn commit: r1354472 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/websocket/WebSocketServlet.java java/org/apache/catalina/websocket/WsFrame.java java/org/apache/catalina/websocket/WsInputS

2012-06-27 Thread markt
Author: markt Date: Wed Jun 27 12:47:42 2012 New Revision: 1354472 URL: http://svn.apache.org/viewvc?rev=1354472view=rev Log: Add finals Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WebSocketServlet.java

svn commit: r1354477 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/websocket/ test/org/apache/catalina/websocket/ webapps/docs/ webapps/examples/WEB-INF/classes/websocket/chat/ webapps/examp

2012-06-27 Thread markt
Author: markt Date: Wed Jun 27 12:50:37 2012 New Revision: 1354477 URL: http://svn.apache.org/viewvc?rev=1354477view=rev Log: Make the request available when the WebSocket connection is being created Added:

[Bug 53467] 7.0.28 will no longer accept our jsp filenames

2012-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53467 --- Comment #1 from Mark Thomas ma...@apache.org --- Just for information (to save others having to look up RFC 2396) ',' is reserved, '[' is not permitted and ']' is not permitted. All three must be escaped before being used. This does

Shouldn't Servlet 3.0 file upload delete temporary files after request completes

2012-06-27 Thread Konstantin Kolinko
Hi! I was experimenting with Servlet 3.0 file upload. What seems odd is that after request is processed the uploaded files are still present in the work directory of the web application. The only way to reliably delete those files is what HTMLManagerServlet does, like IteratorPart iter

RE: Race condition in DefaultServlet

2012-06-27 Thread Caldarale, Charles R
From: Chris R [mailto:chris.tech...@gmail.com] Subject: Race condition in DefaultServlet If multiple threads call doPut(...), there is a possibility that they can clobber each other and the value of accessCount may not really give the exact number of accesses of the cache. Which is noted

[Bug 53416] Two datasources with the same name in different web applications results in javax.management.InstanceAlreadyExistsException

2012-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53416 --- Comment #5 from Filip Hanik fha...@apache.org --- Roger, I will fix this. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe,

Re: Shouldn't Servlet 3.0 file upload delete temporary files after request completes

2012-06-27 Thread Mark Thomas
On 27/06/2012 17:19, Konstantin Kolinko wrote: Hi! I was experimenting with Servlet 3.0 file upload. What seems odd is that after request is processed the uploaded files are still present in the work directory of the web application. The only way to reliably delete those files is what

[Bug 53416] Two datasources with the same name in different web applications results in javax.management.InstanceAlreadyExistsException

2012-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53416 --- Comment #6 from Filip Hanik fha...@apache.org --- (In reply to comment #4) Use of multiple versions of a web application may also trigger the issue (I haven't tested it). That wont be issue, as the ObjectName will have something like

svn commit: r1354641 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSource.java

2012-06-27 Thread fhanik
Author: fhanik Date: Wed Jun 27 17:36:05 2012 New Revision: 1354641 URL: http://svn.apache.org/viewvc?rev=1354641view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53416 Make sure we retain the domain if the registration comes from Tomcat Modified:

svn commit: r1354642 - in /tomcat/tc7.0.x/trunk: modules/ webapps/docs/changelog.xml

2012-06-27 Thread fhanik
Author: fhanik Date: Wed Jun 27 17:38:08 2012 New Revision: 1354642 URL: http://svn.apache.org/viewvc?rev=1354642view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53416 Modified: tomcat/tc7.0.x/trunk/modules/ (props changed)

[Bug 53454] Default doHead implementation overrides 'Content-Length' header

2012-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53454 --- Comment #4 from Christopher Schultz ch...@christopherschultz.net --- (In reply to comment #2) It is Tomcat's implementation of the Servlet API so this is a Tomcat bug. Oh, I didn't realize that the servlet-api.jar that ships with

[Bug 53416] Two datasources with the same name in different web applications results in javax.management.InstanceAlreadyExistsException

2012-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53416 Filip Hanik fha...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED

[Bug 53467] 7.0.28 will no longer accept our jsp filenames

2012-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53467 --- Comment #2 from Mark Thomas ma...@apache.org --- r1345357 is not responsible for this. It looks like r1344890 is. I am currently looking for a solution that works with this bug, bug53257 and bug51584. -- You are receiving this mail

svn commit: r1354664 - in /tomcat/trunk: java/org/apache/catalina/core/ApplicationContext.java test/org/apache/catalina/core/TestApplicationContext.java test/webapp-3.0/bug53467].jsp

2012-06-27 Thread markt
Author: markt Date: Wed Jun 27 18:50:50 2012 New Revision: 1354664 URL: http://svn.apache.org/viewvc?rev=1354664view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53467 Use more explicit URI constructor to ensure components are correctly encoded. Added:

svn commit: r1354667 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ApplicationContext.java test/org/apache/catalina/core/TestApplicationContext.java test/webapp-3.0/bug53467].jsp webapp

2012-06-27 Thread markt
Author: markt Date: Wed Jun 27 18:54:58 2012 New Revision: 1354667 URL: http://svn.apache.org/viewvc?rev=1354667view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53467 Use more explicit URI constructor to ensure components are correctly encoded. Added:

[Bug 53467] 7.0.28 will no longer accept our jsp filenames

2012-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53467 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

Starting on 3.1 implementation

2012-06-27 Thread Filip Hanik (mailing lists)
As some of you noticed, I added in the stubs for Servlet 3.1 yesterday. I'm planning on starting on 3.1 features, mainly the non blocking read/writes. In Tomcat, we already have an implementation of this in the sandbox http://svn.apache.org/viewvc/tomcat/sandbox/gdev6x/ That works fully, and

[Bug 53469] possible bug in Response.normalize(CharChunk cc)

2012-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53469 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: Starting on 3.1 implementation

2012-06-27 Thread Mark Thomas
On 27/06/2012 20:16, Filip Hanik (mailing lists) wrote: As some of you noticed, I added in the stubs for Servlet 3.1 yesterday. I'm planning on starting on 3.1 features, mainly the non blocking read/writes. In Tomcat, we already have an implementation of this in the sandbox

svn commit: r1354685 - in /tomcat/trunk: conf/web.xml webapps/docs/ssi-howto.xml

2012-06-27 Thread markt
Author: markt Date: Wed Jun 27 19:37:19 2012 New Revision: 1354685 URL: http://svn.apache.org/viewvc?rev=1354685view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53473 Correct documentation and web.xml comments for SSI isVirtualWebappRelative option since the allowed values

svn commit: r1354686 - in /tomcat/tc7.0.x/trunk: ./ conf/web.xml webapps/docs/changelog.xml webapps/docs/ssi-howto.xml

2012-06-27 Thread markt
Author: markt Date: Wed Jun 27 19:38:46 2012 New Revision: 1354686 URL: http://svn.apache.org/viewvc?rev=1354686view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53473 Correct documentation and web.xml comments for SSI isVirtualWebappRelative option since the allowed values

[Bug 53473] Error in isVirtualWebappRelative param configuration

2012-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53473 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

RE: Starting on 3.1 implementation

2012-06-27 Thread Filip Hanik (mailing lists)
3.1 seems to be a fairly minor update so far, so we should be able to start pushing Tomcat 8 right around the time as the spec is finalized. Just a word of caution. The EG is far from agreed on the best way to do the non-blocking API at the moment. As with happened with the 3.0 async

Re: Starting on 3.1 implementation

2012-06-27 Thread Mark Thomas
On 27/06/2012 20:49, Filip Hanik (mailing lists) wrote: My current focus on Tomcat 8 is re-factoring the resources to remove all the JNDI stuff. After that, I'll probably look at the HTTP upgrade bit. [Filip Hanik] Interesting, what's up with JNDI, prolly something I missed from an earlier

RE: Starting on 3.1 implementation

2012-06-27 Thread Filip Hanik (mailing lists)
3.1 seems to be a fairly minor update so far, so we should be able to start pushing Tomcat 8 right around the time as the spec is finalized. Just a word of caution. The EG is far from agreed on the best way to do the non-blocking API at the moment. As with happened with the 3.0 async

svn commit: r1354817 - in /tomcat/trunk: java/org/apache/catalina/ant/antlib.xml webapps/docs/ssi-howto.xml

2012-06-27 Thread kkolinko
Author: kkolinko Date: Thu Jun 28 05:44:54 2012 New Revision: 1354817 URL: http://svn.apache.org/viewvc?rev=1354817view=rev Log: Correct typos in recent commits Modified: tomcat/trunk/java/org/apache/catalina/ant/antlib.xml tomcat/trunk/webapps/docs/ssi-howto.xml Modified:

svn commit: r1354818 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/ssi-howto.xml

2012-06-27 Thread kkolinko
Author: kkolinko Date: Thu Jun 28 05:47:30 2012 New Revision: 1354818 URL: http://svn.apache.org/viewvc?rev=1354818view=rev Log: Correct typo in r1354686 It is merge of revision 1354817 from trunk Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1354820 - in /tomcat/tc6.0.x/trunk: ./ conf/web.xml webapps/docs/changelog.xml webapps/docs/ssi-howto.xml

2012-06-27 Thread kkolinko
Author: kkolinko Date: Thu Jun 28 05:54:00 2012 New Revision: 1354820 URL: http://svn.apache.org/viewvc?rev=1354820view=rev Log: CTR: docs Merged revision 1354685 from tomcat/trunk: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53473 Correct documentation and web.xml comments for SSI