Re: svn commit: r1560931 - in /tomcat/tc7.0.x/trunk: build.xml java/org/apache/tomcat/util/descriptor/DigesterFactory.java

Hi, 2014-03-13 23:12 GMT+02:00 Konstantin Kolinko knst.koli...@gmail.com: 2014-03-13 16:28 GMT+04:00 Violeta Georgieva miles...@gmail.com: Hi, In OSGi world the functionality is separated in different bundles and schemes for servlet API is in one bundle and schemes for JSP API in

Re: svn commit: r1560931 - in /tomcat/tc7.0.x/trunk: build.xml java/org/apache/tomcat/util/descriptor/DigesterFactory.java

Hi, 2014-03-13 23:33 GMT+02:00 Mark Thomas ma...@apache.org: On 13/03/2014 13:41, Violeta Georgieva wrote: 2014-03-13 15:28 GMT+02:00 Mark Thomas ma...@apache.org: snip/ What exactly is it that we want to cover? I can think of a number of requirements. 1. Ensure that Tomcat still

Re: svn commit: r1577328 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/descriptor/DigesterFactory.java java/org/apache/tomcat/util/descriptor/LocalStrings.properties webapps/docs/changelo

2014-03-14 0:43 GMT+02:00 Konstantin Kolinko knst.koli...@gmail.com: 1. addSelf() is odd, does not match with TC8. Bad merge? 2. Both add() and addSelf() should display a warning. Maybe move log.warn() into locationFor(..) method. 3. What is the point of putting null values into the maps. 4.

Re: svn commit: r1577328 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/descriptor/DigesterFactory.java java/org/apache/tomcat/util/descriptor/LocalStrings.properties webapps/docs/changelo

On 13/03/2014 22:43, Konstantin Kolinko wrote: 1. addSelf() is odd, does not match with TC8. Bad merge? Yes, it was a bad merge. I'll get that fixed. 2. Both add() and addSelf() should display a warning. Maybe move log.warn() into locationFor(..) method. Good idea. Will do. 3. What is the

svn commit: r1577463 - in /tomcat/trunk/java/org/apache/tomcat/util/descriptor: DigesterFactory.java LocalStrings.properties

Author: markt Date: Fri Mar 14 09:37:26 2014 New Revision: 1577463 URL: http://svn.apache.org/r1577463 Log: Review by kkolinko Avoid adding nulls to the map Log a warning for problems in addSelf() as well as add() Modified:

svn commit: r1577464 - /tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/descriptor/DigesterFactory.java

Author: markt Date: Fri Mar 14 09:38:14 2014 New Revision: 1577464 URL: http://svn.apache.org/r1577464 Log: Fix bad merge Review by kkolinko Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/descriptor/DigesterFactory.java Modified:

svn commit: r1577465 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/descriptor/DigesterFactory.java java/org/apache/tomcat/util/descriptor/LocalStrings.properties

Author: markt Date: Fri Mar 14 09:40:15 2014 New Revision: 1577465 URL: http://svn.apache.org/r1577465 Log: Review by kkolinko Avoid adding nulls to the map Log a warning for problems in addSelf() as well as add() Modified: tomcat/tc7.0.x/trunk/ (props changed)

buildbot failure in ASF Buildbot on tomcat-7-trunk

The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1802 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

[Bug 56236] tomcat cannot startup since version 6.0.39,7.0.52,8.0 on some machines.

https://issues.apache.org/bugzilla/show_bug.cgi?id=56236 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Resolution|FIXED |INVALID

svn commit: r1577489 - /tomcat/trunk/webapps/docs/changelog.xml

Author: kkolinko Date: Fri Mar 14 11:41:35 2014 New Revision: 1577489 URL: http://svn.apache.org/r1577489 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56236 Add issue number Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml

svn commit: r1577492 - /tomcat/trunk/webapps/docs/changelog.xml

Author: kkolinko Date: Fri Mar 14 11:44:47 2014 New Revision: 1577492 URL: http://svn.apache.org/r1577492 Log: Fix trailing whitespace. Sorry for the noise. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

svn commit: r1577493 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Author: kkolinko Date: Fri Mar 14 11:45:12 2014 New Revision: 1577493 URL: http://svn.apache.org/r1577493 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56236 Add issue number Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified:

svn commit: r1577495 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: kkolinko Date: Fri Mar 14 11:46:28 2014 New Revision: 1577495 URL: http://svn.apache.org/r1577495 Log: Add issue number and vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r1577501 - in /tomcat/trunk/java/org/apache/coyote/http11: InternalNio2InputBuffer.java InternalNio2OutputBuffer.java upgrade/Nio2ServletInputStream.java upgrade/Nio2ServletOutputStream.ja

Author: remm Date: Fri Mar 14 12:09:48 2014 New Revision: 1577501 URL: http://svn.apache.org/r1577501 Log: Start harmonizing exception types (todo: same thing for completion handlers). Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalNio2InputBuffer.java

buildbot success in ASF Buildbot on tomcat-7-trunk

The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1803 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

buildbot failure in ASF Buildbot on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5594 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1577544 - /tomcat/trunk/test/org/apache/jasper/compiler/TestELParser.java

Author: markt Date: Fri Mar 14 14:14:29 2014 New Revision: 1577544 URL: http://svn.apache.org/r1577544 Log: Add a couple more tests based on a report on the users list (There tests pass, the problem looks to be elsewhere) Modified:

svn commit: r1577546 - /tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java

Author: remm Date: Fri Mar 14 14:24:09 2014 New Revision: 1577546 URL: http://svn.apache.org/r1577546 Log: Experiment some more with this test and NIO2 (sorry for the noise). Modified: tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java Modified:

[Bug 56239] NullPointerException when finishing response under the Linux traffic control

https://issues.apache.org/bugzilla/show_bug.cgi?id=56239 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1577557 - /tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java

Author: kkolinko Date: Fri Mar 14 14:54:13 2014 New Revision: 1577557 URL: http://svn.apache.org/r1577557 Log: Better reporting for skipped tests. With org.junit.Assume the tests are clearly reported as 'skipped' in JUnit test run summary. Modified:

svn commit: r1577561 - /tomcat/trunk/java/org/apache/tomcat/util/net/SecureNio2Channel.java

Author: remm Date: Fri Mar 14 15:02:18 2014 New Revision: 1577561 URL: http://svn.apache.org/r1577561 Log: Improve the FutureWrite logic so that writing starts when creating it, and then will recurse on get until the content is actually written. Modified:

svn commit: r1577562 - /tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java

Author: kkolinko Date: Fri Mar 14 15:02:25 2014 New Revision: 1577562 URL: http://svn.apache.org/r1577562 Log: Better reporting for skipped tests. With org.junit.Assume the tests are clearly reported as 'skipped' in JUnit test run summary. Modified:

[Bug 56256] Multiple cookies and parallel deployment

https://issues.apache.org/bugzilla/show_bug.cgi?id=56256 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1577565 - in /tomcat/trunk/test/org/apache/tomcat/util/net: TestClientCert.java TestCustomSsl.java TestSsl.java

Author: kkolinko Date: Fri Mar 14 15:17:27 2014 New Revision: 1577565 URL: http://svn.apache.org/r1577565 Log: Better reporting for skipped tests. With org.junit.Assume the tests are clearly reported as 'skipped' in JUnit test run summary. Modified:

buildbot success in ASF Buildbot on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5595 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

svn commit: r1577569 - /tomcat/trunk/java/org/apache/tomcat/util/net/SecureNio2Channel.java

Author: remm Date: Fri Mar 14 15:21:26 2014 New Revision: 1577569 URL: http://svn.apache.org/r1577569 Log: Add missing code to retry if no bytes are written (handshake) like for blocking IO, and use EOFException instead. Modified:

svn commit: r1577581 - in /tomcat/trunk/test/org/apache/tomcat/util/net: TestClientCert.java TestCustomSsl.java TestSsl.java

Author: kkolinko Date: Fri Mar 14 15:43:47 2014 New Revision: 1577581 URL: http://svn.apache.org/r1577581 Log: Correct typo in the message Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TestClientCert.java tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java

svn commit: r1577582 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/comet/TestCometProcessor.java test/org/apache/tomcat/util/net/TestClientCert.java test/org/apache/tomcat/util/net/TestCusto

Author: kkolinko Date: Fri Mar 14 15:46:45 2014 New Revision: 1577582 URL: http://svn.apache.org/r1577582 Log: Merged revisions r1577557 r1577565 r1577581 from tomcat/trunk: Better reporting for skipped tests. With org.junit.Assume the tests are clearly reported as 'skipped' in JUnit test run

svn commit: r1577598 - /tomcat/trunk/java/org/apache/tomcat/util/net/SecureNio2Channel.java

Author: remm Date: Fri Mar 14 16:11:40 2014 New Revision: 1577598 URL: http://svn.apache.org/r1577598 Log: Make sure the byte buffer passed as a parameter is used in all read/write operations (come code is from the NIO1 which forces using the main read/write buffers). Modified:

[Bug 56190] Connection keep-alive not working with asynchronous servlet

https://issues.apache.org/bugzilla/show_bug.cgi?id=56190 --- Comment #11 from Francois-Xavier Bonnet f...@apache.org --- Thanks. I just tested. Everything works as expected now. -- You are receiving this mail because: You are the assignee for the bug.

[jira] [Created] (MTOMCAT-264) uriEncoding parameter not applied to HTTPS connector

Andreas Christoforides created MTOMCAT-264: -- Summary: uriEncoding parameter not applied to HTTPS connector Key: MTOMCAT-264 URL: https://issues.apache.org/jira/browse/MTOMCAT-264 Project:

buildbot failure in ASF Buildbot on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5596 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

[jira] [Updated] (MTOMCAT-264) uriEncoding parameter not working with HTTPS and run goal

[ https://issues.apache.org/jira/browse/MTOMCAT-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Christoforides updated MTOMCAT-264: --- Description: The uriEncoding parameter does not work when using HTTPS with

[jira] [Commented] (MTOMCAT-237) Maven variables not evaluated/resolved inside systemProperties

[ https://issues.apache.org/jira/browse/MTOMCAT-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13935400#comment-13935400 ] Andreas Christoforides commented on MTOMCAT-237: I was mistaken in my

svn commit: r1577665 - /tomcat/trunk/test/org/apache/jasper/TestJspC.java

Author: kkolinko Date: Fri Mar 14 19:16:54 2014 New Revision: 1577665 URL: http://svn.apache.org/r1577665 Log: 1. Do not hardcode the path to output directory. It can be controlled via build.properties. 2. Cleanup after the test. Modified: tomcat/trunk/test/org/apache/jasper/TestJspC.java

[Bug 56265] New: Unexpected escaping in the values of dynamic tag attributes containing EL expressions

https://issues.apache.org/bugzilla/show_bug.cgi?id=56265 Bug ID: 56265 Summary: Unexpected escaping in the values of dynamic tag attributes containing EL expressions Product: Tomcat 7 Version: 7.0.52 Hardware: PC

[Bug 56265] Unexpected escaping in the values of dynamic tag attributes containing EL expressions

https://issues.apache.org/bugzilla/show_bug.cgi?id=56265 --- Comment #1 from Konstantin Kolinko knst.koli...@gmail.com --- Created attachment 31388 -- https://issues.apache.org/bugzilla/attachment.cgi?id=31388action=edit test.war A simple web application that reproduces this issue. Steps to

[Bug 56265] Unexpected escaping in the values of dynamic tag attributes containing EL expressions

https://issues.apache.org/bugzilla/show_bug.cgi?id=56265 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added OS||All

[Bug 56266] New: Property location incorrect in build instructions

https://issues.apache.org/bugzilla/show_bug.cgi?id=56266 Bug ID: 56266 Summary: Property location incorrect in build instructions Product: Tomcat 7 Version: 7.0.52 Hardware: PC Status: NEW Severity: minor

[Bug 56266] Property location incorrect in build instructions

https://issues.apache.org/bugzilla/show_bug.cgi?id=56266 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|NEW

svn commit: r1577714 - /tomcat/trunk/test/org/apache/catalina/ha/session/TestSerializablePrincipal.java

Author: kkolinko Date: Fri Mar 14 21:15:36 2014 New Revision: 1577714 URL: http://svn.apache.org/r1577714 Log: Properly delete %TEMP%/ser{number}.tmp temporary file that was used to test serialization of a Principal. On Windows the test could not delete the file, because FileInputStream has not

svn commit: r1577721 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/ha/session/TestSerializablePrincipal.java

Author: kkolinko Date: Fri Mar 14 21:21:29 2014 New Revision: 1577721 URL: http://svn.apache.org/r1577721 Log: Merged r1577714 from tomcat/trunk: Properly delete %TEMP%/ser{number}.tmp temporary file that was used to test serialization of a Principal. On Windows the test could not delete the

svn commit: r1577757 - in /tomcat/trunk/java/org/apache/tomcat/util/net: Nio2Endpoint.java SecureNio2Channel.java

Author: remm Date: Fri Mar 14 23:13:00 2014 New Revision: 1577757 URL: http://svn.apache.org/r1577757 Log: Implement the read/write pending contract in the SSL channel (not doing so would likely still trigger the exception, but would add corruption). Modified:

[Bug 56265] Unexpected escaping in the values of dynamic tag attributes containing EL expressions

https://issues.apache.org/bugzilla/show_bug.cgi?id=56265 --- Comment #3 from Konstantin Kolinko knst.koli...@gmail.com --- Thus far: 1. It is reproducible with the current trunk The following line numbers are from debugging the reproducer with current trunk @1577714. 2. 'setDynamicAttribute('

[Bug 56265] Unexpected escaping in the values of dynamic tag attributes containing EL expressions

https://issues.apache.org/bugzilla/show_bug.cgi?id=56265 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Severity|normal

[Bug 56265] Unexpected escaping in the values of dynamic tag attributes containing EL expressions

https://issues.apache.org/bugzilla/show_bug.cgi?id=56265 --- Comment #4 from Konstantin Kolinko knst.koli...@gmail.com --- Created attachment 31390 -- https://issues.apache.org/bugzilla/attachment.cgi?id=31390action=edit 2014-03-15_56265_tc8_v1.patch Patch for this issue. Essentially it limits

[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration.