[Bug 56597] tomcat 8 svn tags is not standard so not synced to git

2014-06-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56597 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1600833 - /tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java

2014-06-06 Thread markt
Author: markt Date: Fri Jun 6 09:19:17 2014 New Revision: 1600833 URL: http://svn.apache.org/r1600833 Log: Don't assume that tests use the StandardManger Modified: tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java Modified:

buildbot retry in ASF Buildbot on tomcat-trunk

2014-06-06 Thread buildbot
on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/151 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1600833

svn commit: r1600839 - in /tomcat/trunk: java/org/apache/catalina/ha/session/DeltaSession.java test/org/apache/catalina/session/TestStandardSession.java webapps/docs/changelog.xml

2014-06-06 Thread markt
Author: markt Date: Fri Jun 6 10:25:49 2014 New Revision: 1600839 URL: http://svn.apache.org/r1600839 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56578 Correct regression in the fix for 56339 that prevented sessions from expiring when using clustering. The effect of removing

svn commit: r1600840 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ha/session/DeltaSession.java test/org/apache/catalina/session/TestStandardSession.java webapps/docs/changelog.xml

2014-06-06 Thread markt
Author: markt Date: Fri Jun 6 10:33:15 2014 New Revision: 1600840 URL: http://svn.apache.org/r1600840 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56578 Correct regression in the fix for 56339 that prevented sessions from expiring when using clustering. The effect of removing

[Bug 56578] session.invalidate does not work on cluster enabled webapps

2014-06-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56578 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

The Early Access build for JDK 8u20 b16 is available on java.net

2014-06-06 Thread Rory O'Donnell Oracle, Dublin Ireland
Hi Mark, The backport fix for JDK-8041481 https://bugs.openjdk.java.net/browse/JDK-8041481 is in JDK 8u20 b17 as JDK-8039751 https://bugs.openjdk.java.net/browse/JDK-8039751, available for download https://jdk8.java.net/download.html . Can you test and report results ? Rgds,Rory --

Re: Error handling

2014-06-06 Thread Konstantin Kolinko
2014-05-29 16:31 GMT+04:00 Mark Thomas ma...@apache.org: You've probably noticed I've been poking around the ErrorReportValve, the Response objects and other related code. I've been looking into an issue that one of the groups at $work has raised around Tomcat's error handling and I've been

buildbot failure in ASF Buildbot on tomcat-7-trunk

2014-06-06 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/97 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1600846 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2014-06-06 Thread kkolinko
Author: kkolinko Date: Fri Jun 6 11:38:57 2014 New Revision: 1600846 URL: http://svn.apache.org/r1600846 Log: Fix ordering of changelog entries according to bug number. Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL:

Re: buildbot failure in ASF Buildbot on tomcat-7-trunk

2014-06-06 Thread Konstantin Kolinko
2014-06-06 15:37 GMT+04:00 build...@apache.org: The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/97 Buildbot URL: http://ci.apache.org/ Buildslave for this

svn commit: r1600858 - /tomcat/tc7.0.x/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java

2014-06-06 Thread markt
Author: markt Date: Fri Jun 6 12:02:38 2014 New Revision: 1600858 URL: http://svn.apache.org/r1600858 Log: Don't assume that tests use the StandardManger Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java Modified:

svn commit: r1600862 - /tomcat/trunk/test/org/apache/coyote/http11/TestAbstractHttp11Processor.java

2014-06-06 Thread kkolinko
Author: kkolinko Date: Fri Jun 6 12:10:18 2014 New Revision: 1600862 URL: http://svn.apache.org/r1600862 Log: Verify that response is flushed when servlet fails with an unexpected exception. Modified: tomcat/trunk/test/org/apache/coyote/http11/TestAbstractHttp11Processor.java Modified:

[Bug 56580] el-api.jar memory leak

2014-06-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56580 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

Time for 8.0.9

2014-06-06 Thread Mark Thomas
As I have said before, I'd like to get back to my original plane for monthly releases of 8.0.x. With that in mind - and unless some new bugs appear in the next few hours - I plan to tag 8.0.9 later today. Mark - To unsubscribe,

[Bug 56581] When an error occurs on a long JSP page, do not loose last chunk of printed text

2014-06-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56581 --- Comment #3 from Konstantin Kolinko knst.koli...@gmail.com --- Looking into generated test_jsp.java, I see that _jspService method ends with the following: [[[ } catch (java.lang.Throwable t) { if (!(t instanceof

buildbot failure in ASF Buildbot on tomcat-trunk

2014-06-06 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/153 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1600899 - in /tomcat/trunk: java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

2014-06-06 Thread kkolinko
Author: kkolinko Date: Fri Jun 6 14:36:36 2014 New Revision: 1600899 URL: http://svn.apache.org/r1600899 Log: Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=56581 If an error on a JSP page occurs when response have already been committed, do not clear the buffer of JspWriter, but flush

[Bug 56581] When an error occurs on a long JSP page, do not loose last chunk of printed text

2014-06-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56581 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|NEW

[Bug 54618] Add filter implementing HTTP Strict Transport Security (HSTS) [PATCH]

2014-06-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54618 Christopher Schultz ch...@christopherschultz.net changed: What|Removed |Added Attachment #3|application/octet-stream

[Bug 54618] Add filter implementing HTTP Strict Transport Security (HSTS) [PATCH]

2014-06-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54618 --- Comment #9 from Christopher Schultz ch...@christopherschultz.net --- (In reply to Steve Sether from comment #8) I think this is an important feature for Tomcat to support out of the box. Then vote for it: there are currently 5 votes

[Bug 54618] Add filter implementing HTTP Strict Transport Security (HSTS) [PATCH]

2014-06-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54618 --- Comment #10 from Christopher Schultz ch...@christopherschultz.net --- I think there is a bug in the Filter implementation provided by Jens: The filter calls chain.doFilter() and then adds the header afterward. This isn't going to work

[Bug 54618] Add filter implementing HTTP Strict Transport Security (HSTS) [PATCH]

2014-06-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54618 --- Comment #11 from Konstantin Kolinko knst.koli...@gmail.com --- (In reply to Christopher Schultz from comment #9) The Filter can be added to conf/web.xml and will apply to all web applications hosted by the container. I'm not sure in

[Bug 54618] Add filter implementing HTTP Strict Transport Security (HSTS) [PATCH]

2014-06-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54618 --- Comment #12 from Konstantin Kolinko knst.koli...@gmail.com --- (In reply to Steve Sether from comment #8) Furthermore though, headers like this should be insanely easy to just add to all the headers of a domain hosted on a machine.

[Bug 55975] Inconsistent escaping applied to V0 cookie values

2014-06-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55975 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|RESOLVED

svn commit: r1600948 - /tomcat/trunk/java/org/apache/jasper/servlet/JspServlet.java

2014-06-06 Thread kkolinko
Author: kkolinko Date: Fri Jun 6 16:09:16 2014 New Revision: 1600948 URL: http://svn.apache.org/r1600948 Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=56568 Fix missing return statement for JSP method name check. Modified:

[Bug 56600] New: Missing return statements in WebdavServlet.doPropfind()

2014-06-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56600 Bug ID: 56600 Summary: Missing return statements in WebdavServlet.doPropfind() Product: Tomcat 8 Version: 8.0.8 Hardware: PC Status: NEW

svn commit: r1600950 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java webapps/docs/changelog.xml

2014-06-06 Thread remm
Author: remm Date: Fri Jun 6 16:14:44 2014 New Revision: 1600950 URL: http://svn.apache.org/r1600950 Log: Try removing the beta tag from the NIO2 connector to get more feedback, after the latest round of fixes. In practice since it is not used by default, it doesn't change much. Modified:

Re: svn commit: r1600950 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java webapps/docs/changelog.xml

2014-06-06 Thread Rémy Maucherat
2014-06-06 18:14 GMT+02:00 r...@apache.org: Author: remm Date: Fri Jun 6 16:14:44 2014 New Revision: 1600950 URL: http://svn.apache.org/r1600950 Log: Try removing the beta tag from the NIO2 connector to get more feedback, after the latest round of fixes. In practice since it is not used

svn commit: r1600955 - in /tomcat/trunk: java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

2014-06-06 Thread kkolinko
Author: kkolinko Date: Fri Jun 6 16:24:32 2014 New Revision: 1600955 URL: http://svn.apache.org/r1600955 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56600 Fix missing return; statements after sendError(): do not waste time generating response for PROPFIND requests that contain

svn commit: r1600956 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

2014-06-06 Thread kkolinko
Author: kkolinko Date: Fri Jun 6 16:30:50 2014 New Revision: 1600956 URL: http://svn.apache.org/r1600956 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56600 Fix missing return; statements after sendError(): do not waste time generating response for PROPFIND requests that contain

svn commit: r1600957 - /tomcat/trunk/webapps/docs/changelog.xml

2014-06-06 Thread kkolinko
Author: kkolinko Date: Fri Jun 6 16:31:53 2014 New Revision: 1600957 URL: http://svn.apache.org/r1600957 Log: Correct a typo. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

svn commit: r1600958 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-06-06 Thread kkolinko
Author: kkolinko Date: Fri Jun 6 16:34:49 2014 New Revision: 1600958 URL: http://svn.apache.org/r1600958 Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

[Bug 56600] Missing return statements in WebdavServlet.doPropfind()

2014-06-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56600 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|NEW

Re: svn commit: r1600950 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java webapps/docs/changelog.xml

2014-06-06 Thread Konstantin Kolinko
2014-06-06 20:17 GMT+04:00 Rémy Maucherat r...@apache.org: 2014-06-06 18:14 GMT+02:00 r...@apache.org: Author: remm Date: Fri Jun 6 16:14:44 2014 New Revision: 1600950 URL: http://svn.apache.org/r1600950 Log: Try removing the beta tag from the NIO2 connector to get more feedback, after

[Bug 56573] [Spec?] Session.getRequestURI() doesn't return the protocol, port etc.

2014-06-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56573 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|RESOLVED|REOPENED

svn commit: r1600960 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/server/ test/org/apache/tomcat/websocket/server/ webapps/docs/

2014-06-06 Thread markt
Author: markt Date: Fri Jun 6 16:49:21 2014 New Revision: 1600960 URL: http://svn.apache.org/r1600960 Log: Revert fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=56573 The fix triggered a TCK failure Removed:

svn commit: r1600961 - in /tomcat/trunk: java/org/apache/tomcat/websocket/server/ test/org/apache/tomcat/websocket/server/ webapps/docs/

2014-06-06 Thread markt
Author: markt Date: Fri Jun 6 16:50:24 2014 New Revision: 1600961 URL: http://svn.apache.org/r1600961 Log: Revert fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=56573 The fix triggered a TCK failure Removed:

[Bug 56573] [Spec?] Session.getRequestURI() doesn't return the protocol, port etc.

2014-06-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56573 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED

svn commit: r1600963 - /tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java

2014-06-06 Thread markt
Author: markt Date: Fri Jun 6 16:58:02 2014 New Revision: 1600963 URL: http://svn.apache.org/r1600963 Log: Handle exceptions when trying to flush the response. Modified: tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java Modified:

Re: Error handling

2014-06-06 Thread Mark Thomas
On 06/06/2014 12:29, Konstantin Kolinko wrote: snip/ Reviewing r1600449 and followups. // ErrorReportValve.java [[[ if (response.isCommitted()) { if (response.isErrorAfterCommit()) { // Flush any data that is still to be written to the client

Re: Error handling

2014-06-06 Thread Mark Thomas
On 06/06/2014 18:01, Mark Thomas wrote: On 06/06/2014 12:29, Konstantin Kolinko wrote: snip/ Reviewing r1600449 and followups. // ErrorReportValve.java [[[ if (response.isCommitted()) { if (response.isErrorAfterCommit()) { // Flush any data that is

svn commit: r1600965 - in /tomcat/trunk/java/org/apache/catalina: core/StandardHostValve.java valves/ErrorReportValve.java

2014-06-06 Thread markt
Author: markt Date: Fri Jun 6 17:14:19 2014 New Revision: 1600965 URL: http://svn.apache.org/r1600965 Log: kkolinko review Use finishResponse() rather than flushBuffer to avoid chunking if not necessary. Add finishResponse() to ErrorReportValve.report() Don;t try and reset the response if it has

Re: svn commit: r1600950 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java webapps/docs/changelog.xml

2014-06-06 Thread Rémy Maucherat
2014-06-06 18:39 GMT+02:00 Konstantin Kolinko knst.koli...@gmail.com: 1. Doesn't it feel too early? Maybe, but tests pass and no reports. 2. You only removed a startup warning. I think the documentation still labels it as beta. This could be a good middle ground. Rémy

buildbot success in ASF Buildbot on tomcat-7-trunk

2014-06-06 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/101 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

svn commit: r1600978 - /tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedInputFilter.java

2014-06-06 Thread markt
Author: markt Date: Fri Jun 6 18:38:09 2014 New Revision: 1600978 URL: http://svn.apache.org/r1600978 Log: Clean-up. No functional change. Modified: tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedInputFilter.java Modified:

svn commit: r1600984 - in /tomcat/trunk/java/org/apache/coyote/http11/filters: ChunkedInputFilter.java LocalStrings.properties

2014-06-06 Thread markt
Author: markt Date: Fri Jun 6 19:14:07 2014 New Revision: 1600984 URL: http://svn.apache.org/r1600984 Log: i18n for ChunkedInputFilter error message Add error flag to allow subsequent attempts at reading after an error to fail fast Added:

[Bug 55975] Inconsistent escaping applied to V0 cookie values

2014-06-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55975 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED

svn commit: r1600988 - /tomcat/trunk/test/org/apache/tomcat/util/http/TestSetCookieSupportSeparatorsAllowed.java

2014-06-06 Thread markt
Author: markt Date: Fri Jun 6 19:33:36 2014 New Revision: 1600988 URL: http://svn.apache.org/r1600988 Log: Correct bug reference. These are all V1 cookies. bug 55975 is a V0 cookie issue Modified: tomcat/trunk/test/org/apache/tomcat/util/http/TestSetCookieSupportSeparatorsAllowed.java

buildbot success in ASF Buildbot on tomcat-trunk

2014-06-06 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/156 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source