Re: JASPIC Implementation pointers

2015-06-17 Thread Fjodor Vershinin
Hi, Mark! I'd updated my jaspic-implementation branch, where I have updated version. Thank you for your comments, almost all of this issues has been fixed. The patch triggered a number of basic IDE warnings that should have been already fixed (use of and@Override) Could you provide me your

svn commit: r1685937 - in /tomcat/tc8.0.x/trunk: java/org/apache/catalina/tribes/tipis/LocalStrings.properties java/org/apache/catalina/tribes/tipis/ReplicatedMap.java webapps/docs/changelog.xml

2015-06-17 Thread kfujino
Author: kfujino Date: Wed Jun 17 08:27:05 2015 New Revision: 1685937 URL: http://svn.apache.org/r1685937 Log: When failed to replication, rather than all member is handled as a failed member, exclude the failure members from backup members. Modified:

svn commit: r1685935 - /tomcat/trunk/java/org/apache/catalina/tribes/tipis/ReplicatedMap.java

2015-06-17 Thread kfujino
Author: kfujino Date: Wed Jun 17 08:12:35 2015 New Revision: 1685935 URL: http://svn.apache.org/r1685935 Log: When failed to replication, rather than all member is handled as a failed member, exclude the failure members from backup members. Modified:

svn commit: r1685936 - in /tomcat/trunk/java/org/apache/catalina/tribes/tipis: LocalStrings.properties ReplicatedMap.java

2015-06-17 Thread kfujino
Author: kfujino Date: Wed Jun 17 08:23:06 2015 New Revision: 1685936 URL: http://svn.apache.org/r1685936 Log: Add warning log. Modified: tomcat/trunk/java/org/apache/catalina/tribes/tipis/LocalStrings.properties tomcat/trunk/java/org/apache/catalina/tribes/tipis/ReplicatedMap.java

svn commit: r1685938 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/tribes/tipis/ReplicatedMap.java webapps/docs/changelog.xml

2015-06-17 Thread kfujino
Author: kfujino Date: Wed Jun 17 08:30:46 2015 New Revision: 1685938 URL: http://svn.apache.org/r1685938 Log: When failed to replication, rather than all member is handled as a failed member, exclude the failure members from backup members. Modified:

svn commit: r1685943 - in /tomcat/trunk/java/org/apache/catalina/authenticator: LocalStrings.properties jaspic/JaspicCallbackHandler.java

2015-06-17 Thread markt
Author: markt Date: Wed Jun 17 08:37:52 2015 New Revision: 1685943 URL: http://svn.apache.org/r1685943 Log: Use i18n for error message Patch provided by fjodorver Modified: tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings.properties

svn commit: r1685946 - in /tomcat/trunk/java/org/apache/catalina/authenticator: LocalStrings.properties jaspic/JaspicCallbackHandler.java jaspic/LocalStrings.properties

2015-06-17 Thread markt
Author: markt Date: Wed Jun 17 08:42:56 2015 New Revision: 1685946 URL: http://svn.apache.org/r1685946 Log: Fix issues with previous patch to use an i18n error message Added: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/LocalStrings.properties (with props) Modified:

svn commit: r1685968 - in /tomcat/trunk/test/org/apache/catalina/authenticator/jaspic: ./ sam/

2015-06-17 Thread markt
Author: markt Date: Wed Jun 17 09:17:49 2015 New Revision: 1685968 URL: http://svn.apache.org/r1685968 Log: Review JASPIC unit tests - Line spacing - Renaming to avoid failures when running via the build script Added:

buildbot success in ASF Buildbot on tomcat-8-trunk

2015-06-17 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/298 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1685941 - /tomcat/trunk/java/org/apache/catalina/tribes/tipis/ReplicatedMap.java

2015-06-17 Thread markt
Author: markt Date: Wed Jun 17 08:37:10 2015 New Revision: 1685941 URL: http://svn.apache.org/r1685941 Log: Whitespace police Modified: tomcat/trunk/java/org/apache/catalina/tribes/tipis/ReplicatedMap.java Modified: tomcat/trunk/java/org/apache/catalina/tribes/tipis/ReplicatedMap.java URL:

svn commit: r1685947 - in /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic: JaspicAuthenticator.java JaspicCallbackHandler.java PrincipalGroupCallback.java

2015-06-17 Thread markt
Author: markt Date: Wed Jun 17 08:47:03 2015 New Revision: 1685947 URL: http://svn.apache.org/r1685947 Log: Removed use of ThreadLocal. Added some Javadoc comments. Patch provided by fjodorver. Modified: tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/JaspicAuthenticator.java

svn commit: r1685958 - in /tomcat/trunk/test/org/apache/catalina/authenticator/jaspic: ./ sam/

2015-06-17 Thread markt
Author: markt Date: Wed Jun 17 09:04:26 2015 New Revision: 1685958 URL: http://svn.apache.org/r1685958 Log: Add initial JASPIC unit tests Patch by fjodorver Added: tomcat/trunk/test/org/apache/catalina/authenticator/jaspic/

Re: JASPIC Implementation pointers

2015-06-17 Thread Mark Thomas
On 17/06/2015 08:32, Fjodor Vershinin wrote: Could you provide me your eclipse config files for this project? I think it would be most convenient way to fix such kind issues. This is something that would have been covered during community bonding.

svn commit: r1685992 - /tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java

2015-06-17 Thread markt
Author: markt Date: Wed Jun 17 11:03:16 2015 New Revision: 1685992 URL: http://svn.apache.org/r1685992 Log: Correct logic error in handling of ping frames Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java Modified:

svn commit: r1685954 - in /tomcat/trunk/java/org/apache/catalina/authenticator: LocalStrings.properties jaspic/JaspicAuthenticator.java jaspic/JaspicCallbackHandler.java jaspic/LocalStrings.properties

2015-06-17 Thread markt
Author: markt Date: Wed Jun 17 09:01:11 2015 New Revision: 1685954 URL: http://svn.apache.org/r1685954 Log: Fix issues with previous patch to remove use of ThreadLocal Modified: tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings.properties

svn commit: r1686004 - /tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_5_5.java

2015-06-17 Thread markt
Author: markt Date: Wed Jun 17 12:55:45 2015 New Revision: 1686004 URL: http://svn.apache.org/r1686004 Log: Add unit tests for section 5.5 Added: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_5_5.java (with props) Added:

[Bug 58031] Posting data exceeding maxPostSize should result in HTTP 413.

2015-06-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58031 --- Comment #8 from Mark Thomas ma...@apache.org --- (In reply to Konstantin Kolinko from comment #7) (In reply to Mark Thomas from comment #5) I was thinking a using the existing attribute to trigger a 400 response and a new attribute to

[Bug 57799] MessageCreationException: Couldn't create SOAP message with Nio2 connector protocol

2015-06-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57799 --- Comment #17 from Mark Thomas ma...@apache.org --- (In reply to Remy Maucherat from comment #16) Without a relatively simple test case, I think this should be closed for the time being. There has to be some concurrency involved and the

[Bug 57799] MessageCreationException: Couldn't create SOAP message with Nio2 connector protocol

2015-06-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57799 --- Comment #18 from Justin cry...@yahoo.com --- Without a test case this is going to sit in the NEEDINFO state. Understandable. Regardless of whether there is a test case, there is a bug causing exceptions in Tomcat 8 latest. I may not be

svn commit: r1686024 - /tomcat/trunk/java/org/apache/coyote/http2/Stream.java

2015-06-17 Thread markt
Author: markt Date: Wed Jun 17 14:44:14 2015 New Revision: 1686024 URL: http://svn.apache.org/r1686024 Log: Fix inverted logic in reading HTTP/2 input streams Modified: tomcat/trunk/java/org/apache/coyote/http2/Stream.java Modified: tomcat/trunk/java/org/apache/coyote/http2/Stream.java URL:

svn commit: r1686028 - /tomcat/trunk/test/org/apache/coyote/http2/

2015-06-17 Thread markt
Author: markt Date: Wed Jun 17 14:45:36 2015 New Revision: 1686028 URL: http://svn.apache.org/r1686028 Log: Add a unit test for a simple request with a body Added: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_1.java (with props) Modified:

svn commit: r1686013 - /tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java

2015-06-17 Thread markt
Author: markt Date: Wed Jun 17 13:56:44 2015 New Revision: 1686013 URL: http://svn.apache.org/r1686013 Log: Don't swallow unknown payload in the parser. That is up to the Output to handle. Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java Modified:

buildbot failure in ASF Buildbot on tomcat-trunk

2015-06-17 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1399 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

buildbot success in ASF Buildbot on tomcat-trunk

2015-06-17 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1400 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The