svn commit: r1715521 - in /tomcat/trunk: java/org/apache/catalina/session/JDBCStore.java java/org/apache/catalina/session/StoreBase.java webapps/docs/changelog.xml

2015-11-21 Thread fschumacher
Author: fschumacher Date: Sat Nov 21 13:29:18 2015 New Revision: 1715521 URL: http://svn.apache.org/viewvc?rev=1715521=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=34319 It is not only inefficient memory wise to load all sessions in processExpire, it will put more pressure on the

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2015-11-21 Thread Felix Schumacher
Am 21.11.2015 um 14:43 schrieb build...@apache.org: The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/645 Buildbot URL: http://ci.apache.org/ Buildslave for this

svn commit: r1715539 - /tomcat/trunk/java/javax/security/auth/message/config/AuthConfigFactory.java

2015-11-21 Thread markt
Author: markt Date: Sat Nov 21 15:51:12 2015 New Revision: 1715539 URL: http://svn.apache.org/viewvc?rev=1715539=rev Log: Avoid the memory leak Modified: tomcat/trunk/java/javax/security/auth/message/config/AuthConfigFactory.java Modified:

Re: [VOTE] Release Apache Tomcat 8.0.29

2015-11-21 Thread Felix Schumacher
Am 21.11.2015 um 17:02 schrieb Felix Schumacher: Am 20.11.2015 um 11:00 schrieb Mark Thomas: The proposed Apache Tomcat 8.0.29 release is now available for voting. The main changes since 8.0.28 are: - Add an option to control (per context) quoting of EL expressions in JSP attributes -

buildbot success in ASF Buildbot on tomcat-8-trunk

2015-11-21 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/283 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1715514 - /tomcat/trunk/java/org/apache/catalina/session/PersistentManagerBase.java

2015-11-21 Thread fschumacher
Author: fschumacher Date: Sat Nov 21 13:09:04 2015 New Revision: 1715514 URL: http://svn.apache.org/viewvc?rev=1715514=rev Log: javadoc changes. Markup changes and addition of return annotations. Modified: tomcat/trunk/java/org/apache/catalina/session/PersistentManagerBase.java Modified:

svn commit: r1715515 - /tomcat/trunk/java/org/apache/catalina/session/PersistentManagerBase.java

2015-11-21 Thread fschumacher
Author: fschumacher Date: Sat Nov 21 13:09:53 2015 New Revision: 1715515 URL: http://svn.apache.org/viewvc?rev=1715515=rev Log: Remove parentheses around return values. Modified: tomcat/trunk/java/org/apache/catalina/session/PersistentManagerBase.java Modified:

Re: bugs in tomcat 5

2015-11-21 Thread Felix Schumacher
Am 21.11.2015 um 17:34 schrieb Mark Thomas: On 21/11/2015 16:32, Felix Schumacher wrote: Am 21.11.2015 um 15:30 schrieb Mark Thomas: On 21/11/2015 13:35, Felix Schumacher wrote: Hi all, I wanted to close bug 34319, which is a tomcat 5 bug, but was not allowed to do so. Is it because tomcat

[Bug 34319] StoreBase.processExpires() is very inefficient

2015-11-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=34319 Mark Thomas changed: What|Removed |Added Product|Tomcat 5|Tomcat 9

svn commit: r1715517 - /tomcat/trunk/java/org/apache/catalina/session/StoreBase.java

2015-11-21 Thread fschumacher
Author: fschumacher Date: Sat Nov 21 13:11:23 2015 New Revision: 1715517 URL: http://svn.apache.org/viewvc?rev=1715517=rev Log: Javadoc changes. Markup changes and addition of return annotations. Modified: tomcat/trunk/java/org/apache/catalina/session/StoreBase.java Modified:

svn commit: r1715519 - /tomcat/trunk/java/org/apache/catalina/session/StoreBase.java

2015-11-21 Thread fschumacher
Author: fschumacher Date: Sat Nov 21 13:13:06 2015 New Revision: 1715519 URL: http://svn.apache.org/viewvc?rev=1715519=rev Log: Move comment about protected methods to start of protected methods Modified: tomcat/trunk/java/org/apache/catalina/session/StoreBase.java Modified:

svn commit: r1715518 - /tomcat/trunk/java/org/apache/catalina/session/StoreBase.java

2015-11-21 Thread fschumacher
Author: fschumacher Date: Sat Nov 21 13:12:09 2015 New Revision: 1715518 URL: http://svn.apache.org/viewvc?rev=1715518=rev Log: Remove parentheses around return values Modified: tomcat/trunk/java/org/apache/catalina/session/StoreBase.java Modified:

bugs in tomcat 5

2015-11-21 Thread Felix Schumacher
Hi all, I wanted to close bug 34319, which is a tomcat 5 bug, but was not allowed to do so. Is it because tomcat 5 has reached EOL, or because I don't have permission to do so? Regards, Felix - To unsubscribe, e-mail:

[Bug 34319] StoreBase.processExpires() is very inefficient

2015-11-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=34319 Mark Thomas changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are

Re: bugs in tomcat 5

2015-11-21 Thread Mark Thomas
On 21/11/2015 13:35, Felix Schumacher wrote: > Hi all, > > I wanted to close bug 34319, which is a tomcat 5 bug, but was not > allowed to do so. > > Is it because tomcat 5 has reached EOL, or because I don't have > permission to do so? Hmm. I just CLOSED it but I have admin karma in BZ. Let me

Re: bugs in tomcat 5

2015-11-21 Thread Mark Thomas
On 21/11/2015 16:32, Felix Schumacher wrote: > Am 21.11.2015 um 15:30 schrieb Mark Thomas: >> On 21/11/2015 13:35, Felix Schumacher wrote: >>> Hi all, >>> >>> I wanted to close bug 34319, which is a tomcat 5 bug, but was not >>> allowed to do so. >>> >>> Is it because tomcat 5 has reached EOL, or

svn commit: r1715544 - /tomcat/tc8.0.x/trunk/test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java

2015-11-21 Thread fschumacher
Author: fschumacher Date: Sat Nov 21 16:48:56 2015 New Revision: 1715544 URL: http://svn.apache.org/viewvc?rev=1715544=rev Log: Don't add ":" to cookie name. It is illegal in newer jre. Modified:

svn commit: r1715549 - in /tomcat/tc8.0.x/trunk/test/org/apache/catalina/authenticator: TestSSOnonLoginAndBasicAuthenticator.java TestSSOnonLoginAndDigestAuthenticator.java

2015-11-21 Thread fschumacher
Author: fschumacher Date: Sat Nov 21 18:05:42 2015 New Revision: 1715549 URL: http://svn.apache.org/viewvc?rev=1715549=rev Log: Don't add ":" to cookie name. It is illegal in newer jre. Modified:

svn commit: r1715510 - /tomcat/trunk/java/org/apache/catalina/session/JDBCStore.java

2015-11-21 Thread fschumacher
Author: fschumacher Date: Sat Nov 21 13:01:29 2015 New Revision: 1715510 URL: http://svn.apache.org/viewvc?rev=1715510=rev Log: Javadoc changes. Markup changes and addition of return annotations Modified: tomcat/trunk/java/org/apache/catalina/session/JDBCStore.java Modified:

Re: [VOTE] Release Apache Tomcat 8.0.29

2015-11-21 Thread Felix Schumacher
Am 20.11.2015 um 11:00 schrieb Mark Thomas: The proposed Apache Tomcat 8.0.29 release is now available for voting. The main changes since 8.0.28 are: - Add an option to control (per context) quoting of EL expressions in JSP attributes - Correct a regression in the fix for 56777 that added

Re: [VOTE] Release Apache Tomcat 8.0.29

2015-11-21 Thread Mark Thomas
On 21/11/2015 16:28, Felix Schumacher wrote: > Am 21.11.2015 um 17:06 schrieb Felix Schumacher: >> Am 21.11.2015 um 17:02 schrieb Felix Schumacher: >>> Am 20.11.2015 um 11:00 schrieb Mark Thomas: The proposed Apache Tomcat 8.0.29 release is now available for voting. The main changes

Re: bugs in tomcat 5

2015-11-21 Thread Felix Schumacher
Am 21.11.2015 um 15:30 schrieb Mark Thomas: On 21/11/2015 13:35, Felix Schumacher wrote: Hi all, I wanted to close bug 34319, which is a tomcat 5 bug, but was not allowed to do so. Is it because tomcat 5 has reached EOL, or because I don't have permission to do so? Hmm. I just CLOSED it but

[Bug 47281] Efficiency of the JDBCStore

2015-11-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=47281 Felix Schumacher changed: What|Removed |Added Status|NEW

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2015-11-21 Thread Mark Thomas
On 21/11/2015 13:57, Felix Schumacher wrote: > Am 21.11.2015 um 14:43 schrieb build...@apache.org: >> The Buildbot has detected a new failure on builder tomcat-trunk while >> building ASF Buildbot. Full details are available at: >> http://ci.apache.org/builders/tomcat-trunk/builds/645 >> >>

Re: [VOTE] Release Apache Tomcat 8.0.29

2015-11-21 Thread Felix Schumacher
Am 21.11.2015 um 17:06 schrieb Felix Schumacher: Am 21.11.2015 um 17:02 schrieb Felix Schumacher: Am 20.11.2015 um 11:00 schrieb Mark Thomas: The proposed Apache Tomcat 8.0.29 release is now available for voting. The main changes since 8.0.28 are: - Add an option to control (per context)

svn commit: r1715547 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java

2015-11-21 Thread fschumacher
Author: fschumacher Date: Sat Nov 21 17:54:14 2015 New Revision: 1715547 URL: http://svn.apache.org/viewvc?rev=1715547=rev Log: Don't add ":" to cookie name. It is illegal in newer jre. Merge from r1715544 /tomcat/tc8.0.x/trunk Modified: tomcat/tc7.0.x/trunk/ (props changed)

Re: bugs in tomcat 5

2015-11-21 Thread Mark Thomas
On 21/11/2015 16:37, Felix Schumacher wrote: > Am 21.11.2015 um 17:34 schrieb Mark Thomas: >> On 21/11/2015 16:32, Felix Schumacher wrote: >>> Am 21.11.2015 um 15:30 schrieb Mark Thomas: On 21/11/2015 13:35, Felix Schumacher wrote: > Hi all, > > I wanted to close bug 34319, which

Re: bugs in tomcat 5

2015-11-21 Thread Felix Schumacher
Am 21. November 2015 19:47:48 MEZ, schrieb Mark Thomas : >On 21/11/2015 16:37, Felix Schumacher wrote: >> Am 21.11.2015 um 17:34 schrieb Mark Thomas: >>> On 21/11/2015 16:32, Felix Schumacher wrote: Am 21.11.2015 um 15:30 schrieb Mark Thomas: > On 21/11/2015 13:35,

svn commit: r1715511 - /tomcat/trunk/java/org/apache/catalina/session/JDBCStore.java

2015-11-21 Thread fschumacher
Author: fschumacher Date: Sat Nov 21 13:04:04 2015 New Revision: 1715511 URL: http://svn.apache.org/viewvc?rev=1715511=rev Log: return is not a function call, so don't use parantheses around return values. Correct spelling of pool. Modified:

svn commit: r1715512 - /tomcat/trunk/java/org/apache/catalina/session/JDBCStore.java

2015-11-21 Thread fschumacher
Author: fschumacher Date: Sat Nov 21 13:05:34 2015 New Revision: 1715512 URL: http://svn.apache.org/viewvc?rev=1715512=rev Log: Ooops, really correct the spelling of pool now. Modified: tomcat/trunk/java/org/apache/catalina/session/JDBCStore.java Modified:

PersistenManager and StoreBase

2015-11-21 Thread Felix Schumacher
Hi all, while looking at the PersistentManager and StoreBase, I found a few more inefficiencies other than bz 34319/47061. If a Node is started, it will load all sessions from the Store, even if those sessions are old enough, to be swapped out to the Store on the next maintenance run. I

buildbot failure in ASF Buildbot on tomcat-8-trunk

2015-11-21 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/282 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

buildbot failure in ASF Buildbot on tomcat-trunk

2015-11-21 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/645 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

Re: PersistenManager and StoreBase

2015-11-21 Thread Mark Thomas
On 21/11/2015 14:08, Felix Schumacher wrote: > Hi all, > > while looking at the PersistentManager and StoreBase, I found a few more > inefficiencies other than bz 34319/47061. > > If a Node is started, it will load all sessions from the Store, even if > those sessions are old enough, to be

buildbot success in ASF Buildbot on tomcat-trunk

2015-11-21 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/646 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1715550 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/authenticator/TestSSOnonLoginAndBasicAuthenticator.java test/org/apache/catalina/authenticator/TestSSOnonLoginAndDigestAuth

2015-11-21 Thread fschumacher
Author: fschumacher Date: Sat Nov 21 18:16:48 2015 New Revision: 1715550 URL: http://svn.apache.org/viewvc?rev=1715550=rev Log: Don't add ":" to cookie name. It is illegal in newer jre. Merge r1715549 from /tomcat/tc8.0.x/trunk Modified: tomcat/tc7.0.x/trunk/ (props changed)

[Bug 34319] StoreBase.processExpires() is very inefficient

2015-11-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=34319 Felix Schumacher changed: What|Removed |Added CC|

Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-21 Thread Konstantin Kolinko
2015-11-20 15:47 GMT+03:00 Christopher Schultz : > All, > > I thought there was a BZ issue for this, but I didn't find one. It's > been suggested (and I agree completely) that an application ought to be > able to fetch the CredentialHandler for the context's realm so

[Bug 58624] Websocket send blocks indefinitely in FutureToSendHandler

2015-11-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58624 --- Comment #7 from Barry Coughlan --- (In reply to Mark Thomas from comment #6) > Thanks for all the work on this. > > It is worth updating to the latest 8.0.x in case one of the I/O or > concurrency updates has

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

2015-11-21 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-apr has an issue affecting its community

Bug report for Taglibs [2015/11/22]

2015-11-21 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 6 [2015/11/22]

2015-11-21 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Modules [2015/11/22]

2015-11-21 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Connectors [2015/11/22]

2015-11-21 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Native [2015/11/22]

2015-11-21 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 7 [2015/11/22]

2015-11-21 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 8 [2015/11/22]

2015-11-21 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 9 [2015/11/22]

2015-11-21 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio (in module tomcat-8.0.x) failed

2015-11-21 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-nio has an issue affecting its community

[Bug 56126] 8.0.1 Regression with Spring with AspectJ Load-Time Weaving

2015-11-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=56126 --- Comment #6 from Riyas --- Hi, As part of migration form tomcat7 to 8 When I removed the spring instrument load time weaver from context.xml file of my spring web application >> All beans loaded under the dispatcher