buildbot failure in ASF Buildbot on tomcat-8-trunk

2016-01-01 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/377 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1722570 - in /tomcat/site/trunk/docs: ./ stylesheets/

2016-01-01 Thread rjung
Author: rjung Date: Fri Jan 1 20:37:17 2016 New Revision: 1722570 URL: http://svn.apache.org/viewvc?rev=1722570=rev Log: Regenerate the site after year update. Modified: tomcat/site/trunk/docs/bugreport.html tomcat/site/trunk/docs/ci.html tomcat/site/trunk/docs/contact.html

svn commit: r1722586 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/StandardWrapper.java

2016-01-01 Thread violetagg
Author: violetagg Date: Fri Jan 1 21:26:07 2016 New Revision: 1722586 URL: http://svn.apache.org/viewvc?rev=1722586=rev Log: Merged revision 1722583 from tomcat/trunk: the array that is returned cannot be null but with length 0 Modified: tomcat/tc8.0.x/trunk/ (props changed)

[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2016-01-01 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio has an issue affecting its community integration.

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

2016-01-01 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-apr has an issue affecting its community

buildbot failure in ASF Buildbot on tomcat-7-trunk

2016-01-01 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/271 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1722583 - /tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java

2016-01-01 Thread violetagg
Author: violetagg Date: Fri Jan 1 21:19:24 2016 New Revision: 1722583 URL: http://svn.apache.org/viewvc?rev=1722583=rev Log: the array that is returned cannot be null but with length 0 Modified: tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java Modified:

svn commit: r1722569 - in /tomcat/site/trunk/xdocs: legal.xml stylesheets/tomcat-site.xsl stylesheets/tomcat.css

2016-01-01 Thread rjung
Author: rjung Date: Fri Jan 1 20:36:06 2016 New Revision: 1722569 URL: http://svn.apache.org/viewvc?rev=1722569=rev Log: Happy New Year 2016 Modified: tomcat/site/trunk/xdocs/legal.xml tomcat/site/trunk/xdocs/stylesheets/tomcat-site.xsl tomcat/site/trunk/xdocs/stylesheets/tomcat.css

svn commit: r1722574 - in /tomcat/trunk/java/org/apache/catalina: connector/Response.java servlets/CGIServlet.java

2016-01-01 Thread violetagg
Author: violetagg Date: Fri Jan 1 21:05:20 2016 New Revision: 1722574 URL: http://svn.apache.org/viewvc?rev=1722574=rev Log: The variable cannot be null but empty string Modified: tomcat/trunk/java/org/apache/catalina/connector/Response.java

svn commit: r1722577 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/connector/Response.java java/org/apache/catalina/servlets/CGIServlet.java

2016-01-01 Thread violetagg
Author: violetagg Date: Fri Jan 1 21:07:59 2016 New Revision: 1722577 URL: http://svn.apache.org/viewvc?rev=1722577=rev Log: Merged revision 1722574 from tomcat/trunk: The variable cannot be null but empty string Modified: tomcat/tc8.0.x/trunk/ (props changed)

buildbot success in ASF Buildbot on tomcat-7-trunk

2016-01-01 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/272 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1722581 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/Response.java java/org/apache/catalina/servlets/CGIServlet.java

2016-01-01 Thread violetagg
Author: violetagg Date: Fri Jan 1 21:11:52 2016 New Revision: 1722581 URL: http://svn.apache.org/viewvc?rev=1722581=rev Log: Merged revision 1722574 from tomcat/trunk: The variable cannot be null but empty string Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1722567 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/TagPluginManager.java java/org/apache/tomcat/util/modeler/BaseModelMBean.java

2016-01-01 Thread violetagg
Author: violetagg Date: Fri Jan 1 20:14:31 2016 New Revision: 1722567 URL: http://svn.apache.org/viewvc?rev=1722567=rev Log: Merged revision 1722548 from tomcat/trunk: Variable cannot be null Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1722590 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/coyote/http11/AbstractHttp11Processor.java

2016-01-01 Thread violetagg
Author: violetagg Date: Fri Jan 1 21:34:08 2016 New Revision: 1722590 URL: http://svn.apache.org/viewvc?rev=1722590=rev Log: Merged revision 1722585 from tomcat/trunk: the check for null has been done already Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1722595 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/AbstractHttp11Processor.java

2016-01-01 Thread violetagg
Author: violetagg Date: Fri Jan 1 21:43:55 2016 New Revision: 1722595 URL: http://svn.apache.org/viewvc?rev=1722595=rev Log: Merged revision 1722585 from tomcat/trunk: the check for null has been done already Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1722585 - /tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java

2016-01-01 Thread violetagg
Author: violetagg Date: Fri Jan 1 21:23:08 2016 New Revision: 1722585 URL: http://svn.apache.org/viewvc?rev=1722585=rev Log: the check for null has been done already Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java Modified:

svn commit: r1722592 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/StandardWrapper.java

2016-01-01 Thread violetagg
Author: violetagg Date: Fri Jan 1 21:36:36 2016 New Revision: 1722592 URL: http://svn.apache.org/viewvc?rev=1722592=rev Log: Merged revision 1722583 from tomcat/trunk: the array that is returned cannot be null but with length 0 Modified: tomcat/tc7.0.x/trunk/ (props changed)

buildbot success in ASF Buildbot on tomcat-8-trunk

2016-01-01 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/379 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[Bug 58751] Strange behaviour after calling sendError when an async request times out

2016-01-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58751 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

2016-01-01 Thread Bill Barker
/daemon/dist/bin/commons-daemon-20160101-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar -Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native/dest-20160101/lib -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons

svn commit: r1722530 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServerContainer.java

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 18:36:07 2016 New Revision: 1722530 URL: http://svn.apache.org/viewvc?rev=1722530=rev Log: Remove unused method Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServerContainer.java Modified:

svn commit: r1722529 - /tomcat/trunk/java/org/apache/tomcat/websocket/SendHandlerToCompletionHandler.java

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 18:34:35 2016 New Revision: 1722529 URL: http://svn.apache.org/viewvc?rev=1722529=rev Log: Remove class no longer required after refactoring Removed: tomcat/trunk/java/org/apache/tomcat/websocket/SendHandlerToCompletionHandler.java

svn commit: r1722531 - /tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 18:45:29 2016 New Revision: 1722531 URL: http://svn.apache.org/viewvc?rev=1722531=rev Log: Remove unused code Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java URL:

svn commit: r1722532 - in /tomcat/trunk: ./ java/org/apache/catalina/manager/ java/org/apache/catalina/manager/host/ modules/jdbc-pool/ webapps/manager/WEB-INF/jsp/

2016-01-01 Thread violetagg
Author: violetagg Date: Fri Jan 1 18:51:44 2016 New Revision: 1722532 URL: http://svn.apache.org/viewvc?rev=1722532=rev Log: Happy New Year 2016 Modified: tomcat/trunk/NOTICE tomcat/trunk/java/org/apache/catalina/manager/Constants.java

svn commit: r1722536 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/manager/ java/org/apache/catalina/manager/host/ modules/jdbc-pool/ webapps/manager/WEB-INF/jsp/

2016-01-01 Thread violetagg
Author: violetagg Date: Fri Jan 1 19:01:58 2016 New Revision: 1722536 URL: http://svn.apache.org/viewvc?rev=1722536=rev Log: Happy New Year 2016 Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/NOTICE

svn commit: r1722537 - /tomcat/tc8.0.x/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java

2016-01-01 Thread violetagg
Author: violetagg Date: Fri Jan 1 19:03:46 2016 New Revision: 1722537 URL: http://svn.apache.org/viewvc?rev=1722537=rev Log: list with sessions cannot be null Modified: tomcat/tc8.0.x/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java Modified:

svn commit: r1722539 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/manager/ java/org/apache/catalina/manager/host/ modules/jdbc-pool/ webapps/manager/WEB-INF/jsp/

2016-01-01 Thread violetagg
Author: violetagg Date: Fri Jan 1 19:11:36 2016 New Revision: 1722539 URL: http://svn.apache.org/viewvc?rev=1722539=rev Log: Happy New Year 2016 Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/NOTICE

svn commit: r1722540 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java

2016-01-01 Thread violetagg
Author: violetagg Date: Fri Jan 1 19:15:13 2016 New Revision: 1722540 URL: http://svn.apache.org/viewvc?rev=1722540=rev Log: list with sessions cannot be null Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java Modified:

svn commit: r1722541 - in /tomcat/jk/trunk: jkstatus/build.xml native/NOTICE native/common/jk_status.c native/iis/jk_isapi_plugin.c xdocs/style.xsl

2016-01-01 Thread rjung
Author: rjung Date: Fri Jan 1 19:16:06 2016 New Revision: 1722541 URL: http://svn.apache.org/viewvc?rev=1722541=rev Log: Happy New Year 2016 Modified: tomcat/jk/trunk/jkstatus/build.xml tomcat/jk/trunk/native/NOTICE tomcat/jk/trunk/native/common/jk_status.c

svn commit: r1722542 - in /tomcat/native/trunk: NOTICE build.xml xdocs/style.xsl

2016-01-01 Thread rjung
Author: rjung Date: Fri Jan 1 19:19:13 2016 New Revision: 1722542 URL: http://svn.apache.org/viewvc?rev=1722542=rev Log: Happy New Year 2016 Modified: tomcat/native/trunk/NOTICE tomcat/native/trunk/build.xml tomcat/native/trunk/xdocs/style.xsl Modified: tomcat/native/trunk/NOTICE

svn commit: r1722544 - in /tomcat/native/branches/1.1.x: ./ NOTICE build.xml xdocs/style.xsl

2016-01-01 Thread rjung
Author: rjung Date: Fri Jan 1 19:21:45 2016 New Revision: 1722544 URL: http://svn.apache.org/viewvc?rev=1722544=rev Log: Happy New Year 2016 Backport of r1722542 from trunk. Modified: tomcat/native/branches/1.1.x/ (props changed) tomcat/native/branches/1.1.x/NOTICE

svn commit: r1722545 - in /tomcat/taglibs: rdc/trunk/NOTICE.txt rdc/trunk/taglibs-rdc-dist/NOTICE.txt rdc/trunk/taglibs-rdc-examples/NOTICE.txt rdc/trunk/taglibs-rdc/NOTICE.txt site/NOTICE.txt standar

2016-01-01 Thread rjung
Author: rjung Date: Fri Jan 1 19:24:32 2016 New Revision: 1722545 URL: http://svn.apache.org/viewvc?rev=1722545=rev Log: Happy New Year 2016 Modified: tomcat/taglibs/rdc/trunk/NOTICE.txt tomcat/taglibs/rdc/trunk/taglibs-rdc-dist/NOTICE.txt

svn commit: r1722546 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/manager/ java/org/apache/catalina/manager/host/ webapps/docs/tribes/ webapps/manager/WEB-INF/jsp/

2016-01-01 Thread violetagg
Author: violetagg Date: Fri Jan 1 19:25:06 2016 New Revision: 1722546 URL: http://svn.apache.org/viewvc?rev=1722546=rev Log: Happy New Year 2016 Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/NOTICE

svn commit: r1722548 - in /tomcat/trunk/java/org/apache: catalina/storeconfig/StandardEngineSF.java jasper/compiler/TagPluginManager.java tomcat/util/modeler/BaseModelMBean.java

2016-01-01 Thread violetagg
Author: violetagg Date: Fri Jan 1 19:33:39 2016 New Revision: 1722548 URL: http://svn.apache.org/viewvc?rev=1722548=rev Log: Variable cannot be null Modified: tomcat/trunk/java/org/apache/catalina/storeconfig/StandardEngineSF.java

svn commit: r1722554 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/storeconfig/StandardEngineSF.java java/org/apache/jasper/compiler/TagPluginManager.java java/org/apache/tomcat/util/modeler

2016-01-01 Thread violetagg
Author: violetagg Date: Fri Jan 1 19:41:23 2016 New Revision: 1722554 URL: http://svn.apache.org/viewvc?rev=1722554=rev Log: Merged revision 1722548 from tomcat/trunk: Variable cannot be null Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1722506 - /tomcat/tc9.0.x/branches/

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 17:15:19 2016 New Revision: 1722506 URL: http://svn.apache.org/viewvc?rev=1722506=rev Log: Structure for 9.0.x branches Added: tomcat/tc9.0.x/branches/ - To unsubscribe, e-mail:

svn commit: r1722505 - /tomcat/tc9.0.x/

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 17:15:13 2016 New Revision: 1722505 URL: http://svn.apache.org/viewvc?rev=1722505=rev Log: Structure for 9.0.x branches Added: tomcat/tc9.0.x/ - To unsubscribe, e-mail:

svn commit: r1722507 - /tomcat/tc9.0.x/braches/

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 17:16:12 2016 New Revision: 1722507 URL: http://svn.apache.org/viewvc?rev=1722507=rev Log: Create branch to record current state of GSoC JASPIC work before removal Added: tomcat/tc9.0.x/braches/ - copied from r1722506, tomcat/trunk/

svn commit: r1722509 - /tomcat/tc9.0.x/branches/gsoc-jaspic/

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 17:17:37 2016 New Revision: 1722509 URL: http://svn.apache.org/viewvc?rev=1722509=rev Log: Create branch to record current state of GSoC JASPIC work before removal Added: tomcat/tc9.0.x/branches/gsoc-jaspic/ - copied from r1722508, tomcat/trunk/

svn commit: r1722508 - /tomcat/tc9.0.x/braches/

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 17:17:22 2016 New Revision: 1722508 URL: http://svn.apache.org/viewvc?rev=1722508=rev Log: typo Removed: tomcat/tc9.0.x/braches/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

svn commit: r1722510 - in /tomcat/trunk: java/org/apache/catalina/authenticator/jaspic/ java/org/apache/catalina/startup/ test/org/apache/catalina/authenticator/ test/org/apache/catalina/authenticator

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 17:27:07 2016 New Revision: 1722510 URL: http://svn.apache.org/viewvc?rev=1722510=rev Log: Remove JASPIC authenticator and associated modules implemented during GSoC. See http://tomcat.markmail.org/thread/ar2pdpb6vibu2dwd for reasoning. Removed:

svn commit: r1722511 - in /tomcat/trunk/java/org/apache: catalina/core/NamingContextListener.java naming/NamingContext.java

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 17:40:34 2016 New Revision: 1722511 URL: http://svn.apache.org/viewvc?rev=1722511=rev Log: Clean-up. - Remove unused throws declarations - Remove catches that are now unnecessary - Fix Javadoc warnings Modified:

svn commit: r1722512 - in /tomcat/trunk/java/org/apache/naming: ResourceLinkRef.java ResourceRef.java

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 17:45:38 2016 New Revision: 1722512 URL: http://svn.apache.org/viewvc?rev=1722512=rev Log: Javadoc fixes Modified: tomcat/trunk/java/org/apache/naming/ResourceLinkRef.java tomcat/trunk/java/org/apache/naming/ResourceRef.java Modified:

svn commit: r1722515 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 18:01:19 2016 New Revision: 1722515 URL: http://svn.apache.org/viewvc?rev=1722515=rev Log: Fix WebSocket Javadoc warnings Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java Modified:

svn commit: r1722524 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/filters/HttpHeaderSecurityFilter.java webapps/docs/changelog.xml webapps/docs/config/filter.xml

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 18:14:32 2016 New Revision: 1722524 URL: http://svn.apache.org/viewvc?rev=1722524=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58735 Add support for the X-XSS-Protection header to the HttpHeaderSecurityFilter. Patch provided by Jacopo Cappellato.

[Bug 58735] Add support for X-XSS-Protection header

2016-01-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58735 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1722528 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/filters/HttpHeaderSecurityFilter.java

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 18:23:38 2016 New Revision: 1722528 URL: http://svn.apache.org/viewvc?rev=1722528=rev Log: Refactor the processing / simplify the code - Only check that the response is an HTTP response once and cast once - Check if the response is committed after we know it is an

svn commit: r1722527 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/filters/HttpHeaderSecurityFilter.java

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 18:23:03 2016 New Revision: 1722527 URL: http://svn.apache.org/viewvc?rev=1722527=rev Log: Refactor the processing / simplify the code - Only check that the response is an HTTP response once and cast once - Check if the response is committed after we know it is an

svn commit: r1722526 - /tomcat/trunk/java/org/apache/catalina/filters/HttpHeaderSecurityFilter.java

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 18:22:24 2016 New Revision: 1722526 URL: http://svn.apache.org/viewvc?rev=1722526=rev Log: Refactor the processing / simplify the code - Only check that the response is an HTTP response once and cast once - Check if the response is committed after we know it is an

svn commit: r1722513 - /tomcat/trunk/java/org/apache/naming/StringManager.java

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 17:49:48 2016 New Revision: 1722513 URL: http://svn.apache.org/viewvc?rev=1722513=rev Log: Fix Javadoc (copied from main StringManager impl) Modified: tomcat/trunk/java/org/apache/naming/StringManager.java Modified:

svn commit: r1722522 - in /tomcat/trunk: java/org/apache/catalina/filters/HttpHeaderSecurityFilter.java webapps/docs/changelog.xml webapps/docs/config/filter.xml

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 18:10:02 2016 New Revision: 1722522 URL: http://svn.apache.org/viewvc?rev=1722522=rev Log: Add support for the X-XSS-Protection header to the HttpHeaderSecurityFilter. Patch provided by Jacopo Cappellato. Modified:

svn commit: r1722523 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/filters/HttpHeaderSecurityFilter.java webapps/docs/changelog.xml webapps/docs/config/filter.xml

2016-01-01 Thread markt
Author: markt Date: Fri Jan 1 18:13:14 2016 New Revision: 1722523 URL: http://svn.apache.org/viewvc?rev=1722523=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58735 Add support for the X-XSS-Protection header to the HttpHeaderSecurityFilter. Patch provided by Jacopo Cappellato.