svn commit: r1793580 - /tomcat/trunk/java/org/apache/coyote/Request.java

Author: markt Date: Tue May 2 19:24:23 2017 New Revision: 1793580 URL: http://svn.apache.org/viewvc?rev=1793580=rev Log: Whoops. Make sure trailer field Map is recycled between requests. Modified: tomcat/trunk/java/org/apache/coyote/Request.java Modified:

svn commit: r1793578 - /tomcat/trunk/java/javax/servlet/http/HttpServletRequestWrapper.java

Author: markt Date: Tue May 2 19:21:15 2017 New Revision: 1793578 URL: http://svn.apache.org/viewvc?rev=1793578=rev Log: Fix copy/paste error Modified: tomcat/trunk/java/javax/servlet/http/HttpServletRequestWrapper.java Modified:

svn commit: r1793577 - /tomcat/trunk/java/javax/servlet/http/HttpServletRequest.java

Author: markt Date: Tue May 2 19:18:10 2017 New Revision: 1793577 URL: http://svn.apache.org/viewvc?rev=1793577=rev Log: Add missing @since tag Modified: tomcat/trunk/java/javax/servlet/http/HttpServletRequest.java Modified: tomcat/trunk/java/javax/servlet/http/HttpServletRequest.java URL:

buildbot success in on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2359 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1793574 - /tomcat/trunk/java/javax/servlet/http/HttpServletRequest.java

Author: markt Date: Tue May 2 18:54:58 2017 New Revision: 1793574 URL: http://svn.apache.org/viewvc?rev=1793574=rev Log: Spec includes a default impl (don't know why) Modified: tomcat/trunk/java/javax/servlet/http/HttpServletRequest.java Modified:

svn commit: r1793573 - in /tomcat/trunk: java/javax/servlet/http/ java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/http11/filters/ java/org/apache/coyote/http2/ test/

Author: markt Date: Tue May 2 18:48:20 2017 New Revision: 1793573 URL: http://svn.apache.org/viewvc?rev=1793573=rev Log: Update the Servlet 4.0 implementation to add support for obtaining trailer fields from chunked HTTP requests. Modified:

Release plans

Hi all, A new month has started so I'm intending to do a 9.0.x and 8.5.x release fairly soon. There are a couple of issues that I think need to be resolved first: - https://bz.apache.org/bugzilla/show_bug.cgi?id=61057 (ECJ) - https://bz.apache.org/bugzilla/show_bug.cgi?id=61003 (WebSocket) -

[GitHub] tomcat issue #54: Respect minimum pool size [#61032]

Github user jelmerterwal commented on the issue: https://github.com/apache/tomcat/pull/54 @markt-asf could you have a look at this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

buildbot failure in on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2357 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[Bug 60362] Missing reason phrase in response

https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 --- Comment #57 from Silas Smith --- (In reply to mgrigorov from comment #56) > > Why you can use old clients and not use old servers ?! > 6.x has been just discontinued, so I expect that 8.5.x will be maintained > for

svn commit: r1793522 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

Author: markt Date: Tue May 2 15:02:20 2017 New Revision: 1793522 URL: http://svn.apache.org/viewvc?rev=1793522=rev Log: When the WebDAV servlet is configured and an error dispatch is made to a custom error page located below WEB-INF, ensure that the target error page is displayed rather than

svn commit: r1793520 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

Author: markt Date: Tue May 2 15:01:34 2017 New Revision: 1793520 URL: http://svn.apache.org/viewvc?rev=1793520=rev Log: When the WebDAV servlet is configured and an error dispatch is made to a custom error page located below WEB-INF, ensure that the target error page is displayed rather than

svn commit: r1793518 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

Author: markt Date: Tue May 2 14:52:00 2017 New Revision: 1793518 URL: http://svn.apache.org/viewvc?rev=1793518=rev Log: When the WebDAV servlet is configured and an error dispatch is made to a custom error page located below WEB-INF, ensure that the target error page is displayed rather than

svn commit: r1793514 - in /tomcat/trunk: java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

Author: markt Date: Tue May 2 14:47:59 2017 New Revision: 1793514 URL: http://svn.apache.org/viewvc?rev=1793514=rev Log: When the WebDAV servlet is configured and an error dispatch is made to a custom error page located below WEB-INF, ensure that the target error page is displayed rather than

svn commit: r1793505 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/servlets/DefaultServlet.java

Author: markt Date: Tue May 2 14:36:24 2017 New Revision: 1793505 URL: http://svn.apache.org/viewvc?rev=1793505=rev Log: Refactor Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java Propchange:

svn commit: r1793504 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/servlets/DefaultServlet.java

Author: markt Date: Tue May 2 14:34:43 2017 New Revision: 1793504 URL: http://svn.apache.org/viewvc?rev=1793504=rev Log: Refactor Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java Propchange:

svn commit: r1793503 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/servlets/DefaultServlet.java

Author: markt Date: Tue May 2 14:34:17 2017 New Revision: 1793503 URL: http://svn.apache.org/viewvc?rev=1793503=rev Log: Refactor Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java Propchange:

svn commit: r1793502 - /tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java

Author: markt Date: Tue May 2 14:33:46 2017 New Revision: 1793502 URL: http://svn.apache.org/viewvc?rev=1793502=rev Log: Refactor Modified: tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java Modified: tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java URL:

svn commit: r1793501 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/servlets/DefaultServlet.java webapps/docs/changelog.xml

Author: markt Date: Tue May 2 14:32:09 2017 New Revision: 1793501 URL: http://svn.apache.org/viewvc?rev=1793501=rev Log: If a static custom error page is specified that does not exist or cannot be read, ensure that the intended error status is returned rather than a 404. Modified:

svn commit: r1793500 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/servlets/DefaultServlet.java webapps/docs/changelog.xml

Author: markt Date: Tue May 2 14:27:38 2017 New Revision: 1793500 URL: http://svn.apache.org/viewvc?rev=1793500=rev Log: If a static custom error page is specified that does not exist or cannot be read, ensure that the intended error status is returned rather than a 404 or 403. Modified:

svn commit: r1793499 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/servlets/DefaultServlet.java webapps/docs/changelog.xml

Author: markt Date: Tue May 2 14:26:54 2017 New Revision: 1793499 URL: http://svn.apache.org/viewvc?rev=1793499=rev Log: If a static custom error page is specified that does not exist or cannot be read, ensure that the intended error status is returned rather than a 404 or 403. Modified:

svn commit: r1793498 - in /tomcat/trunk: java/org/apache/catalina/servlets/DefaultServlet.java webapps/docs/changelog.xml

Author: markt Date: Tue May 2 14:26:03 2017 New Revision: 1793498 URL: http://svn.apache.org/viewvc?rev=1793498=rev Log: If a static custom error page is specified that does not exist or cannot be read, ensure that the intended error status is returned rather than a 404 or 403. Modified:

svn commit: r1793491 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/servlets/DefaultServlet.java java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

Author: markt Date: Tue May 2 13:30:06 2017 New Revision: 1793491 URL: http://svn.apache.org/viewvc?rev=1793491=rev Log: Ensure that when the Default or WebDAV servlets process an error dispatch that the error resource is processed via the doGet() method irrespective of the method used for the

svn commit: r1793489 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/servlets/DefaultServlet.java java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

Author: markt Date: Tue May 2 13:16:08 2017 New Revision: 1793489 URL: http://svn.apache.org/viewvc?rev=1793489=rev Log: Ensure that when the Default or WebDAV servlets process an error dispatch that the error resource is processed via the doGet() method irrespective of the method used for the

svn commit: r1793488 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/servlets/DefaultServlet.java java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

Author: markt Date: Tue May 2 13:14:48 2017 New Revision: 1793488 URL: http://svn.apache.org/viewvc?rev=1793488=rev Log: Ensure that when the Default or WebDAV servlets process an error dispatch that the error resource is processed via the doGet() method irrespective of the method used for the

svn commit: r1793487 - in /tomcat/trunk: java/org/apache/catalina/servlets/DefaultServlet.java java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

Author: markt Date: Tue May 2 13:14:00 2017 New Revision: 1793487 URL: http://svn.apache.org/viewvc?rev=1793487=rev Log: Ensure that when the Default or WebDAV servlets process an error dispatch that the error resource is processed via the doGet() method irrespective of the method used for the

[Bug 61057] Tomcat JDT 4.6.1 Issues.

https://bz.apache.org/bugzilla/show_bug.cgi?id=61057 --- Comment #3 from Konstantin Kolinko --- Tomcat 8.5.14 / lib / ecj-4.6.1.jar / META-INF/MANIFEST.MF says: Bundle-Version: 3.12.1.v20160829-0950 As such, the internal version of component used in Eclipse 4.6.3 is

svn commit: r1793471 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/servlets/DefaultServlet.java webapps/docs/changelog.xml

Author: markt Date: Tue May 2 11:26:16 2017 New Revision: 1793471 URL: http://svn.apache.org/viewvc?rev=1793471=rev Log: Use a more reliable mechanism for the DefaultServlet when determining if the current request is for custom error page or not. Modified: tomcat/tc7.0.x/trunk/ (props

svn commit: r1793470 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/servlets/DefaultServlet.java webapps/docs/changelog.xml

Author: markt Date: Tue May 2 11:22:59 2017 New Revision: 1793470 URL: http://svn.apache.org/viewvc?rev=1793470=rev Log: Use a more reliable mechanism for the DefaultServlet when determining if the current request is for custom error page or not. Modified: tomcat/tc8.0.x/trunk/ (props

svn commit: r1793469 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/servlets/DefaultServlet.java webapps/docs/changelog.xml

Author: markt Date: Tue May 2 11:21:14 2017 New Revision: 1793469 URL: http://svn.apache.org/viewvc?rev=1793469=rev Log: Use a more reliable mechanism for the DefaultServlet when determining if the current request is for custom error page or not. Modified: tomcat/tc8.5.x/trunk/ (props

svn commit: r1793468 - in /tomcat/trunk: java/org/apache/catalina/servlets/DefaultServlet.java webapps/docs/changelog.xml

Author: markt Date: Tue May 2 11:20:32 2017 New Revision: 1793468 URL: http://svn.apache.org/viewvc?rev=1793468=rev Log: Use a more reliable mechanism for the DefaultServlet when determining if the current request is for custom error page or not. Modified:

svn commit: r1793461 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/SSLHostConfig.java java/org/apache/tomcat/util/net/jsse/JSSEUtil.java webapps/docs/changelog.xml

Author: markt Date: Tue May 2 10:37:57 2017 New Revision: 1793461 URL: http://svn.apache.org/viewvc?rev=1793461=rev Log: When a TrustManager is configured that does not support certificateVerificationDepth only log a warning about that lack of support when certificateVerificationDepth has been

svn commit: r1793460 - in /tomcat/trunk: java/org/apache/tomcat/util/net/SSLHostConfig.java java/org/apache/tomcat/util/net/jsse/JSSEUtil.java webapps/docs/changelog.xml

Author: markt Date: Tue May 2 10:34:37 2017 New Revision: 1793460 URL: http://svn.apache.org/viewvc?rev=1793460=rev Log: When a TrustManager is configured that does not support certificateVerificationDepth only log a warning about that lack of support when certificateVerificationDepth has been

Re: JDK 9 EA Build 167 and JDK 8u152 build 03 are available on jdk.java.net

Hi Mark, Can you bring this question to the jigsaw-dev mailing list, that's probably the best place to bring it up. Rgds,Rory On 28/04/2017 15:07, Mark Thomas wrote: Rory, I need some advice. Various articles I have read about Jigsaw state that Java 9 will include a new API for

[Bug 61003] Secure Websocket client hides Exception on error, and throws an IllegalStateException instead

https://bz.apache.org/bugzilla/show_bug.cgi?id=61003 --- Comment #2 from Mark Thomas --- Without any feedback, I intend to go ahead and apply the proposed change from comment #1 and then resolve this issue. -- You are receiving this mail because: You are the assignee for the

[Bug 61057] Tomcat JDT 4.6.1 Issues.

https://bz.apache.org/bugzilla/show_bug.cgi?id=61057 --- Comment #2 from Mark Thomas --- We have hit a small snag with our current process: https://issues.sonatype.org/browse/OSSRH-30961 As well as following that up, I will look to see if an alternative artefact - such as the

Re: asyncError() is not valid while in Async state DISPATCHING

2017-05-02 12:25 GMT+03:00 Mark Thomas : > > On 02/05/17 09:52, Violeta Georgieva wrote: > > Hi, > > > > I have a question about Async state DISPATCHING. > > > > I have the following scenario > > - Application invokes startAsync() and then continues processing in a > > separate

buildbot success in on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2351 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: JDK 9 EA Build 167 and JDK 8u152 build 03 are available on jdk.java.net

Hi Mark, Sorry for the delay in replying, long weekend break. I will look into this and get back to you. Rgds,Rory On 28/04/2017 15:07, Mark Thomas wrote: Rory, I need some advice. Various articles I have read about Jigsaw state that Java 9 will include a new API for applications to use to

Re: asyncError() is not valid while in Async state DISPATCHING

On 02/05/17 09:52, Violeta Georgieva wrote: > Hi, > > I have a question about Async state DISPATCHING. > > I have the following scenario > - Application invokes startAsync() and then continues processing in a > separate non-container thread A. > - At some point thread A makes dispatch() -> Async

svn commit: r1793450 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/digester/Digester.java

Author: markt Date: Tue May 2 09:14:06 2017 New Revision: 1793450 URL: http://svn.apache.org/viewvc?rev=1793450=rev Log: Fix possible NPE Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/digester/Digester.java Propchange:

svn commit: r1793449 - /tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java

Author: markt Date: Tue May 2 09:13:40 2017 New Revision: 1793449 URL: http://svn.apache.org/viewvc?rev=1793449=rev Log: Fix possible NPE Modified: tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java Modified: tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java URL:

svn commit: r1793446 - /tomcat/trunk/java/org/apache/catalina/connector/Connector.java

Author: markt Date: Tue May 2 09:09:12 2017 New Revision: 1793446 URL: http://svn.apache.org/viewvc?rev=1793446=rev Log: Revert accidental commit Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java Modified:

svn commit: r1793445 - in /tomcat/trunk/java/org/apache/tomcat/util: descriptor/web/LocalStrings.properties descriptor/web/WebXml.java descriptor/web/XmlEncodingBase.java digester/Digester.java digest

Author: markt Date: Tue May 2 09:08:27 2017 New Revision: 1793445 URL: http://svn.apache.org/viewvc?rev=1793445=rev Log: Remove deprecated code Modified: tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/LocalStrings.properties

svn commit: r1793443 - in /tomcat/trunk/java/org/apache: catalina/connector/Connector.java tomcat/util/buf/LocalStrings.properties tomcat/util/buf/UDecoder.java

Author: markt Date: Tue May 2 09:03:58 2017 New Revision: 1793443 URL: http://svn.apache.org/viewvc?rev=1793443=rev Log: Remove deprecated code Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java tomcat/trunk/java/org/apache/tomcat/util/buf/LocalStrings.properties

buildbot failure in on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2350 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1793442 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/servlets/ java/org/apache/tomcat/util/buf/ java/org/apac

Author: markt Date: Tue May 2 08:58:10 2017 New Revision: 1793442 URL: http://svn.apache.org/viewvc?rev=1793442=rev Log: Move towards using Charset rather than String internally to reduce the number of calls required to B2CConverter.getCharset() during a request. Added:

asyncError() is not valid while in Async state DISPATCHING

Hi, I have a question about Async state DISPATCHING. I have the following scenario - Application invokes startAsync() and then continues processing in a separate non-container thread A. - At some point thread A makes dispatch() -> Async state is changed to DISPATCHING - At the same time a socket

svn commit: r1793441 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/buf/UDecoder.java

Author: markt Date: Tue May 2 08:53:09 2017 New Revision: 1793441 URL: http://svn.apache.org/viewvc?rev=1793441=rev Log: Code review One method defaulted to ISO-8859-1 One method defaulted to platform default. Make them consistent (ISO-8859-1) Modified: tomcat/tc8.5.x/trunk/ (props

svn commit: r1793440 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/buf/UDecoder.java

Author: markt Date: Tue May 2 08:52:12 2017 New Revision: 1793440 URL: http://svn.apache.org/viewvc?rev=1793440=rev Log: Code review while investigating expanding the use of Charset for encoding rather than String. URLs (when %nn encoded) should always be in US-ASCII. Simplify the decode

svn commit: r1793437 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/servlets/ java/org/apache/tomcat/util/buf/ java/org/apache/tomcat/u

Author: markt Date: Tue May 2 08:45:30 2017 New Revision: 1793437 URL: http://svn.apache.org/viewvc?rev=1793437=rev Log: Move towards using Charset rather than String internally to reduce the number of calls required to B2CConverter.getCharset() during a request. Added:

[Bug 60362] Missing reason phrase in response

https://bz.apache.org/bugzilla/show_bug.cgi?id=60362 --- Comment #56 from mgrigorov --- (In reply to Silas Smith from comment #55) > I'm missing the point about why it's so important for tomcat to no longer > send the reason phrase, such that even keeping it as optional is