[Bug 61784] NPE if AuthConfigFactoryImpl.registerConfigProvider() is called with null provider name parameter

https://bz.apache.org/bugzilla/show_bug.cgi?id=61784 --- Comment #3 from Lazar --- Thanks Mark! I overlooked this case. The persistent registration definitely should be removed, because otherwise the subsequent call to getConfigProvider() will return it instead of null.

[Bug 61751] NIO2 connector cuts incoming request

https://bz.apache.org/bugzilla/show_bug.cgi?id=61751 --- Comment #7 from Remy Maucherat --- As I said, I tried the same connector with your test upload, it worked for me. This issue is not very well presented IMO, for instance it seems to imply it is a NIO2 + OpenSSL issue

[Bug 61784] NPE if AuthConfigFactoryImpl.registerConfigProvider() is called with null provider name parameter

https://bz.apache.org/bugzilla/show_bug.cgi?id=61784 --- Comment #2 from Mark Thomas --- the suggested patch addresses the NPE but doesn't handle the case of an existing persistent registration for the given registration ID. My reading of the spec that such a registration

svn commit: r1815841 - in /tomcat/tc8.5.x/trunk: ./ conf/jaspic-providers.xml

Author: markt Date: Mon Nov 20 20:04:08 2017 New Revision: 1815841 URL: http://svn.apache.org/viewvc?rev=1815841=rev Log: Revert accidental commit Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/conf/jaspic-providers.xml Propchange: tomcat/tc8.5.x/trunk/

svn commit: r1815840 - /tomcat/trunk/conf/jaspic-providers.xml

Author: markt Date: Mon Nov 20 20:03:34 2017 New Revision: 1815840 URL: http://svn.apache.org/viewvc?rev=1815840=rev Log: Revert accidental commit Modified: tomcat/trunk/conf/jaspic-providers.xml Modified: tomcat/trunk/conf/jaspic-providers.xml URL:

[Bug 61783] AuthConfigFactoryImpl.removeRegistration() does not remove from the persistent storage

https://bz.apache.org/bugzilla/show_bug.cgi?id=61783 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1815835 - in /tomcat/tc8.5.x/trunk: ./ conf/jaspic-providers.xml java/org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java test/org/apache/catalina/authenticator/jaspic/Tes

Author: markt Date: Mon Nov 20 18:51:44 2017 New Revision: 1815835 URL: http://svn.apache.org/viewvc?rev=1815835=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61783 When calling AuthConfigFactory.removeRegistration() and the registration is persistent, it should be removed from

[GitHub] tomcat pull request #91: When a persistent registration is removed, the chan...

Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/91 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1815834 - in /tomcat/trunk: conf/jaspic-providers.xml java/org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java test/org/apache/catalina/authenticator/jaspic/TestAuthConfig

Author: markt Date: Mon Nov 20 18:51:07 2017 New Revision: 1815834 URL: http://svn.apache.org/viewvc?rev=1815834=rev Log: When calling AuthConfigFactory.removeRegistration() and the registration is persistent, it should be removed from the persistent store. Patch provided by Lazar. This closes

[Bug 61782] AuthConfigFactoryImpl.doRegisterConfigProvider() does not search in the web app classloader when loading the provider class

https://bz.apache.org/bugzilla/show_bug.cgi?id=61782 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED

svn commit: r1815830 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java webapps/docs/changelog.xml

Author: markt Date: Mon Nov 20 18:27:50 2017 New Revision: 1815830 URL: http://svn.apache.org/viewvc?rev=1815830=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61782 When calling AuthConfigFactoryImpl.doRegisterConfigProvider() and the requested JASPIC config provider class is found

[GitHub] tomcat pull request #90: When loading AuthConfigProvider class upon registra...

Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/90 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1815829 - in /tomcat/trunk: java/org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java webapps/docs/changelog.xml

Author: markt Date: Mon Nov 20 18:26:28 2017 New Revision: 1815829 URL: http://svn.apache.org/viewvc?rev=1815829=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61782 When calling AuthConfigFactoryImpl.doRegisterConfigProvider() and the requested JASPIC config provider class is found

[Bug 61781] NPE in PersistentProviderRegistrations.writeProviders() if layer or app context are null

https://bz.apache.org/bugzilla/show_bug.cgi?id=61781 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED

svn commit: r1815827 - in /tomcat/tc8.5.x/trunk: ./ conf/ java/org/apache/catalina/authenticator/jaspic/ test/conf/ test/org/apache/catalina/authenticator/jaspic/ webapps/docs/

Author: markt Date: Mon Nov 20 18:16:33 2017 New Revision: 1815827 URL: http://svn.apache.org/viewvc?rev=1815827=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61781 Enable JASPIC provider registrations to be persisted when the layer and/or application context are null. Patch

svn commit: r1815826 - in /tomcat/trunk: conf/ java/org/apache/catalina/authenticator/jaspic/ test/conf/ test/org/apache/catalina/authenticator/jaspic/ webapps/docs/

Author: markt Date: Mon Nov 20 18:13:15 2017 New Revision: 1815826 URL: http://svn.apache.org/viewvc?rev=1815826=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61781 Enable JASPIC provider registrations to be persisted when the layer and/or application context are null. Patch

[GitHub] tomcat pull request #89: Fix NPE when persisting a provider without layer or...

Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/89 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1815817 - /tomcat/jk/trunk/xdocs/webserver_howto/iis.xml

Author: markt Date: Mon Nov 20 15:05:00 2017 New Revision: 1815817 URL: http://svn.apache.org/viewvc?rev=1815817=rev Log: OS testing complete. Thanks to Pivotal for providing for the MSDN license that enabled this. Modified: tomcat/jk/trunk/xdocs/webserver_howto/iis.xml Modified:

[Bug 61751] NIO2 connector cuts incoming request

https://bz.apache.org/bugzilla/show_bug.cgi?id=61751 --- Comment #6 from Markus Dörschmidt --- The real web application uses Spring Webservices 2.4.0. The SOAP request contains a base64-encoded binary element. The SOAP request never reaches the Webservice framework,

[Bug 61751] NIO2 connector cuts incoming request

https://bz.apache.org/bugzilla/show_bug.cgi?id=61751 --- Comment #5 from Remy Maucherat --- This works for me. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe,

[Bug 61780] If AuthConfigFactoryImpl.getRegistrationIDs() is called to get the IDs of all active registrations, it always returns the default registration id in the result list

https://bz.apache.org/bugzilla/show_bug.cgi?id=61780 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1815807 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java test/org/apache/catalina/authenticator/jaspic/TestAuthConfigFactoryImpl.jav

Author: markt Date: Mon Nov 20 13:39:03 2017 New Revision: 1815807 URL: http://svn.apache.org/viewvc?rev=1815807=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61780 Only include the default JASPIC registration ID in the return value for a call to

svn commit: r1815806 - in /tomcat/trunk: java/org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java test/org/apache/catalina/authenticator/jaspic/TestAuthConfigFactoryImpl.java webapps/d

Author: markt Date: Mon Nov 20 13:38:30 2017 New Revision: 1815806 URL: http://svn.apache.org/viewvc?rev=1815806=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61780 Only include the default JASPIC registration ID in the return value for a call to

[GitHub] tomcat pull request #88: Return the default registration id in the list of r...

Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/88 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61780] If AuthConfigFactoryImpl.getRegistrationIDs() is called to get the IDs of all active registrations, it always returns the default registration id in the result list

https://bz.apache.org/bugzilla/show_bug.cgi?id=61780 --- Comment #2 from Mark Thomas --- Agreed. It looks like some refactoring took place that wasn't fully taken into account. The null check is unnecessary. As is making the map volatile. -- You are receiving this mail

[GitHub] tomcat pull request #87: Fix NPE on removeRegistration in case getConfigProv...

Github user markt-asf closed the pull request at: https://github.com/apache/tomcat/pull/87 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61779] NPE in AuthConfigFactoryImpl.removeRegistration() if AuthConfigFactoryImpl.getConfigProvider() was called with null parameter for listener

https://bz.apache.org/bugzilla/show_bug.cgi?id=61779 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

[GitHub] tomcat issue #87: Fix NPE on removeRegistration in case getConfigProvider is...

Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/87 Applied in r1815802 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail:

svn commit: r1815802 - in /tomcat/trunk: java/org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java test/org/apache/catalina/authenticator/jaspic/TestAuthConfigFactoryImpl.java webapps/d

Author: markt Date: Mon Nov 20 13:10:15 2017 New Revision: 1815802 URL: http://svn.apache.org/viewvc?rev=1815802=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61779 Avoid a NullPointerException when a null RegistrationListener is passed to AuthConfigFactory.getConfigProvider()

svn commit: r1815803 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java test/org/apache/catalina/authenticator/jaspic/TestAuthConfigFactoryImpl.jav

Author: markt Date: Mon Nov 20 13:10:47 2017 New Revision: 1815803 URL: http://svn.apache.org/viewvc?rev=1815803=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61779 Avoid a NullPointerException when a null RegistrationListener is passed to AuthConfigFactory.getConfigProvider()

[Bug 61778] AuthConfigFactoryImpl.detachListener() alwas returns an empty string array

https://bz.apache.org/bugzilla/show_bug.cgi?id=61778 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1815801 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java test/org/apache/catalina/authenticator/jaspic/TestAuthConfigFactoryImpl.jav

Author: markt Date: Mon Nov 20 12:57:52 2017 New Revision: 1815801 URL: http://svn.apache.org/viewvc?rev=1815801=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61778 Correct the return value when detaching a JASPIC RegistrationListener. Patch provided by Lazar. Modified:

[GitHub] tomcat pull request #86: Fix wrong return value from removeListener()

Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/86 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1815800 - in /tomcat/trunk: java/org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java test/org/apache/catalina/authenticator/jaspic/TestAuthConfigFactoryImpl.java webapps/d

Author: markt Date: Mon Nov 20 12:57:22 2017 New Revision: 1815800 URL: http://svn.apache.org/viewvc?rev=1815800=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61778 Correct the return value when detaching a JASPIC RegistrationListener. Patch provided by Lazar. This closes #86

[Bug 61751] NIO2 connector cuts incoming request

https://bz.apache.org/bugzilla/show_bug.cgi?id=61751 --- Comment #4 from Markus Dörschmidt --- I attached a simple web application to reproduce the code. Try sending XML data to application using curl: curl -X POST -k --header "Content-Type: text/xml;charset=UTF-8"

[Bug 61751] NIO2 connector cuts incoming request

https://bz.apache.org/bugzilla/show_bug.cgi?id=61751 --- Comment #3 from Markus Dörschmidt --- Created attachment 35539 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35539=edit Minimal code to reproduce bug -- You are receiving this mail because: You are the

[Bug 61777] NPE in AuthConfigFactoryImpl.detachListener()

https://bz.apache.org/bugzilla/show_bug.cgi?id=61777 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED

svn commit: r1815794 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java test/org/apache/catalina/authenticator/jaspic/TestAuthConfigFactoryImpl.jav

Author: markt Date: Mon Nov 20 11:54:10 2017 New Revision: 1815794 URL: http://svn.apache.org/viewvc?rev=1815794=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61777 Avoid a NullPointerException when detaching a JASPIC RegistrationListener. Patch provided by Lazar. Modified:

[GitHub] tomcat pull request #85: Fix NPE in AuthConfigFactoryImpl.detachListener()

Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/85 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1815793 - in /tomcat/trunk: java/org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java test/org/apache/catalina/authenticator/jaspic/TestAuthConfigFactoryImpl.java webapps/d

Author: markt Date: Mon Nov 20 11:53:20 2017 New Revision: 1815793 URL: http://svn.apache.org/viewvc?rev=1815793=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61777 Avoid a NullPointerException when detaching a JASPIC RegistrationListener. Patch provided by Lazar. This closes #85

[GitHub] tomcat issue #85: Fix NPE in AuthConfigFactoryImpl.detachListener()

Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/85 Note there is a minor typo in the test method name. I'll fix that when I apply the patch. --- - To unsubscribe, e-mail:

svn commit: r1815791 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11Processor.java LocalStrings.properties

Author: markt Date: Mon Nov 20 11:32:54 2017 New Revision: 1815791 URL: http://svn.apache.org/viewvc?rev=1815791=rev Log: Enable host name validation for HTTP requests. Note: This only logs failures. It does not (yet) trigger a 400 response. Modified:

svn commit: r1815790 - in /tomcat/trunk/java/org/apache/tomcat/util/http/parser: HttpParser.java LocalStrings.properties

Author: markt Date: Mon Nov 20 11:31:36 2017 New Revision: 1815790 URL: http://svn.apache.org/viewvc?rev=1815790=rev Log: Add error messages when exceptions are thrown due to host name parsing issues. Modified: tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java

[GitHub] tomcat pull request #93: Make JASPIC callback handler class configurable via...

GitHub user lkirchev opened a pull request: https://github.com/apache/tomcat/pull/93 Make JASPIC callback handler class configurable via a property of the… Add property of the authenticator to specify the class name of the JASPIC callback handler. You can merge this pull request

svn commit: r1815786 - in /tomcat/trunk/java/org/apache: jasper/compiler/EncodingDetector.java tomcat/util/http/parser/HttpParser.java

Author: markt Date: Mon Nov 20 09:56:36 2017 New Revision: 1815786 URL: http://svn.apache.org/viewvc?rev=1815786=rev Log: Fix spelling of octet Modified: tomcat/trunk/java/org/apache/jasper/compiler/EncodingDetector.java

svn commit: r1815778 - /tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java

Author: markt Date: Mon Nov 20 08:53:49 2017 New Revision: 1815778 URL: http://svn.apache.org/viewvc?rev=1815778=rev Log: Fix typo Modified: tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java Modified: tomcat/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java

svn commit: r23207 - /dev/tomcat/tomcat-connectors/native/1.2.16/ /release/tomcat/tomcat-connectors/native/1.2.16/

Author: markt Date: Mon Nov 20 08:20:24 2017 New Revision: 23207 Log: Release Apache Tomcat Native 1.2.16 Added: release/tomcat/tomcat-connectors/native/1.2.16/ - copied from r23206, dev/tomcat/tomcat-connectors/native/1.2.16/ Removed: dev/tomcat/tomcat-connectors/native/1.2.16/

[RESULT][VOTE] Release Apache Tomcat Native 1.2.16

The following votes were cast: Binding: +1: markt, schultz, remm, rjung, csutherl The vote therefore passes. Thanks to everyone who contributed to this release. Mark On 15/11/17 11:03, Mark Thomas wrote: > Version 1.2.16 includes the following changes compared to 1.2.14: > > - Update