Re: JDK 11 EA 18

2018-06-20 Thread William L. Thomson Jr.
Turns out my issues were due to resources ending up in a sub-directory, prefixed with java/org, like find out in sources. One aspect I would like to see done if possible. Tomcat mixes a lot of stuff into the same directories. Its layout and what not started before the normal java conventions now

Re: [VOTE] Release Apache Tomcat 9.0.10

2018-06-20 Thread Rémy Maucherat
On Wed, Jun 20, 2018 at 9:45 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.10 release is now available for voting. > > Note: > 9.0.9 was tagged and uploaded when BZ 62476 was created and the decision > was taken to re-tag to pick up that fix. > > The major changes compared to the 9.0.8

[VOTE] Release Apache Tomcat 8.5.32

2018-06-20 Thread Mark Thomas
The proposed Apache Tomcat 8.5.32 release is now available for voting. The major changes compared to the 8.5.31 release are: - Add the RemoteCIDRFilter and RemoteCIDRValve that can be used to allow/deny requests based on IPv4 and/or IPv6 client address where the IP ranges are defined using

svn commit: r27597 - in /dev/tomcat/tomcat-8/v8.5.32: ./ bin/ bin/embed/ bin/extras/ src/

2018-06-20 Thread markt
Author: markt Date: Wed Jun 20 20:26:39 2018 New Revision: 27597 Log: Upload 8.5.32 for voting Added: dev/tomcat/tomcat-8/v8.5.32/ dev/tomcat/tomcat-8/v8.5.32/KEYS dev/tomcat/tomcat-8/v8.5.32/README.html dev/tomcat/tomcat-8/v8.5.32/RELEASE-NOTES

svn commit: r1833943 - in /tomcat/tc8.5.x/tags/TOMCAT_8_5_32: ./ build.properties.default webapps/docs/changelog.xml

2018-06-20 Thread markt
Author: markt Date: Wed Jun 20 19:47:34 2018 New Revision: 1833943 URL: http://svn.apache.org/viewvc?rev=1833943=rev Log: Tag 8.5.32 Added: tomcat/tc8.5.x/tags/TOMCAT_8_5_32/ (props changed) - copied from r1833942, tomcat/tc8.5.x/trunk/ Modified:

[VOTE] Release Apache Tomcat 9.0.10

2018-06-20 Thread Mark Thomas
The proposed Apache Tomcat 9.0.10 release is now available for voting. Note: 9.0.9 was tagged and uploaded when BZ 62476 was created and the decision was taken to re-tag to pick up that fix. The major changes compared to the 9.0.8 release are: - Add the RemoteCIDRFilter and RemoteCIDRValve that

svn commit: r1833940 - /tomcat/trunk/webapps/docs/changelog.xml

2018-06-20 Thread markt
Author: markt Date: Wed Jun 20 19:44:32 2018 New Revision: 1833940 URL: http://svn.apache.org/viewvc?rev=1833940=rev Log: Typo Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

svn commit: r1833939 - /tomcat/trunk/webapps/docs/changelog.xml

2018-06-20 Thread markt
Author: markt Date: Wed Jun 20 19:42:35 2018 New Revision: 1833939 URL: http://svn.apache.org/viewvc?rev=1833939=rev Log: Update status Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

svn commit: r1833938 - /tomcat/trunk/webapps/docs/changelog.xml

2018-06-20 Thread markt
Author: markt Date: Wed Jun 20 19:40:51 2018 New Revision: 1833938 URL: http://svn.apache.org/viewvc?rev=1833938=rev Log: Fix typo Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

svn commit: r27587 - in /dev/tomcat/tomcat-9/v9.0.10: ./ bin/ bin/embed/ bin/extras/ src/

2018-06-20 Thread markt
Author: markt Date: Wed Jun 20 18:29:41 2018 New Revision: 27587 Log: Upload 9.0.10 for voting Added: dev/tomcat/tomcat-9/v9.0.10/ dev/tomcat/tomcat-9/v9.0.10/KEYS dev/tomcat/tomcat-9/v9.0.10/README.html dev/tomcat/tomcat-9/v9.0.10/RELEASE-NOTES

svn commit: r1833932 - in /tomcat/trunk: build.properties.default res/maven/mvn-pub.xml res/maven/mvn.properties.default webapps/docs/changelog.xml

2018-06-20 Thread markt
Author: markt Date: Wed Jun 20 18:10:29 2018 New Revision: 1833932 URL: http://svn.apache.org/viewvc?rev=1833932=rev Log: Increment version for next development cycle Modified: tomcat/trunk/build.properties.default tomcat/trunk/res/maven/mvn-pub.xml

svn commit: r1833930 - in /tomcat/tags/TOMCAT_9_0_10: ./ build.properties.default webapps/docs/changelog.xml

2018-06-20 Thread markt
Author: markt Date: Wed Jun 20 17:29:24 2018 New Revision: 1833930 URL: http://svn.apache.org/viewvc?rev=1833930=rev Log: Tag 9.0.10 Added: tomcat/tags/TOMCAT_9_0_10/ (props changed) - copied from r1833929, tomcat/trunk/ Modified:

buildbot success in on tomcat-8-trunk

2018-06-20 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-8-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-8-trunk/builds/1350 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[GitHub] tomcat pull request #115: Setting Timezone to GMT for Expires Header as per ...

2018-06-20 Thread markt-asf
Github user markt-asf closed the pull request at: https://github.com/apache/tomcat/pull/115 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #115: Setting Timezone to GMT for Expires Header as per RFC1123

2018-06-20 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/115 Thanks for the PR. We have fixed this but with a simpler approach that makes use of `ConcurrentDateFormat.formatRfc1123()` ---

[Bug 62476] Expires header shall use GMT timezone

2018-06-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62476 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1833922 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/authenticator/AuthenticatorBase.java webapps/docs/changelog.xml

2018-06-20 Thread markt
Author: markt Date: Wed Jun 20 15:03:50 2018 New Revision: 1833922 URL: http://svn.apache.org/viewvc?rev=1833922=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62476 Use GMT timezone for the value of Expires header Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1833921 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/util/ConcurrentDateFormat.java

2018-06-20 Thread markt
Author: markt Date: Wed Jun 20 15:02:39 2018 New Revision: 1833921 URL: http://svn.apache.org/viewvc?rev=1833921=rev Log: Add specific RFC1123 support Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/util/ConcurrentDateFormat.java Modified:

svn commit: r1833920 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/authenticator/AuthenticatorBase.java webapps/docs/changelog.xml

2018-06-20 Thread markt
Author: markt Date: Wed Jun 20 14:54:23 2018 New Revision: 1833920 URL: http://svn.apache.org/viewvc?rev=1833920=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62476 Use GMT timezone for the value of Expires header Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1833919 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/authenticator/AuthenticatorBase.java webapps/docs/changelog.xml

2018-06-20 Thread markt
Author: markt Date: Wed Jun 20 14:51:04 2018 New Revision: 1833919 URL: http://svn.apache.org/viewvc?rev=1833919=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62476 Use GMT timezone for the value of Expires header Modified: tomcat/tc8.5.x/trunk/ (props changed)

[Bug 62476] Expires header shall use GMT timezone

2018-06-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62476 --- Comment #2 from Konstantin Kolinko --- It is a static constant. It is calculated only once. Looking at references to RFC1123_DATE constant, I am more concerned of "TimeZone.getTimeZone("GMT")" calls in Response#addDateHeader(),

svn commit: r1833918 - /tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java

2018-06-20 Thread markt
Author: markt Date: Wed Jun 20 14:29:45 2018 New Revision: 1833918 URL: http://svn.apache.org/viewvc?rev=1833918=rev Log: Simplify Modified: tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java Modified:

svn commit: r1833916 - in /tomcat/trunk: build.properties.default res/maven/mvn-pub.xml res/maven/mvn.properties.default webapps/docs/changelog.xml

2018-06-20 Thread markt
Author: markt Date: Wed Jun 20 14:11:15 2018 New Revision: 1833916 URL: http://svn.apache.org/viewvc?rev=1833916=rev Log: Increment version for next development cycle Modified: tomcat/trunk/build.properties.default tomcat/trunk/res/maven/mvn-pub.xml

svn commit: r1833915 - in /tomcat/trunk: java/org/apache/catalina/authenticator/AuthenticatorBase.java webapps/docs/changelog.xml

2018-06-20 Thread kkolinko
Author: kkolinko Date: Wed Jun 20 14:08:52 2018 New Revision: 1833915 URL: http://svn.apache.org/viewvc?rev=1833915=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62476 Use GMT timezone for the value of Expires header Modified:

[Bug 62476] Expires header shall use GMT timezone

2018-06-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62476 Michael Osipov <1983-01...@gmx.net> changed: What|Removed |Added OS||All --- Comment

[Bug 62476] New: Expires header shall use GMT timezone

2018-06-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62476 Bug ID: 62476 Summary: Expires header shall use GMT timezone Product: Tomcat 9 Version: 9.0.8 Hardware: PC Status: NEW Severity: normal Priority: P2

svn commit: r1833913 - in /tomcat/tags/TOMCAT_9_0_9: ./ build.properties.default webapps/docs/changelog.xml

2018-06-20 Thread markt
Author: markt Date: Wed Jun 20 13:05:58 2018 New Revision: 1833913 URL: http://svn.apache.org/viewvc?rev=1833913=rev Log: Tag 9.0.9 Added: tomcat/tags/TOMCAT_9_0_9/ (props changed) - copied from r1833908, tomcat/trunk/ Modified: tomcat/tags/TOMCAT_9_0_9/build.properties.default

[Bug 62453] Tomcat tries to resolve uninitialized tag attributes in EL as java class names and this behavior causes performance problems.

2018-06-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62453 --- Comment #7 from Konstantin Kolinko --- I think that the feature of JSP Tag files reported in this BZ ticket is rather confusing. In my opinion, if I have a tag file that declares <%@ attribute name="baz" %> then evaluating "${baz}"

[Bug 62453] Tomcat tries to resolve uninitialized tag attributes in EL as java class names and this behavior causes performance problems.

2018-06-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62453 --- Comment #6 from Mark Thomas --- That typo is significant. With the typo fixed the performance difference is 4.6s vs ~50ms - two orders of magnitude difference. I think that probably changes the balance. Future additions to java.lang

[Bug 62453] Tomcat tries to resolve uninitialized tag attributes in EL as java class names and this behavior causes performance problems.

2018-06-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62453 --- Comment #5 from Rainer Jung --- (In reply to Konstantin Kolinko from comment #4) > (I wonder if it is possible to do a consistency check programmatically - > similar to OpenSSL cipher suite tests that we have. The crucial thing is to >

[GitHub] tomcat issue #115: Setting Timezone to GMT for Expires Header as per RFC1123

2018-06-20 Thread rainerjung
Github user rainerjung commented on the issue: https://github.com/apache/tomcat/pull/115 @michael-o IMHO because an invalid header value will push most parsing code to the error handling code path. And only by additional rules should that code handle it like a valid header in the

svn commit: r1833907 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/Nio2Endpoint.java java/org/apache/tomcat/util/net/NioEndpoint.java

2018-06-20 Thread markt
Author: markt Date: Wed Jun 20 11:28:28 2018 New Revision: 1833907 URL: http://svn.apache.org/viewvc?rev=1833907=rev Log: Improve tracking of connection closure. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

svn commit: r1833906 - in /tomcat/trunk/java/org/apache/tomcat/util/net: Nio2Endpoint.java NioEndpoint.java

2018-06-20 Thread markt
Author: markt Date: Wed Jun 20 11:27:53 2018 New Revision: 1833906 URL: http://svn.apache.org/viewvc?rev=1833906=rev Log: Improve tracking of connection closure. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

[Bug 62453] Tomcat tries to resolve uninitialized tag attributes in EL as java class names and this behavior causes performance problems.

2018-06-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62453 --- Comment #4 from Konstantin Kolinko --- (In reply to Mark Thomas from comment #2) > Created attachment 35975 [details] > Patch for potential optimisation > standardPackages.put("javax.jsp.servlet", servletJspClassNames); A typo. The

[GitHub] tomcat issue #115: Setting Timezone to GMT for Expires Header as per RFC1123

2018-06-20 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/115 @rainerjung My question simply was that if `Expires: 0` denotes a value in the past (expired already), why should I explicitly use a valid header in the past which requires more code to create as

[GitHub] tomcat issue #115: Setting Timezone to GMT for Expires Header as per RFC1123

2018-06-20 Thread rainerjung
Github user rainerjung commented on the issue: https://github.com/apache/tomcat/pull/115 @michael-o APR_DATE_BAD: the date string was null, or unparsable or the parsed date does not exist. A date in the past would not result in APR_DATE_BAD. A timestamp before the unix epoch should

[GitHub] tomcat issue #115: Setting Timezone to GMT for Expires Header as per RFC1123

2018-06-20 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/115 Here is the reference commit: https://github.com/apache/httpd/commit/60087a708b051c3c987b80abdfdc3f2e046ebc4d @rainerjung How is `APR_DATE_BAD` defined? Unparsable? Or before Unix epoch?

[GitHub] tomcat issue #115: Setting Timezone to GMT for Expires Header as per RFC1123

2018-06-20 Thread rainerjung
Github user rainerjung commented on the issue: https://github.com/apache/tomcat/pull/115 Note that although the RFC demands to handle an invalid Expires header (like Expires: 0) like one with a timestamp in the past, I coincidentally ran into a problem yesterday, where the Apache web

[ANN] Apache Tomcat Native 1.2.17 released

2018-06-20 Thread Jean-Frederic Clere
The Apache Tomcat team announces the immediate availability of Apache Tomcat Native 1.2.17 stable. The key features of this release are: - Windows binaries built with APR 1.6.3 and OpenSSL 1.0.2o. - Fix Certificate verification using CRL. - Arrange OCSP response processing. Note that users