Re: [VOTE] Release Apache Tomcat 8.5.38

2019-02-07 Thread Felix Schumacher
Am 05.02.19 um 13:22 schrieb Mark Thomas: The proposed Apache Tomcat 8.5.38 release is now available for voting. The major changes compared to the 8.5.37 release are: - Update the packaged version of the Tomcat Native Library to 1.2.21 to pick up the memory leak fixes when using

buildbot success in on tomcat-trunk

2019-02-07 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4034 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[Bug 63143] Respect client's browser preference for English language (can be fixed by providing empty LocalStrings_en.properties files)

2019-02-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63143 --- Comment #2 from Christopher Schultz --- I didn't look at Mark's fix, but at $work, we always work on Bundle_en.properties for English. At build time, we specify the "Default locale" and copy Bundle_[locale].properties to Bundle.properties.

svn commit: r32396 - /dev/tomcat/tomcat-9/v9.0.16/ /release/tomcat/tomcat-9/v9.0.16/

2019-02-07 Thread markt
Author: markt Date: Fri Feb 8 00:04:59 2019 New Revision: 32396 Log: Release Apache Tomcat 9.0.16 Added: release/tomcat/tomcat-9/v9.0.16/ - copied from r32395, dev/tomcat/tomcat-9/v9.0.16/ Removed: dev/tomcat/tomcat-9/v9.0.16/

svn commit: r1853185 - /tomcat/trunk/webapps/docs/changelog.xml

2019-02-07 Thread markt
Author: markt Date: Fri Feb 8 00:01:29 2019 New Revision: 1853185 URL: http://svn.apache.org/viewvc?rev=1853185=rev Log: Release vote passed. Add the release date. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

[VOTE][RESULT] Release Apache Tomcat 9.0.16

2019-02-07 Thread Mark Thomas
The following votes were cast: Binding: +1: remm, kfujino, markt, ebourg Non-Binding: +1: isapir The vote therefore passes. Thank you to everyone who contributed to this release. - To unsubscribe, e-mail:

buildbot success in on tomcat-85-trunk

2019-02-07 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-85-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/1639 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1853184 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http2/Stream.java test/org/apache/coyote/http2/Http2TestBase.java test/org/apache/coyote/http2/TestHttp2InitialConnection.jav

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 23:38:02 2019 New Revision: 1853184 URL: http://svn.apache.org/viewvc?rev=1853184=rev Log: When performing an HTTP/1.1 upgrade to HTTP/2 (h2c) ensure that the hostname and port from the HTTP/1.1 Host header of the upgraded request are made available via the

svn commit: r1853183 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/buf/MessageBytes.java test/org/apache/tomcat/util/buf/TestMessageBytes.java webapps/docs/changelog.xml

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 23:25:08 2019 New Revision: 1853183 URL: http://svn.apache.org/viewvc?rev=1853183=rev Log: Ensure that the toString(), toBytes() and toChars() methods of MessageBytes behave consistently and do not throw a NullPointerException both on newly created objects and

svn commit: r1853182 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/buf/MessageBytes.java

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 23:23:12 2019 New Revision: 1853182 URL: http://svn.apache.org/viewvc?rev=1853182=rev Log: Code clean-up. No functional change. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/buf/MessageBytes.java

svn commit: r1853181 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/mapper/Mapper.java

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 23:16:17 2019 New Revision: 1853181 URL: http://svn.apache.org/viewvc?rev=1853181=rev Log: Avoid unlikely NPE Identified by SpotBugs Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/catalina/mapper/Mapper.java

svn commit: r1853180 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/mapper/Mapper.java java/org/apache/jasper/compiler/ELParser.java java/org/apache/jasper/compiler/JspUtil.java

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 23:15:40 2019 New Revision: 1853180 URL: http://svn.apache.org/viewvc?rev=1853180=rev Log: SpotBugs Potential overflow in averaging (v. unlikely but an easy fix...) Modified: tomcat/tc8.5.x/trunk/ (props changed)

Re: buildbot failure in on tomcat-85-trunk

2019-02-07 Thread Mark Thomas
On 07/02/2019 22:57, build...@apache.org wrote: > The Buildbot has detected a new failure on builder tomcat-85-trunk while > building . Full details are available at: > https://ci.apache.org/builders/tomcat-85-trunk/builds/1635 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for

buildbot failure in on tomcat-85-trunk

2019-02-07 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-85-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/1635 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1853179 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/mbeans/ java/org/apache/catalina/startup/ java/org/apache/catalina

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 22:54:50 2019 New Revision: 1853179 URL: http://svn.apache.org/viewvc?rev=1853179=rev Log: Refactor the code that searches for a matching error page by working up the class hierarchy of an exception type to ErrorPageSupport to enable re-use. Modified:

svn commit: r1853178 [2/2] - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/mbeans/ java/org/apache/tomcat/util/modeler/ webapps/docs/

2019-02-07 Thread markt
Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/mbeans/MemoryUserDatabaseMBean.java URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/mbeans/MemoryUserDatabaseMBean.java?rev=1853178=1853177=1853178=diff

svn commit: r1853178 [1/2] - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/mbeans/ java/org/apache/tomcat/util/modeler/ webapps/docs/

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 22:53:33 2019 New Revision: 1853178 URL: http://svn.apache.org/viewvc?rev=1853178=rev Log: Refactor the MBean implementations for the internal Tomcat components to reduce code duplication. Added:

svn commit: r1853176 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/Context.java java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/util/ErrorPageSupport.java

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 22:42:04 2019 New Revision: 1853176 URL: http://svn.apache.org/viewvc?rev=1853176=rev Log: Refactor error page related code into a separate class so it can be re-used in the ErrorReportValve. Deprecate a couple of unused methods. Added:

svn commit: r1853174 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ test/org/apache/coyote/ajp/ t

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 22:36:52 2019 New Revision: 1853174 URL: http://svn.apache.org/viewvc?rev=1853174=rev Log: Providing the error does not require the immediate closure of the connection, pass all errors (invalid requests etc.) that occur before the request processing pipeline is

svn commit: r1853173 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/connector/CoyoteAdapter.java java/org/apache/catalina/connector/Response.java

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 22:33:11 2019 New Revision: 1853173 URL: http://svn.apache.org/viewvc?rev=1853173=rev Log: Move updating of the wrapper error count to the end of the request processing so errors that occur early in the processing chain can be counted - assuming a wrapper can be

svn commit: r1853172 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/StandardHostValve.java

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 22:32:31 2019 New Revision: 1853172 URL: http://svn.apache.org/viewvc?rev=1853172=rev Log: Strengthen comment Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardHostValve.java Propchange:

svn commit: r1853170 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/connector/CoyoteAdapter.java java/org/apache/catalina/mapper/Mapper.java webapps/docs/changelog.xml

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 22:27:37 2019 New Revision: 1853170 URL: http://svn.apache.org/viewvc?rev=1853170=rev Log: Refactor the handling of invalid URIs so the ErrorReportValve can be used. Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1853168 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/connector/CoyoteAdapter.java webapps/docs/changelog.xml

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 22:26:03 2019 New Revision: 1853168 URL: http://svn.apache.org/viewvc?rev=1853168=rev Log: Pass 404 errors triggered by a missing ROOT web application to the container error handling to generate the response body. Modified: tomcat/tc8.5.x/trunk/ (props

svn commit: r1853167 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/connector/Response.java java/org/apache/catalina/core/LocalStrings.properties java/org/apache/catalina/core/StandardHostVal

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 22:24:47 2019 New Revision: 1853167 URL: http://svn.apache.org/viewvc?rev=1853167=rev Log: Refactor error handling to enable errors that occur before processing is passed to the application to be handled by the application provided error handling and/or the

svn commit: r1853165 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/startup/HostConfig.java

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 22:12:13 2019 New Revision: 1853165 URL: http://svn.apache.org/viewvc?rev=1853165=rev Log: Simplify code Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/catalina/startup/HostConfig.java Propchange:

svn commit: r1853164 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/Context.java java/org/apache/catalina/connector/CoyoteAdapter.java java/org/apache/catalina/connector/Request.java

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 22:10:40 2019 New Revision: 1853164 URL: http://svn.apache.org/viewvc?rev=1853164=rev Log: Clean-up A running Context always has a non-null Authenticator Clean-up the few remaining places that the unnecessary null checks remained. Modified:

svn commit: r1853162 - /tomcat/trunk/test/org/apache/coyote/http2/TestHttp2InitialConnection.java

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 21:34:35 2019 New Revision: 1853162 URL: http://svn.apache.org/viewvc?rev=1853162=rev Log: Follow on to r1853152 Modified: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2InitialConnection.java Modified:

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2019-02-07 Thread Bill Barker
-SNAPSHOT.jar -Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20190207/bin/openssl -Dexecute .test.nio=false -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar -Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar -Dexecute.test.apr=false

buildbot failure in on tomcat-trunk

2019-02-07 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4032 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1853152 - in /tomcat/trunk: java/org/apache/coyote/http2/Stream.java test/org/apache/coyote/http2/Http2TestBase.java test/org/apache/coyote/http2/TestHttp2InitialConnection.java webapps/d

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 17:34:46 2019 New Revision: 1853152 URL: http://svn.apache.org/viewvc?rev=1853152=rev Log: When performing an HTTP/1.1 upgrade to HTTP/2 (h2c) ensure that the hostname and port from the HTTP/1.1 Host header of the upgraded request are made available via the

Re: [CONF] Apache Tomcat > Servlet TCK

2019-02-07 Thread Mark Thomas
On 07/02/2019 14:19, Rémy Maucherat wrote: > On Thu, Feb 7, 2019 at 3:05 PM Mark Thomas wrote: > >> On 07/02/2019 13:50, Remy Maucherat (Confluence) wrote: >>> There's *1 new edit* on your page >> >> >> >>> Here's what changed: >>> >>> ... >>> >>> >>> >>> >> >> Thanks. Just found that

Re: [CONF] Apache Tomcat > Servlet TCK

2019-02-07 Thread Rémy Maucherat
On Thu, Feb 7, 2019 at 3:05 PM Mark Thomas wrote: > On 07/02/2019 13:50, Remy Maucherat (Confluence) wrote: > > There's *1 new edit* on your page > > > > > Here's what changed: > > > > ... > > > > > > > > > > Thanks. Just found that myself. > > > Enable h2c on port 8080, and add some trailer

Re: [CONF] Apache Tomcat > Servlet TCK

2019-02-07 Thread Mark Thomas
On 07/02/2019 13:50, Remy Maucherat (Confluence) wrote: > There's *1 new edit* on your page > Here's what changed: > > ... > > > > Thanks. Just found that myself. > Enable h2c on port 8080, and add some trailer headers > > ... > > * 1 x TCK bug - missing endorsedLib configuration >

svn commit: r1853130 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/ApplicationPushBuilder.java webapps/docs/changelog.xml

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 12:47:22 2019 New Revision: 1853130 URL: http://svn.apache.org/viewvc?rev=1853130=rev Log: Refactor how cookies are transferred from the base request to a PushBuilder so that they are accessible, and may be edited, via the standard PushBuilder methods for working

svn commit: r1853129 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/ApplicationPushBuilder.java

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 12:46:22 2019 New Revision: 1853129 URL: http://svn.apache.org/viewvc?rev=1853129=rev Log: SpotBugs: Fix a couple of minor issues Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1853128 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/ApplicationPushBuilder.java

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 12:45:46 2019 New Revision: 1853128 URL: http://svn.apache.org/viewvc?rev=1853128=rev Log: Take advantage of the cached session principal if possible. Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1853127 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/ApplicationPushBuilder.java

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 12:45:09 2019 New Revision: 1853127 URL: http://svn.apache.org/viewvc?rev=1853127=rev Log: - Don't use setHeader for the cookie header, the header copy is done before. - Use AJP auth mechanism to pass a userName that will be used again for auth. Modified:

svn commit: r1853125 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/ApplicationPushBuilder.java webapps/docs/changelog.xml

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 12:43:54 2019 New Revision: 1853125 URL: http://svn.apache.org/viewvc?rev=1853125=rev Log: Minor push builder fixes: exception on an empty method. Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1853124 - in /tomcat/trunk: java/org/apache/catalina/core/ApplicationPushBuilder.java webapps/docs/changelog.xml

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 12:36:12 2019 New Revision: 1853124 URL: http://svn.apache.org/viewvc?rev=1853124=rev Log: Refactor how cookies are transferred from the base request to a PushBuilder so that they are accessible, and may be edited, via the standard PushBuilder methods for working

svn commit: r1853123 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/Constants.java java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java webapps/docs/changelog.xml webapps/do

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 12:24:32 2019 New Revision: 1853123 URL: http://svn.apache.org/viewvc?rev=1853123=rev Log: Implement an alternative solution to four failing TCK test and (yah!) remove a system property. Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1853122 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/websocket/Constants.java java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java webapps/docs/changelog.xml webapps/do

2019-02-07 Thread markt
Author: markt Date: Thu Feb 7 12:20:51 2019 New Revision: 1853122 URL: http://svn.apache.org/viewvc?rev=1853122=rev Log: Implement an alternative solution to four failing TCK test and (yah!) remove a system property. Modified: tomcat/tc8.5.x/trunk/ (props changed)

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2019-02-07 Thread Bill Barker
-SNAPSHOT.jar -Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20190207/bin/openssl -Dexecute .test.nio=false -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar -Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar -Dexecute.test.apr=false