[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2019-04-08 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration.

[tomcat] branch master updated: Import (o.a.t.b.translate.Import) Korean translations

2019-04-08 Thread woonsan
This is an automated email from the ASF dual-hosted git repository. woonsan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 6e2308e Import (o.a.t.b.translate.Import)

[Bug 63237] Consider processing mbeans-descriptors.xml at compile time

2019-04-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63237 --- Comment #5 from Phillip Webb --- I've got an experimental branch[1] that replaces the XML files with registrar classes. So far the results aren't particularly inspiring and I'm not seeing a big improvement in performance. I think the main

[GitHub] [tomcat] markt-asf commented on issue #154: Don't serialize CrawlerSessionManagerValve into session attributes

2019-04-08 Thread GitBox
markt-asf commented on issue #154: Don't serialize CrawlerSessionManagerValve into session attributes URL: https://github.com/apache/tomcat/pull/154#issuecomment-481032500 Using an `HttpSessionListener` gets tricky because it has to be registered with every web application. That is

buildbot success in on tomcat-trunk

2019-04-08 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4190 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[tomcat] branch master updated: Additional fix required for async I/O and HTTP/2 'swallow output'

2019-04-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 4cfe667 Additional fix required for async I/O

buildbot failure in on tomcat-trunk

2019-04-08 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4189 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: [tomcat] branch master updated: Fix the HTTP/2 equivalent of swallowInput

2019-04-08 Thread Mark Thomas
On 08/04/2019 20:38, Mark Thomas wrote: > I'm not sure. Do you have the complete logs for those tests? I'd like to > look at everything sent from the client to the server for stream 3. Thanks for the logs (sent off-list). They didn't line up with my code which made me realise I was working

[tomcat] branch master updated: Include error message in debug log

2019-04-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new a25adf9 Include error message in debug log

Re: [tomcat] branch master updated: Fix the HTTP/2 equivalent of swallowInput

2019-04-08 Thread Mark Thomas
On 08/04/2019 14:16, Rémy Maucherat wrote: > On Mon, Apr 8, 2019 at 11:05 AM Mark Thomas wrote: >> On 08/04/2019 09:57, Rémy Maucherat wrote: >>> On Sun, Apr 7, 2019 at 10:42 PM wrote: commit 6d3c117384c11f1bfd9393fb1484cd5a708a8245 Author: Mark Thomas AuthorDate: Sun Apr 7

[tomcat] branch master updated: Fix service.bat references in instructions

2019-04-08 Thread csutherl
This is an automated email from the ASF dual-hosted git repository. csutherl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new bfc4c38 Fix service.bat references in

[GitHub] [tomcat] ChristopherSchultz commented on issue #154: Don't serialize CrawlerSessionManagerValve into session attributes

2019-04-08 Thread GitBox
ChristopherSchultz commented on issue #154: Don't serialize CrawlerSessionManagerValve into session attributes URL: https://github.com/apache/tomcat/pull/154#issuecomment-480940752 Perhaps the title of this PR should be "don't place CrawlerSessionManagerValve into session, place

[GitHub] [tomcat] mlem commented on issue #154: Don't serialize the whole valve into session, but use a smaller object.

2019-04-08 Thread GitBox
mlem commented on issue #154: Don't serialize the whole valve into session, but use a smaller object. URL: https://github.com/apache/tomcat/pull/154#issuecomment-480863047 I've filed an issue: https://bz.apache.org/bugzilla/show_bug.cgi?id=63324 The problem is, that we serialize

[Bug 63324] CrawlerSessionManagerValve is getting put into Session, which causes problems when serializing sessions

2019-04-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63324 --- Comment #1 from Martin L --- For a more broad understanding: We have a mem-cached session serialization strategy for our multiple tomcat instances. When one server goes down, we serialize the sessions into memcache and put it on a

[Bug 63324] New: CrawlerSessionManagerValve is getting put into Session, which causes problems when serializing sessions

2019-04-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63324 Bug ID: 63324 Summary: CrawlerSessionManagerValve is getting put into Session, which causes problems when serializing sessions Product: Tomcat 8 Version:

[GitHub] [tomcat] kkolinko commented on issue #154: Don't serialize the whole valve into session, but use a smaller object.

2019-04-08 Thread GitBox
kkolinko commented on issue #154: Don't serialize the whole valve into session, but use a smaller object. URL: https://github.com/apache/tomcat/pull/154#issuecomment-480852735 1. Your title is lacking. Your "valve" is CrawlerSessionManagerValve. 2. Behaviour of

[GitHub] [tomcat] mlem opened a new pull request #156: Don't serialize the whole valve into session, but use a smaller object. 7.0.x

2019-04-08 Thread GitBox
mlem opened a new pull request #156: Don't serialize the whole valve into session, but use a smaller object. 7.0.x URL: https://github.com/apache/tomcat/pull/156 It helps to serialize this sessions with libraries like kryo. Background: we've found out, that our kryo library

[GitHub] [tomcat] mlem opened a new pull request #155: Don't serialize the whole valve into session, but use a smaller object.

2019-04-08 Thread GitBox
mlem opened a new pull request #155: Don't serialize the whole valve into session, but use a smaller object. URL: https://github.com/apache/tomcat/pull/155 It helps to serialize this sessions with libraries like kryo. Background: we've found out, that our kryo library serializes

[GitHub] [tomcat] mlem commented on issue #154: Don't serialize the whole valve into session, but use a smaller object.

2019-04-08 Thread GitBox
mlem commented on issue #154: Don't serialize the whole valve into session, but use a smaller object. URL: https://github.com/apache/tomcat/pull/154#issuecomment-480842434 We are getting this message in our log all the time. I've found out, that our serialization library (Kryo) is

[GitHub] [tomcat] mlem opened a new pull request #154: Don't serialize the whole valve into session, but use a smaller object.

2019-04-08 Thread GitBox
mlem opened a new pull request #154: Don't serialize the whole valve into session, but use a smaller object. URL: https://github.com/apache/tomcat/pull/154 It helps to serialize this sessions with libraries like kryo. Background: we've found out, that our kryo library serializes

Re: [tomcat] branch master updated: Fix the HTTP/2 equivalent of swallowInput

2019-04-08 Thread Rémy Maucherat
On Mon, Apr 8, 2019 at 11:05 AM Mark Thomas wrote: > On 08/04/2019 09:57, Rémy Maucherat wrote: > > On Sun, Apr 7, 2019 at 10:42 PM wrote: > > > >> This is an automated email from the ASF dual-hosted git repository. > >> > >> markt pushed a commit to branch master > >> in repository

[Bug 57665] support x-forwarded-host

2019-04-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57665 --- Comment #23 from Alexander Veit --- Same problem here. Our reverse proxy is IIS with ARR (Application Request Routing). In our case we can not send the original Host header via a Host header to the backend (embedded Tomcat). The strange

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2019-04-08 Thread Bill Barker
-SNAPSHOT.jar -Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20190408/bin/openssl -Dexecute .test.nio=false -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar -Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar -Dexecute.test.apr=false

[tomcat] branch 8.5.x updated: Fix typo

2019-04-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 6ef82f7 Fix typo 6ef82f7 is described below

[tomcat] branch master updated: Fix typo

2019-04-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 3c851bc Fix typo 3c851bc is described below

Re: [tomcat] branch master updated: Fix the HTTP/2 equivalent of swallowInput

2019-04-08 Thread Mark Thomas
On 08/04/2019 09:57, Rémy Maucherat wrote: > On Sun, Apr 7, 2019 at 10:42 PM wrote: > >> This is an automated email from the ASF dual-hosted git repository. >> >> markt pushed a commit to branch master >> in repository https://gitbox.apache.org/repos/asf/tomcat.git >> >> >> The following

Re: [tomcat] branch master updated: Fix the HTTP/2 equivalent of swallowInput

2019-04-08 Thread Rémy Maucherat
On Sun, Apr 7, 2019 at 10:42 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

[Bug 63320] StatementCache interceptor does not cache statements that return values in dedicated columns

2019-04-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63320 --- Comment #1 from Ronny Schuetz --- Just for clarification, as the description might be a bit misleading: The results get added to the internal map, but cannot be retrieved anymore due to the broken CacheKey implementation. -- You are

[Bug 63318] Invalid character found in the request target 400 error ignores ErrorReportValve

2019-04-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63318 --- Comment #5 from Mark Thomas --- In this case the 400 error occurred before the web application was mapped so there was no Context identified. In those circumstances Tomcat can't route the request to the Context because it doesn't know

[Bug 63318] Invalid character found in the request target 400 error ignores ErrorReportValve

2019-04-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63318 --- Comment #4 from Larssa Andin --- Ok, I now understand what went wrong. I configured the error report valve in the context.xml and not in the server.xml. Most (all?) other errors ends up in the context, except the 400 error that must be