Re: FYI SvcBatch - Windows service wrapper

2020-11-16 Thread Mladen Turk
On 16/11/2020 20:00, Mark Thomas wrote: On 16/11/2020 18:12, Mladen Turk wrote: This means that instead complex configuration, one can use catalina.bat directly, enabling versatile customization So to check my understanding: - sc.exe is used to manage the service - configuration is via the sa

Re: FYI SvcBatch - Windows service wrapper

2020-11-16 Thread Mark Thomas
On 16/11/2020 18:12, Mladen Turk wrote: > Hi, > > The current procrun from commons-daemon we use to run Tomcat as > Windows service is not actively maintained any more. Huh? It most certainly is. There is a release being discussed right now. I'm left with an unfortunate impression of an attempt t

[GitHub] [tomcat] akurth commented on a change in pull request #377: Set "Secure" session cookie attribute if called under SSL.

2020-11-16 Thread GitBox
akurth commented on a change in pull request #377: URL: https://github.com/apache/tomcat/pull/377#discussion_r524478033 ## File path: test/org/apache/catalina/valves/TestLoadBalancerDrainingValve.java ## @@ -238,6 +238,8 @@ private void runValve(String jkActivation,

FYI SvcBatch - Windows service wrapper

2020-11-16 Thread Mladen Turk
Hi, The current procrun from commons-daemon we use to run Tomcat as Windows service is not actively maintained any more. I have created a SvcBatch project that uses different approach by running batch files as services. This means that instead complex configuration, one can use catalina.bat dir

[Bug 64872] Inefficient enum resolution in JSPs

2020-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64872 --- Comment #17 from John Engebretson --- Thanks for the activation info, that's perfect. I've verified the enum case works as I intended on our production servers; the compiled java code correctly points directly to the enum rather than any r

[Bug 64872] Inefficient enum resolution in JSPs

2020-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64872 --- Comment #16 from Mark Thomas --- Glad you think it is heading in the right direction. It might not look it but the important parts are heavily based on the patch you provided. I am only going from source code rather than testing but I don'

[Bug 64872] Inefficient enum resolution in JSPs

2020-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64872 --- Comment #15 from John Engebretson --- Reading over your commit, it is vastly superior to my implementation, and I am grateful for your efforts. :) The attached patch addresses the attr="enumValue" case using a code branch towards the bot

[Bug 64872] Inefficient enum resolution in JSPs

2020-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64872 --- Comment #14 from Mark Thomas --- Here is a first pass at a possible approach using ELInterpreter. This doesn't address the attr="enumValue" case but my reading of the attached patch is that it doesn't handle that case either. Since that is

[GitHub] [tomcat] ChristopherSchultz commented on a change in pull request #377: Set "Secure" session cookie attribute if called under SSL.

2020-11-16 Thread GitBox
ChristopherSchultz commented on a change in pull request #377: URL: https://github.com/apache/tomcat/pull/377#discussion_r524294255 ## File path: test/org/apache/catalina/valves/TestLoadBalancerDrainingValve.java ## @@ -238,6 +238,8 @@ private void runValve(String jkActivation,

[Bug 64926] Misaligned VersionLoggerListener lines in german locale

2020-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64926 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED OS|

[Bug 64926] New: Misaligned VersionLoggerListener lines in german locale

2020-11-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64926 Bug ID: 64926 Summary: Misaligned VersionLoggerListener lines in german locale Product: Tomcat 9 Version: 9.0.39 Hardware: PC Status: NEW Severity:

[GitHub] [tomcat] jbampton commented on pull request #361: Add a GitHub action to lint the Markdown and YAML files.

2020-11-16 Thread GitBox
jbampton commented on pull request #361: URL: https://github.com/apache/tomcat/pull/361#issuecomment-727913731 Hey @markt-asf I have rebased and moved the two config files back to the repo root. The 2 files are not specific to GitHub so say we moved to GitLab we wouldn't want our wh

buildbot failure in on tomcat-9-trunk

2020-11-16 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/545 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch 8.5.x updated: Increment version number for next dev cycle

2020-11-16 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new db07bfe Increment version number for next dev cycl

[tomcat] branch 9.0.x updated: Increment version for next development cycle

2020-11-16 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new d35349d Increment version for next development cyc

[tomcat] branch 9.0.x updated: Increment version for next development cycle

2020-11-16 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new d35349d Increment version for next development cyc

[tomcat] branch 9.0.x updated: Increment version for next development cycle

2020-11-16 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new d35349d Increment version for next development cyc

[tomcat] branch 9.0.x updated: Increment version for next development cycle

2020-11-16 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new d35349d Increment version for next development cyc