[tomcat] branch 7.0.x updated: Increment version number for next development cycle

2021-04-22 Thread violetagg
This is an automated email from the ASF dual-hosted git repository. violetagg pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new c0934d9 Increment version number for next

[VOTE] Release Apache Tomcat 7.0.109

2021-04-22 Thread Violeta Georgieva
The proposed Apache Tomcat 7.0.109 release is now available for voting. Please note that this is the last Tomcat 7 release. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.109/ The Maven staging repo is:

[tomcat] 01/01: Tag 7.0.109

2021-04-22 Thread violetagg
This is an automated email from the ASF dual-hosted git repository. violetagg pushed a commit to tag 7.0.109 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 2cdef2c0241cdf70b5edd88d3733a52e6b675047 Author: Violeta Georgieva AuthorDate: Thu Apr 22 11:34:21 2021 -0700 Tag

[tomcat] tag 7.0.109 created (now 2cdef2c)

2021-04-22 Thread violetagg
This is an automated email from the ASF dual-hosted git repository. violetagg pushed a change to tag 7.0.109 in repository https://gitbox.apache.org/repos/asf/tomcat.git. at 2cdef2c (commit) This tag includes the following new commits: new 2cdef2c Tag 7.0.109 The 1 revisions

svn commit: r47342 [1/2] - in /dev/tomcat/tomcat-7/v7.0.109: ./ bin/ bin/embed/ bin/extras/ src/

2021-04-22 Thread violetagg
Author: violetagg Date: Thu Apr 22 19:04:32 2021 New Revision: 47342 Log: Stage Tomcat 7.0.109 Added: dev/tomcat/tomcat-7/v7.0.109/ dev/tomcat/tomcat-7/v7.0.109/KEYS dev/tomcat/tomcat-7/v7.0.109/README.html dev/tomcat/tomcat-7/v7.0.109/RELEASE-NOTES

svn commit: r47342 [2/2] - in /dev/tomcat/tomcat-7/v7.0.109: ./ bin/ bin/embed/ bin/extras/ src/

2021-04-22 Thread violetagg
Added: dev/tomcat/tomcat-7/v7.0.109/bin/extras/tomcat-juli-adapters.jar.sha512 == --- dev/tomcat/tomcat-7/v7.0.109/bin/extras/tomcat-juli-adapters.jar.sha512 (added) +++

Re: [websocket] proper SPI for encoder/decoder instantiation?

2021-04-22 Thread Mark Thomas
On 22/04/2021 18:44, Romain Manni-Bucau wrote: Le jeu. 22 avr. 2021 à 17:32, Mark Thomas a écrit : On 22/04/2021 16:24, Romain Manni-Bucau wrote: Hi, Is it possible to reuse/add/have a SPI to create ws coders/decoders? Currently it is a hardcoded factory doing a "new"

Re: Websocket server configurator as @ServiceProvider: a bug?

2021-04-22 Thread Romain Manni-Bucau
It is not wrong per se but it is not usable to plug a custom impl which is my issue. @Mark: what about ignoring the default if there is another impl in serviceloader iteration? Would fix it even if it would create some useless stuff but recent serviceloader api solves it if we want to avoid it

Re: [websocket] proper SPI for encoder/decoder instantiation?

2021-04-22 Thread Romain Manni-Bucau
Le jeu. 22 avr. 2021 à 17:32, Mark Thomas a écrit : > On 22/04/2021 16:24, Romain Manni-Bucau wrote: > > Hi, > > > > Is it possible to reuse/add/have a SPI to create ws coders/decoders? > > > > Currently it is a hardcoded factory doing a "new" > > (org.apache.tomcat.websocket.Util#getDecoders

[tomcat] 03/04: Remove unnecessary code.

2021-04-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 1c1fb14930b5ccf19d7dacaf6582c20f8b8658d6 Author: Mark Thomas AuthorDate: Wed Apr 21 19:46:04 2021 +0100 Remove

[tomcat] 02/04: Remove unused code

2021-04-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 7dcf54b7a7f5fdd9560241d25427aba3e8899a84 Author: Mark Thomas AuthorDate: Wed Apr 21 12:51:04 2021 +0100 Remove

[tomcat] 01/04: Remove unnecessary code.

2021-04-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b58cc1149894633ff426b1dd993f2745dfc4a0cc Author: Mark Thomas AuthorDate: Wed Apr 21 09:42:48 2021 +0100 Remove

[tomcat] 04/04: Remove unnecessary code

2021-04-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit bf5b9feca166557134120f0fc5210588c7b3673d Author: Mark Thomas AuthorDate: Thu Apr 22 17:19:05 2021 +0100 Remove

[tomcat] branch master updated (e663ab0 -> bf5b9fe)

2021-04-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from e663ab0 Code clean-up. No functional change. Primarily to trigger a CI build. new b58cc11 Remove unnecessary

Re: Websocket server configurator as @ServiceProvider: a bug?

2021-04-22 Thread Raymond Augé
Romain are you saying that having a service descriptor in this case is wrong? On Thu., Apr. 22, 2021, 11:47 a.m. Mark Thomas, wrote: > On 22/04/2021 16:18, Romain Manni-Bucau wrote: > > I am not in JPMS Ray. > > > > About I think the issue is a "double bug" (well one bug, two step > >

Re: Websocket server configurator as @ServiceProvider: a bug?

2021-04-22 Thread Mark Thomas
On 22/04/2021 16:18, Romain Manni-Bucau wrote: I am not in JPMS Ray. About I think the issue is a "double bug" (well one bug, two step resolutions) since I can drop the SPI registration but then @ServiceProvider will recreate it so I propose: 1. to drop the explicit SPI registration and keep

Re: [websocket] proper SPI for encoder/decoder instantiation?

2021-04-22 Thread Mark Thomas
On 22/04/2021 16:24, Romain Manni-Bucau wrote: Hi, Is it possible to reuse/add/have a SPI to create ws coders/decoders? Currently it is a hardcoded factory doing a "new" (org.apache.tomcat.websocket.Util#getDecoders for decoders, for encoders it is a bit worse since there is an instance as a

[websocket] proper SPI for encoder/decoder instantiation?

2021-04-22 Thread Romain Manni-Bucau
Hi, Is it possible to reuse/add/have a SPI to create ws coders/decoders? Currently it is a hardcoded factory doing a "new" (org.apache.tomcat.websocket.Util#getDecoders for decoders, for encoders it is a bit worse since there is an instance as a check here

Re: Websocket server configurator as @ServiceProvider: a bug?

2021-04-22 Thread Romain Manni-Bucau
I am not in JPMS Ray. About I think the issue is a "double bug" (well one bug, two step resolutions) since I can drop the SPI registration but then @ServiceProvider will recreate it so I propose: 1. to drop the explicit SPI registration and keep the default which is 1-1 (even faster but that's

Tag Tomcat 7

2021-04-22 Thread Violeta Georgieva
Hi, I'm gonna tag Tomcat 7 later today. Regards, Violeta

Re: Websocket server configurator as @ServiceProvider: a bug?

2021-04-22 Thread Romain Manni-Bucau
Le jeu. 22 avr. 2021 à 16:06, Raymond Augé a écrit : > @ServiceProvider is just a hint no? > Hmm, didn't check the tomcat specific setup but thought it was adding META-INF/services/ entry too which is current issue. Seems you are right and

Re: Websocket server configurator as @ServiceProvider: a bug?

2021-04-22 Thread Raymond Augé
On Thu., Apr. 22, 2021, 9:46 a.m. Raymond Augé, wrote: > @ServiceProvider is just a hint no? > > It does not change the implementation behavior... Unless you've found > otherwise, which would be surprising. > To be clear, there is no runtime behavior associated with @ServiceProvider _unless_

Re: Websocket server configurator as @ServiceProvider: a bug?

2021-04-22 Thread Raymond Augé
Are you maybe in JPMS mode? On Thu., Apr. 22, 2021, 9:51 a.m. Raymond Augé, wrote: > > > On Thu., Apr. 22, 2021, 9:46 a.m. Raymond Augé, > wrote: > >> @ServiceProvider is just a hint no? >> >> It does not change the implementation behavior... Unless you've found >> otherwise, which would be

Re: Websocket server configurator as @ServiceProvider: a bug?

2021-04-22 Thread Raymond Augé
@ServiceProvider is just a hint no? It does not change the implementation behavior... Unless you've found otherwise, which would be surprising. Ray On Thu., Apr. 22, 2021, 9:29 a.m. Romain Manni-Bucau, wrote: > Hi all, > > Websocket server configurator uses the SPI to load the impl and if not

Websocket server configurator as @ServiceProvider: a bug?

2021-04-22 Thread Romain Manni-Bucau
Hi all, Websocket server configurator uses the SPI to load the impl and if not found fallbacks on the hardcoded tomcat default. Isn't the SPI intended to override the default and therefore @ServiceProvider breaks this feature? If not, how to override it globally without doing it on a per endpoint

Re: More CI issues

2021-04-22 Thread Mark Thomas
On 21/04/2021 19:53, Mark Thomas wrote: Both GitHUb CI and Travis CI have started to report failures due to hash mismatches for downloaded resources. I'm not sure what is going on at this point. It doesn't seem to be related to a faulty mirror or an incorrect download hash in

[tomcat] branch 8.5.x updated: Code clean-up. No functional change. Primarily to trigger a CI build.

2021-04-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new d3a0122 Code clean-up. No functional change.

[tomcat] branch 9.0.x updated (c741d99 -> eac02dc)

2021-04-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from c741d99 Fix use of useInstanceManagerForTags with Tags that are inner classes add eac02dc Code clean-up. No

[tomcat] branch master updated: Code clean-up. No functional change. Primarily to trigger a CI build.

2021-04-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new e663ab0 Code clean-up. No functional change.