[GitHub] [tomcat] Catclaws12 commented on a change in pull request #183: preload driver in connection pool

2021-10-20 Thread GitBox
Catclaws12 commented on a change in pull request #183: URL: https://github.com/apache/tomcat/pull/183#discussion_r733090607 ## File path: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java ## @@ -335,7 +308,7 @@ protected void

Re: 2 tests in TestCoyoteAdapterCanonicalization fail

2021-10-20 Thread Mark Thomas
I'm not seeing those failures with OpenJDK 17.0.1 The response line and body look to be correct to me. The failure appears to be with the request body. Is it possible you aren't using UTF-8 for the *.java file? You could try using "/foo\u20acbar" as the expected canonicalized URI. Mark On

2 tests in TestCoyoteAdapterCanonicalization fail

2021-10-20 Thread Martin Grigorov
Hi, Today I've tested JDK 17.0.1 and noticed these failures: Testcase: testCanonicalizationSpecification[49: requestURI[/foo%E2%82%ACbar]] took 0.055 sec FAILED HTTP/1.1 200 /foo€bar junit.framework.AssertionFailedError: HTTP/1.1 200 /foo€bar at