Re: TestRewriteValve Fails When Specifying Custom Output Directory

2023-03-20 Thread Igal Sapir
Mark, On Mon, Mar 20, 2023 at 5:10 AM Mark Thomas wrote: > On 18/03/2023 20:53, Igal Sapir wrote: > > Mark, > > > > On Thu, Mar 16, 2023 at 2:12 AM Mark Thomas wrote: > > > >> On 15/03/2023 21:16, Igal Sapir wrote: > >> > >> > >> > >>> It is mostly solved, and that might be sufficient. > >>>

[Bug 66535] FarmWarDeployer will fail to deploy a WAR file when maxvalidtime is less than the time it takes to transfer

2023-03-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66535 --- Comment #2 from Alex West --- If this is intended behavior, the documentation should be updated to explain that the configuration setting has a bearing on the amount of time it may take to transfer WAR files over a slow network, or many

[Bug 66535] FarmWarDeployer will fail to deploy a WAR file when maxvalidtime is less than the time it takes to transfer

2023-03-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66535 --- Comment #1 from Alex West --- Although this may be 'intended' behavior, the code would lead me to believe that the developers intended this to be a check on whether the file was 'valid' and whether it had been 'idle' for some time. I

[Bug 66535] New: FarmWarDeployer will fail to deploy a WAR file when maxvalidtime is less than the time it takes to transfer

2023-03-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66535 Bug ID: 66535 Summary: FarmWarDeployer will fail to deploy a WAR file when maxvalidtime is less than the time it takes to transfer Product: Tomcat 9 Version:

[GitHub] [tomcat-connectors] gjaekel commented on pull request #7: Possible issue in ajp_read_fully_from_server()

2023-03-20 Thread via GitHub
gjaekel commented on PR #7: URL: https://github.com/apache/tomcat-connectors/pull/7#issuecomment-1476245704 Yes, it's in the error log. It's also quite easy to Google for it if you know that you have to search for the keyword `limitrequestbody`. :o The dev's of our application in

[GitHub] [tomcat-connectors] rainerjung commented on pull request #7: Possible issue in ajp_read_fully_from_server()

2023-03-20 Thread via GitHub
rainerjung commented on PR #7: URL: https://github.com/apache/tomcat-connectors/pull/7#issuecomment-1476223841 Thanks for finding the reason. I guess there should have been a log message in the httpd error log. I now added the missing item for this change into the httpd CHANGES for

[GitHub] [tomcat-connectors] gjaekel commented on pull request #7: Possible issue in ajp_read_fully_from_server()

2023-03-20 Thread via GitHub
gjaekel commented on PR #7: URL: https://github.com/apache/tomcat-connectors/pull/7#issuecomment-1476151899 It seems, that the reason is very lame! With https://github.com/apache/httpd/commit/92499e20034485c5e2d29cb85940e309573d976e the default for _LimitRequestBody_ becomes **1GB**

Re: TestRewriteValve Fails When Specifying Custom Output Directory

2023-03-20 Thread Mark Thomas
On 18/03/2023 20:53, Igal Sapir wrote: Mark, On Thu, Mar 16, 2023 at 2:12 AM Mark Thomas wrote: On 15/03/2023 21:16, Igal Sapir wrote: It is mostly solved, and that might be sufficient. So while `ant clean test` now completes without failures, the part that still doesn't work is when I

[GitHub] [tomcat-connectors] gjaekel commented on pull request #7: Possible issue in ajp_read_fully_from_server()

2023-03-20 Thread via GitHub
gjaekel commented on PR #7: URL: https://github.com/apache/tomcat-connectors/pull/7#issuecomment-1476084475 Dear Mark, first let my thank you for quick reply. I understand you in a way that this is already a "death code path" that can't rise issues anymore. I actually "staring

[GitHub] [tomcat-connectors] markt-asf closed pull request #7: Possible issue in ajp_read_fully_from_server()

2023-03-20 Thread via GitHub
markt-asf closed pull request #7: Possible issue in ajp_read_fully_from_server() URL: https://github.com/apache/tomcat-connectors/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tomcat-connectors] markt-asf commented on pull request #7: Possible issue in ajp_read_fully_from_server()

2023-03-20 Thread via GitHub
markt-asf commented on PR #7: URL: https://github.com/apache/tomcat-connectors/pull/7#issuecomment-1476047870 The reason for this code: http://markmail.org/message/lowlwgb7fs4v3yuq It aims to ensure that there isn't an attempt to read when the buffer has insufficient space for a

[GitHub] [tomcat-connectors] gjaekel opened a new pull request, #7: Possible issue in ajp_read_fully_from_server()

2023-03-20 Thread via GitHub
gjaekel opened a new pull request, #7: URL: https://github.com/apache/tomcat-connectors/pull/7 The the outer `while`-loop was changed to respect a padded length yeas before. But according to this, imho the `read()` should append the same number of bytes as a maximum, too. If I'm wrong,