tomcat-native v2.0+ breaks unix domain socket support on java16-

2023-03-06 Thread Graham Leggett
Hi all, A while back I added unix domain socket support to tomcat-native, and patched tomcat to use it until java16 is available. Unfortunately unix domain socket support was removed from tomcat-native 2.0+, and now tomcat-native 2.0+ is appearing in distros, meaning that unix domain socket

Re: Migrate from Bugzilla to GitHub Issues

2022-08-18 Thread Graham Leggett
On 18 Aug 2022, at 06:57, Vladimir Sitnikov wrote: > Have you considered migrating from Bugzilla to GitHub Issues? > > I think co-locating issues, code, and PRs at GitHub would make it easier to > browse both issues and code. -1. GitHub as a service is hosted by someone else, who are in no

Re: [tomcat] branch master updated: Apply same UDS path perm approach in the AprEndpoint as in the NioEndpoint

2021-02-02 Thread Graham Leggett
On 01 Feb 2021, at 22:11, Michael Osipov wrote: >> If I’m reading this correctly this breaks Windows - the permissions on the >> UDS socket will be the same as those of the Tomcat process, which is “I can >> talk to me, but everyone else is read only, so unless you’re me I refuse to >> serve

Re: [tomcat] branch master updated: Add support for Unix Domain Sockets (APR Protocol)

2021-02-01 Thread Graham Leggett
On 01 Feb 2021, at 11:51, Mark Thomas wrote: >> +if (family == Socket.APR_UNIX) { >> +if (getUnixDomainSocketPathPermissions() != null) { >> +FileAttribute> attrs = >> + >>

Re: [tomcat] branch master updated: Apply same UDS path perm approach in the AprEndpoint as in the NioEndpoint

2021-02-01 Thread Graham Leggett
On 01 Feb 2021, at 14:12, micha...@apache.org wrote: >Apply same UDS path perm approach in the AprEndpoint as in the NioEndpoint > --- > java/org/apache/tomcat/util/net/AprEndpoint.java | 10 +++--- > java/org/apache/tomcat/util/net/NioEndpoint.java | 3 ++- > 2 files changed, 5

Re: Objection to the deprecation of the tomcat-native/APR connector

2020-12-09 Thread Graham Leggett
On 01 Dec 2020, at 14:09, Mark Thomas wrote: >> I also object to the removal of OpenSSL code, for the same reason. > > It isn't being removed. The APR/Native library will be retained along > with OpenSSL support for the NIO and NIO2. > > I expect the scope of the APR/Native library for Tomcat

Re: Objection to the deprecation of the tomcat-native/APR connector

2020-12-01 Thread Graham Leggett
On 01 Dec 2020, at 13:48, Rémy Maucherat wrote: > You still have years to plan a migration off the APR connector as it will > only be removed in 10.1 and Tomcat 9.0 continues to be supported. > > This eventual removal or APR has been discussed for years. BTW, so that you > know, there are also

Objection to the deprecation of the tomcat-native/APR connector

2020-12-01 Thread Graham Leggett
Hi all, I object to the deprecation of the tomcat-native/APR connector. Most specifically, I am -1 on the following: https://marc.info/?l=tomcat-dev=160681846808019=2 Looking at past discussion on this, the justification has been: "It is inherently less stable. If we get the NIO code wrong,