Re: [VOTE] C-T-R for any translation fixes

2010-03-08 Thread Mladen Turk
On 03/08/2010 08:00 PM, Konstantin Kolinko wrote: I propose to relax our RTC policy and use CTR for the types of changes listed below: Usually a vote has a single voting item, but all those things you've put to vote are something many projects already have as a policy. Allow C-T-R for cha

Re: [VOTE] C-T-R for any translation fixes

2010-03-08 Thread Mladen Turk
Your vote proposal is not very much readable. Please make a standard single request for vote and check boxes +1, -1 (+0, -0 are irrelevant thought, but might be added as well) On 03/08/2010 06:34 PM, Konstantin Kolinko wrote: 1. We already have Commit-Then-Review for any documentation, includ

Re: svn commit: r920093 - in /tomcat/jk/trunk: native/iis/jk_isapi_plugin.c xdocs/reference/iis.xml

2010-03-08 Thread Mladen Turk
On 03/08/2010 08:57 AM, Tim Whittington wrote: Thanks I'm trying to track down a VC6 install so I can test the .dsp build before I commit. Maybe a move to VC2003 as a minimum might be in order some day. We just need MSVCRT, and the functions you've added are Microsoft vision of POSIX function

Re: svn commit: r920225 - /tomcat/jk/trunk/native/iis/jk_isapi_plugin.c

2010-03-08 Thread Mladen Turk
On 03/08/2010 09:08 AM, t...@apache.org wrote: Author: timw Date: Mon Mar 8 08:08:46 2010 New Revision: 920225 URL: http://svn.apache.org/viewvc?rev=920225&view=rev Log: Fixing VC6 build by replacing uses of strcpy_s with StringCbCopy. There are bunch of other functions with _s suffix you've

Re: svn commit: r920093 - in /tomcat/jk/trunk: native/iis/jk_isapi_plugin.c xdocs/reference/iis.xml

2010-03-07 Thread Mladen Turk
On 03/07/2010 09:31 PM, t...@apache.org wrote: Author: timw +/* Remember the current log file name for the next potential rotate */ +strcpy_s(log_file_effective, sizeof(log_file_effective), log_file_name); -1 You will have to use StringCb routines here, because strcpy

Re: svn commit: r920086 - in /tomcat/jk/trunk/native/apache-2.0: Makefile.vc mod_jk.rc

2010-03-07 Thread Mladen Turk
On 03/07/2010 09:17 PM, t...@apache.org wrote: Author: timw --- tomcat/jk/trunk/native/apache-2.0/mod_jk.rc (added) +++ tomcat/jk/trunk/native/apache-2.0/mod_jk.rc Sun Mar 7 20:17:04 2010 @@ -0,0 +1,97 @@ +// Microsoft Visual C++ generated resource script. +// Nice but this should be hand craf

Re: svn commit: r917928 - in /tomcat/trunk: java/org/apache/tomcat/jni/SSL.java java/org/apache/tomcat/util/net/AprEndpoint.java java/org/apache/tomcat/util/net/res/LocalStrings.properties webapps/do

2010-03-04 Thread Mladen Turk
On 03/04/2010 12:48 PM, Rainer Jung wrote: On 02.03.2010 10:14, mt...@apache.org wrote: Author: mturk Date: Tue Mar 2 09:14:44 2010 New Revision: 917928 URL: http://svn.apache.org/viewvc?rev=917928&view=rev Log: Port SSLInsecureRenegotiation from mod_ssl Modified: tomcat/trunk/java/org/apache/

Re: svn commit: r917921 - in /tomcat/native/branches/1.1.x: java/org/apache/tomcat/jni/SSL.java native/include/ssl_private.h native/src/ssl.c native/src/sslcontext.c xdocs/miscellaneous/changelog.xml

2010-03-03 Thread Mladen Turk
On 03/03/2010 01:19 PM, Mladen Turk wrote: On 03/02/2010 05:58 PM, jean-frederic clere wrote: On 03/02/2010 05:47 PM, Mladen Turk wrote: On 03/02/2010 05:43 PM, jean-frederic clere wrote: On 03/02/2010 09:51 AM, mt...@apache.org wrote: Author: mturk Date: Tue Mar 2 08:51:46 2010 New Revision

Re: svn commit: r917921 - in /tomcat/native/branches/1.1.x: java/org/apache/tomcat/jni/SSL.java native/include/ssl_private.h native/src/ssl.c native/src/sslcontext.c xdocs/miscellaneous/changelog.xml

2010-03-03 Thread Mladen Turk
On 03/02/2010 05:58 PM, jean-frederic clere wrote: On 03/02/2010 05:47 PM, Mladen Turk wrote: On 03/02/2010 05:43 PM, jean-frederic clere wrote: On 03/02/2010 09:51 AM, mt...@apache.org wrote: Author: mturk Date: Tue Mar 2 08:51:46 2010 New Revision: 917921 URL: http://svn.apache.org/viewvc

Re: [RESULTS][VOTE] Release build 6.0.25

2010-03-03 Thread Mladen Turk
On 03/03/2010 08:33 AM, jean-frederic clere wrote: Stable [3] Broken [2] So we go for a 6.0.26. Please commit the stuff voted in STATUS.txt And few ones that need votes :) E.g the trivial exception throwing fix for APR connector on shutdown. Regards -- ^TM --

Re: svn commit: r917921 - in /tomcat/native/branches/1.1.x: java/org/apache/tomcat/jni/SSL.java native/include/ssl_private.h native/src/ssl.c native/src/sslcontext.c xdocs/miscellaneous/changelog.xml

2010-03-02 Thread Mladen Turk
On 03/02/2010 05:58 PM, jean-frederic clere wrote: How does that interacts with http://svn.apache.org/viewvc?rev=881179&view=rev ? The same way as in mod_ssl Yes but won't it be possible to allow client initiated renegotiation with 0.9.8m? According to the OpenSSL docs: If the option SSL

Re: svn commit: r917921 - in /tomcat/native/branches/1.1.x: java/org/apache/tomcat/jni/SSL.java native/include/ssl_private.h native/src/ssl.c native/src/sslcontext.c xdocs/miscellaneous/changelog.xml

2010-03-02 Thread Mladen Turk
On 03/02/2010 05:43 PM, jean-frederic clere wrote: On 03/02/2010 09:51 AM, mt...@apache.org wrote: Author: mturk Date: Tue Mar 2 08:51:46 2010 New Revision: 917921 URL: http://svn.apache.org/viewvc?rev=917921&view=rev Log: Add unafe legacy renegotiation support How does that interacts with h

Re: svn commit: r917931 - /tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java

2010-03-02 Thread Mladen Turk
On 03/02/2010 01:17 PM, Remy Maucherat wrote: On Tue, 2010-03-02 at 09:19 +, mt...@apache.org wrote: Author: mturk Date: Tue Mar 2 09:19:45 2010 New Revision: 917931 URL: http://svn.apache.org/viewvc?rev=917931&view=rev Log: With unsafe reneg, minimum required is 1.2.21 caused by API chang

Tagging Tomcat Native 1.2.21

2010-03-02 Thread Mladen Turk
Hi, I backported mod_ssl's SSLInsecureRenegotiation option and would like to T&R 1.2.21 with compiled OpenSSL 0.9.8m that should fully solve the CVE-2009-3555. ABI is extended to allow checking the OpenSSL feature supported, so usage would require 1.2.21. Comments? Regards -- ^TM ---

Re: [VOTE] Release build 6.0.25

2010-03-02 Thread Mladen Turk
On 02/24/2010 11:56 AM, jean-frederic clere wrote: The candidates binaries are available here: http://people.apache.org/~jfclere/tomcat-6/v6.0.25/ If the release is postponed I'd like to add the legacy renegotiation support from trunk. It requires tomcat-native 1.2.21 release first with compil

[ANN] Apache Tomcat Connectors 1.2.30 released

2010-03-01 Thread Mladen Turk
The Apache Tomcat team announces the immediate availability of Apache Tomcat Connectors 1.2.30 stable. Apache Tomcat Connectors 1.2.30 concentrates mainly on bug fixes. Please refer to the change log for the list of changes: http://tomcat.apache.org/connectors-doc/miscellaneous/changelog.html D

Re: [VOTE] Release Tomcat Connectors 1.2.30

2010-03-01 Thread Mladen Turk
On 02/28/2010 11:57 PM, Rainer Jung wrote: One addition: the combination of the a+c mode and fflush() shows the problem. As soon as I remove one of the two, perforemance is fine. What 'c' flag does is to actually call _commit (FlushFileBuffers) on fflush(). Without that the fflush is called w

RESULT Was: [VOTE] Withdraw Tomcat Connectors 1.2.29

2010-02-28 Thread Mladen Turk
On 02/27/2010 01:02 PM, Konstantin Kolinko wrote: If withdrawing needs a vote, here is my +1. We have collected required three binding votes so I'll proceed and remove 1.2.29 from dist and arch, update the site and make a notice of that with 1.2.30 announcement Regards -- ^TM -

Re: [VOTE] Release Tomcat Connectors 1.2.30

2010-02-28 Thread Mladen Turk
On 02/27/2010 12:14 PM, Mladen Turk wrote: With my vote Apache Tomcat Connectors 1.2.30 is: [X] Stable - no major issues, no regressions we have collected required three binding votes so I'll proceed with copying to dist and making announcement. Regards -

Re: [VOTE] Release Tomcat Connectors 1.2.30

2010-02-28 Thread Mladen Turk
On 02/28/2010 11:18 PM, Rainer Jung wrote: On 27.02.2010 12:14, Mladen Turk wrote: Apache Tomcat Connectors 1.2.30 is: [X] Stable - no major issues, no regressions [ ] Beta - at least one significant issue -- tell us what it is [ ] Alpha - multiple significant issues -- tell us what they are

Re: [VOTE] Withdraw Tomcat Connectors 1.2.29 (was: svn commit: r916938)

2010-02-27 Thread Mladen Turk
On 02/27/2010 04:16 PM, Rainer Jung wrote: On 27.02.2010 15:54, Mladen Turk wrote: On 02/27/2010 03:24 PM, Rainer Jung wrote: I just made an notice on tomcat index.html Should be enough thought. I'll also add the same notice to README.html files inside binaries/ Shouldn't we also

Re: [VOTE] Withdraw Tomcat Connectors 1.2.29 (was: svn commit: r916938)

2010-02-27 Thread Mladen Turk
On 02/27/2010 03:24 PM, Rainer Jung wrote: I just made an notice on tomcat index.html Should be enough thought. I'll also add the same notice to README.html files inside binaries/ Shouldn't we also remove the 29 files form dist and archive? Once when the vote is done. I'd rather see it repl

Re: [VOTE] Withdraw Tomcat Connectors 1.2.29 (was: svn commit: r916938)

2010-02-27 Thread Mladen Turk
On 02/27/2010 02:28 PM, Konstantin Kolinko wrote: 2010/2/27 Mladen Turk: +1 If withdrawing needs a vote, here is my +1. It does. Same as for release. It's been only a day since announced, so as soon we remove it and release 1.2.30 with fix we'll make less users angry. Announcem

Re: [VOTE] Withdraw Tomcat Connectors 1.2.29 (was: svn commit: r916938)

2010-02-27 Thread Mladen Turk
+1 On 02/27/2010 01:02 PM, Konstantin Kolinko wrote: 2010/2/27: Author: mturk Date: Sat Feb 27 10:16:14 2010 New Revision: 916938 URL: http://svn.apache.org/viewvc?rev=916938&view=rev Log: Revert withdrawal notice. Seems this requires a vote If withdrawing needs a vote, here is my +1. It

[VOTE] Release Tomcat Connectors 1.2.30

2010-02-27 Thread Mladen Turk
Hi, We have one serious bug with 1.2.29 that causes IIS to crash on POST request. http://issues.apache.org/bugzilla/show_bug.cgi?id=48826 Other web connectors are not affected by that bug Please test the provided release so we can replace the existing 1.2.29 ASAP. http://tomcat.apache.org/dev/

Withdrawing JK 1.2.29 and releasing 1.2.30

2010-02-27 Thread Mladen Turk
Hi, We have a bug with IIS/1.2.29 which makes it unusable and it crashes the IIS. I'll tag the 1.2.30 and make immediate vote/release because it's a serious regression. I suppose we would need to withdraw 1.2.29 as well Regards -- ^TM ---

Re: [VOTE] Release Apache Tomcat Native 1.1.20

2010-02-26 Thread Mladen Turk
On 02/26/2010 06:39 PM, William A. Rowe Jr. wrote: On 2/10/2010 4:19 AM, Mladen Turk wrote: Apache Tomcat Native 1.1.20 is: [ ] Stable - no major issues, no regressions [ ] Beta - at least one significant issue -- tell us what it is [ ] Alpha - multiple significant issues -- tell us what

New README.html inside /www/www.apache.org/dist/tomcat/tomcatX

2010-02-26 Thread Mladen Turk
Hi, I added README.html directory listing footer as well as .htaccess with extensions description. So, when doing release, update the README.html with the current stable version number. It is shown on http://www.apache.org/dist/tomcat/tomcat-6/ (If not hit F-5) Regards -- ^TM ---

[ANN] Apache Tomcat Connectors 1.2.29 released

2010-02-26 Thread Mladen Turk
The Apache Tomcat team announces the immediate availability of Apache Tomcat Connectors 1.2.29 stable. Apache Tomcat Connectors 1.2.29 concentrates mainly on bug fixes. Please refer to the change log for the list of changes: http://tomcat.apache.org/connectors-doc-1.2.29/miscellaneous/changelog.

Re: svn commit: r916587 - in /tomcat/site/trunk: docs/download-connectors.html docs/index.html xdocs/download-connectors.xml xdocs/index.xml

2010-02-25 Thread Mladen Turk
On 02/26/2010 07:56 AM, Konstantin Kolinko wrote: The above line: I think you meant s/mainly/many/ I meant mainly s/over ... 1.2.29/over ... 1.2.28/ Now, that WAS a typo :) Cheers -- ^TM - To unsubscribe, e-mail: dev-un

[RESULT] Was: [VOTE] Release Tomcat Connectors 1.2.29

2010-02-25 Thread Mladen Turk
On 02/23/2010 04:06 PM, Mladen Turk wrote: Apache Tomcat Connectors 1.2.29 is: With my vote ... [X] Stable - no major issues, no regressions [ ] Beta - at least one significant issue -- tell us what it is [ ] Alpha - multiple significant issues -- tell us what they are We have gathered

Using Commons Daemon 1.0.2

2010-02-25 Thread Mladen Turk
Hi, Just released the Daemon 1.0.2. Since now we've been using custom Daemon spins basically tagging the trunk and maintaining our set of binaries. Released version has everything but some things like jsvc.tar.gz aren't there any more. Don't panic cause it is now inside commons-daemon-1.0.2-nat

Re: [VOTE] Release build 6.0.25

2010-02-24 Thread Mladen Turk
On 02/24/2010 11:56 AM, jean-frederic clere wrote: According to the release process, the 6.0.25 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable Checked on windows and linux. You might wish to add the note about known issue Windows exception thrown on shutdown SEVERE: Socket accept failed. T

Re: svn commit: r915323 - in /tomcat/jk/trunk/native: common/jk_version.h iis/isapi_redirect.rc

2010-02-23 Thread Mladen Turk
On 02/23/2010 05:35 PM, Felix Schumacher wrote: Hi, I think the new version string JK_VERSTRING should be 1.2.30 not 1.2.10. Right, it was typo. Thanks -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For a

[VOTE] Release Tomcat Connectors 1.2.29

2010-02-23 Thread Mladen Turk
Hi, Tomcat Connectors 1.2.29 version is available for testing: http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/ Sources can be found at: http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/source/jk-1.2.29/ (Note that the tomcat-connectors-1.2.29-dev-912307-src.* files will be visible

Re: Tagging 1.2.29

2010-02-22 Thread Mladen Turk
On 02/23/2010 08:41 AM, Rainer Jung wrote: Hi Mladen, Should we mention in the changelog, that it needs improvement? Sure. Go ahead and add a notice. changelog might not be the proper place, but it seems we don't have anything more appropriate. Thanks for those last minute updates! Cheers

Tagging 1.2.29

2010-02-22 Thread Mladen Turk
Hi, I plan to tag 1.2.29 tomorrow around 12:00 GMT and later propose a vote. We had few release snapshots that had no show-stoppers reported beside one bug and one regression that are already solved. In case someone has a serious reason why I shouldn't do that, please speak. Regards -- ^TM ---

Re: jk/cluster - intelligent systems load

2010-02-19 Thread Mladen Turk
On 02/19/2010 05:06 PM, Henri Gomez wrote: Not a mod_proxy guru, but filtering X-header from responses should be near trivial based on past experience with the proxy code. There is the GPL licence 'problem' of the Hyperic lib which should be 'solved' isn't ? Tomcat Native already has some c

Re: JK 1.2.29-dev Available for testing

2010-02-19 Thread Mladen Turk
On 02/17/2010 04:24 PM, Rainer Jung wrote: thanks for rolling. Did you see BZ 48742, which seems to be a show-stopper regression. Updated a new snapshot (911726) with BZ48742 fixed. I plan to stick with the schedule and tag on Tuesday. Regards -- ^TM ---

Re: jk/cluster - intelligent systems load

2010-02-17 Thread Mladen Turk
On 02/17/2010 07:37 PM, Costin Manolache wrote: On Wed, Feb 17, 2010 at 12:38 AM, Mladen Turk wrote: The reasons I suggest using SPDY as a replacement for AJP - and supporting SPDY I have nothing against SPDY and it really looks cool, but IMHO it's doesn't look and feel like the r

Re: JK 1.2.29-dev Available for testing

2010-02-17 Thread Mladen Turk
On 02/17/2010 04:24 PM, Rainer Jung wrote: thanks for rolling. Did you see BZ 48742, which seems to be a show-stopper regression. Nope, didn't see that, and it looks like a regression. I'll fix that and make another test run on Friday. Regards -- ^TM ---

Re: JK 1.2.29-dev Available for testing

2010-02-17 Thread Mladen Turk
On 02/11/2010 12:15 PM, Mladen Turk wrote: Test snapshot for 1.2.29 is available at http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/ So far no comments, so I suppose everything works like a charm. Since we have postponed this release mostly because core developers are busy bees for a

[ANN] Apache Tomcat Native 1.1.20 released

2010-02-17 Thread Mladen Turk
The Apache Tomcat team announces the immediate availability of Apache Tomcat Native 1.1.20 stable. This release includes a fix for JVM crash on Tomcat shutdown. Please refer to the change log for the list of changes: http://tomcat.apache.org/native-doc/miscellaneous/changelog.html Downloads: htt

Re: jk/cluster - intelligent systems load

2010-02-17 Thread Mladen Turk
On 02/16/2010 06:57 PM, Costin Manolache wrote: I think the main driver for replacing ajp is the 2-directional protocols - and if we replace it, why invent a new protocol and not just adopt SPDY, which has all we need. Totally agree. Both JK and AJP originate from days when the single server

[RESULTS] Was: [VOTE] Release Apache Tomcat Native 1.1.20

2010-02-16 Thread Mladen Turk
We have collected 4 binding votes, so I'll proceed with the release. Apache Tomcat Native 1.1.20 is: [X] Stable - no major issues, no regressions [ ] Beta - at least one significant issue -- tell us what it is [ ] Alpha - multiple significant issues -- tell us what they are Regards -- ^TM

Re: [VOTE] Release Apache Tomcat Native 1.1.20

2010-02-16 Thread Mladen Turk
On 02/17/2010 05:12 AM, Konstantin Kolinko wrote: 2010/2/10 Mladen Turk: Apache Tomcat Native 1.1.20 is: [x] Stable - no major issues, no regressions Tested win32 binaries only. Minor: *.md5 and *.sha1 files should have " *" between checksum and filename, because those files

Re: jk/cluster - intelligent systems load

2010-02-16 Thread Mladen Turk
On 02/16/2010 10:21 AM, Mark Thomas wrote: On 16/02/2010 09:08, Mladen Turk wrote: On 02/16/2010 09:56 AM, Mark Thomas wrote: The other thing it potentially allows is the cluster to tell the proxy about which nodes are in the cluster, allowing a more dynamic configuration. Not sure I'd wa

Re: jk/cluster - intelligent systems load

2010-02-16 Thread Mladen Turk
On 02/16/2010 09:56 AM, Mark Thomas wrote: I don't see why the current set of valid cluster nodes could not be passed back via a header. Exactly. That raises the interesting question of if a node goes down, which component will notice first? The proxy or the cluster? With long timeouts in t

Re: jk/cluster - intelligent systems load

2010-02-15 Thread Mladen Turk
On 02/16/2010 12:24 AM, Mark Thomas wrote: On 15/02/2010 21:52, Filip Hanik - Dev Lists wrote: why not just a servlet filter? +1. I was going to suggest the same thing. Why not reusing the clustering code for that. It would allow to pre-redirect the requests without doing the actual ping

Re: [VOTE] Release Apache Tomcat Native 1.1.20

2010-02-15 Thread Mladen Turk
On 02/10/2010 11:19 AM, Mladen Turk wrote: Hi, Ping. Anyone? Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

JK 1.2.29-dev Available for testing

2010-02-11 Thread Mladen Turk
Hi, Test snapshot for 1.2.29 is available at http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/ Sources can be found inside source/jk-1.2.29 directories while the windows binaries are inside: binaries/win32/jk-1.2.29 and binaries/win64/jk-1.2.29 documentation is inside docs/jk-1.2.29 Pleas

Re: JK 1.2.29 Plan

2010-02-10 Thread Mladen Turk
On 02/08/2010 08:32 AM, Rainer Jung wrote: After a couple of heavily loaded weeks, I'll have time to care about it this week. I'll review the changes done by Mladen and will then proceed with the usual snapshot for letting people do some tests before the final release. I guess I'll need 2 or 3 da

Re: JK 1.2.29 Plan

2010-02-10 Thread Mladen Turk
On 02/08/2010 08:32 AM, Rainer Jung wrote: After a couple of heavily loaded weeks, I'll have time to care about it this week. I'll review the changes done by Mladen and will then proceed with the usual snapshot for letting people do some tests before the final release. I guess I'll need 2 or 3 da

[VOTE] Release Apache Tomcat Native 1.1.20

2010-02-10 Thread Mladen Turk
Hi, Native 1.1.20 is available for testing. Compared with 1.1.19 and earlier versions it has a bug fix that prevents crashing JVM on shutdown. If you want to take a look, the final source distribution can be downloaded from: http://tomcat.apache.org/dev/dist/tomcat-connectors/native/source/1.1.2

Re: Enable RAW headers by default in IIS Tomcat connector

2010-02-07 Thread Mladen Turk
On 02/08/2010 08:38 AM, Tim Whittington wrote: There's a USE_RAW_HEADERS define that will force the use of the raw HTTP headers and avoid this problem, so I'd propose that we make that behaviour the default. I agree with having it default, but is it possible to have additional configure option

Tagging Tomcat Native 1.1.20

2010-02-07 Thread Mladen Turk
Hi, We have a nasty bug that crashes the JVM on shutdown cause by Library.terminate call while we are inside Socket.accept The reason for crash is that we reference later in code the memory that was already destroyed with apr_pool_terminate, and can lead to a JVM core. The fix is quite simple (

Re: 6.0.24 service.bat is missing

2010-02-03 Thread Mladen Turk
On 02/03/2010 07:07 PM, Filip Hanik - Dev Lists wrote: and all the .exe files are gone, from the .zip file, this is a pain in the ass, no windows without installer? why the change from .20 to .24? should just be a build update? Like Mark said, they are in the separate .zip files. This is IMHO

Re: [ANN] Apache Tomcat Native 1.1.19 released

2010-01-21 Thread Mladen Turk
On 01/21/2010 10:33 PM, Konstantin Kolinko wrote: To: Tomcat Users List, Tomcat Developers List, annou...@apache.org There is also annou...@tomcat.apache.org mailing list, http://mail-archives.apache.org/mod_mbox/tomcat-announce/ Done. Regards -- ^TM -

Re: [ANN] Apache Tomcat Native 1.1.19 released

2010-01-21 Thread Mladen Turk
I just realized this never went trough announce, sorry folks. Anyhow, better late then newer :) The Apache Tomcat team announces the immediate availability of Apache Tomcat Native 1.1.19 stable. This release include few minor fixes over Tomcat Native 1.1.18. Cheers -- ^TM ---

[ANN] Apache Tomcat Native 1.1.19 released

2010-01-21 Thread Mladen Turk
The Apache Tomcat team announces the immediate availability of Apache Tomcat Native 1.1.19 stable. This release include few minor fixes over Tomcat Native 1.1.18. Please refer to the change log for the list of changes: http://tomcat.apache.org/native-doc/miscellaneous/changelog.html Downloads: h

Re: [VOTE] Release build 6.0.24

2010-01-20 Thread Mladen Turk
On 01/19/2010 03:25 PM, jean-frederic clere wrote: The candidates binaries are available here: http://people.apache.org/~jfclere/tomcat-6/v6.0.24/ According to the release process, the 6.0.24 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable Cheers -- ^TM -

Re: svn commit: r899395 - /tomcat/trunk/dist.xml

2010-01-15 Thread Mladen Turk
On 01/15/2010 05:21 PM, Rainer Jung wrote: Also the tar produced by ant doesn't look at all like the one produced by gtar. Think the problem is that we should add all files at once during the build since it looks the tar has multiple header sections or something. I never had problems extracti

Re: svn commit: r899395 - /tomcat/trunk/dist.xml

2010-01-15 Thread Mladen Turk
On 01/15/2010 04:41 PM, Mark Thomas wrote: On 15/01/2010 15:13, Mladen Turk wrote: On 01/15/2010 03:41 PM, Rainer Jung wrote: On 14.01.2010 21:21, ma...@apache.org wrote: I'd prefer keep the package-zip with CRLF (and ensure CRLF in package-deployer-zip too). Just to update.

Re: svn commit: r899395 - /tomcat/trunk/dist.xml

2010-01-15 Thread Mladen Turk
On 01/15/2010 03:41 PM, Rainer Jung wrote: On 14.01.2010 21:21, ma...@apache.org wrote: I'd prefer keep the package-zip with CRLF (and ensure CRLF in package-deployer-zip too). Just to update. Since beginning of time httpd has x.x-win32-src.zip We could have something like that as well instea

Re: svn commit: r899395 - /tomcat/trunk/dist.xml

2010-01-15 Thread Mladen Turk
On 01/15/2010 03:41 PM, Rainer Jung wrote: On 14.01.2010 21:21, ma...@apache.org wrote: Author: markt Date: Thu Jan 14 20:21:23 2010 New Revision: 899395 URL: http://svn.apache.org/viewvc?rev=899395&view=rev Log: zip is for non-windows platforms Hmmm, really? Until recently we didn't have th

Re: [VOTE] Release build 6.0.23

2010-01-14 Thread Mladen Turk
On 01/15/2010 08:22 AM, jean-frederic clere wrote: We have to fix the TCK failures, We shouldn't release some things which is not TCK compliant. +1 Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: tagging 6.0.23

2010-01-13 Thread Mladen Turk
On 01/13/2010 10:09 AM, jean-frederic clere wrote: Hi, I plan to tag 6.0.23 tomorrow lunch time (~13h00 my time). Third luck ;) Please complain if that is not ok. +1 Cheers -- ^TM - To unsubscribe, e-mail: dev-unsubsc

Re: [ANN] New committer: Tim Whittington

2010-01-11 Thread Mladen Turk
On 01/11/2010 08:47 AM, Rainer Jung wrote: On behalf of the Tomcat committers I am pleased to announce that Tim Whittington has been voted in as a new Tomcat committer. Please join me in welcoming him. Welcome Tim! Really glad you've been elected as a committer. Regards -- ^TM -

[RESULT] [VOTE] Release Apache Tomcat Native 1.1.19

2010-01-08 Thread Mladen Turk
On 01/05/2010 03:50 PM, Mladen Turk wrote: Apache Tomcat Native 1.1.19 is: [X] Stable - no major issues, no regressions [ ] Beta - at least one significant issue -- tell us what it is [ ] Alpha - multiple significant issues -- tell us what they are OK. We have 4 binding +1 votes. I&#x

[REMIND] Re: [VOTE] Release Apache Tomcat Native 1.1.19

2010-01-07 Thread Mladen Turk
Apache Tomcat Native 1.1.19 is: I know it's a pickle season, and you guys are all busy digesting Christmas and New Year eve's meals, but can I have some votes here :) The difference between released 1.1.18 is trivial, like explained in the proposal, so you'll be voting on package rather then

Re: [PROPOSAL] Log rotation in Tomcat Connector

2010-01-07 Thread Mladen Turk
On 01/07/2010 10:49 AM, Tim Whittington wrote: That looks better - will incorporate that. Not sure why are you using ftell_nolock We already have a problem with ISS logging because multiple processes (IIS 6+) can write to a single log file. On the configuration I went for two properties wit

Re: [PROPOSAL] Log rotation in Tomcat Connector

2010-01-07 Thread Mladen Turk
On 01/07/2010 09:56 AM, Tim Whittington wrote: I've attached the initial implementation, along with a docs patch, to an issue in Bugzilla. https://issues.apache.org/bugzilla/show_bug.cgi?id=48501 I managed to track down the crashing - I was referencing a jk_file_logger_t that got deallocated w

Re: [PROPOSAL] Log rotation in Tomcat Connector

2010-01-06 Thread Mladen Turk
On 01/06/2010 03:28 AM, Tim Whittington wrote: The downside of the rotatelogs approach is that it's not easy to do log pruning (since the filenames are based on the time the log rotates, rather than some kind of backup suffix scheme), so I may do nothing about that for now - the best I could

Re: JK 1.2.29 Plan

2010-01-06 Thread Mladen Turk
+1 I've done majority of planned fixes. Let's tag and then play with IIS rotatelogs. BTW, the IIS logging should be fixed now (compiling with commode.obj that forces a real flush on fflush) On 01/06/2010 11:07 AM, Rainer Jung wrote: Any objections to the following plan about JK 1.2.29? - 15.

Re: [VOTE] Release Apache Tomcat Native 1.1.19

2010-01-05 Thread Mladen Turk
On 01/06/2010 01:21 AM, Konstantin Kolinko wrote: 2010/1/5 Mladen Turk: Hi, Native 1.1.19 is available for testing. Compared with 1.1.18 It has minor versioning fix and allows building against OpenSSL 1.0 (well Rainer beat me before the tag :) If you want to take a look, the final source

[VOTE] Release Apache Tomcat Native 1.1.19

2010-01-05 Thread Mladen Turk
Hi, Native 1.1.19 is available for testing. Compared with 1.1.18 It has minor versioning fix and allows building against OpenSSL 1.0 (well Rainer beat me before the tag :) If you want to take a look, the final source distribution can be downloaded from: http://tomcat.apache.org/dev/dist/tomcat-

Re: svn commit: r895998 - /tomcat/native/branches/1.1.x/jnirelease.sh

2010-01-05 Thread Mladen Turk
On 01/05/2010 01:34 PM, Rainer Jung wrote: Hi Mladen, I seem to remember that the fix line ends perl script is part of the tcnative repos. Done. After second thought the perl is more likely to be present then unix2dos. Regards -- ^TM

Re: svn commit: r895998 - /tomcat/native/branches/1.1.x/jnirelease.sh

2010-01-05 Thread Mladen Turk
On 01/05/2010 01:34 PM, Rainer Jung wrote: Hi Mladen, I seem to remember that the fix line ends perl script is part of the tcnative repos. Which requires perl, so chicken and egg problem again. Probably could be used if the unix2dos is not found and perl exists. Regards -- ^TM

Re: svn commit: r895984 - /tomcat/native/trunk/native/build/tcnative.m4

2010-01-05 Thread Mladen Turk
On 01/05/2010 11:57 AM, rj...@apache.org wrote: Author: rjung Get rid of nested version test by formatting version number as one big decimal. + decimal_apr_version=`printf %02d%02d%03d ${1} ${2} ${3}` + if test "${decimal_apr_version}" -lt "0101003"; then You should not quote the arithmetic

Re: svn commit: r895700 - /tomcat/native/trunk/native/build/tcnative.m4

2010-01-05 Thread Mladen Turk
On 01/05/2010 11:23 AM, Konstantin Kolinko wrote: 2010/1/5 Rainer Jung: Konstantin: JFC is right, it was meant to also check against the third part of the minimum apr version "1 . 3 . 3". By the way: you should check the third number only if the second one is equal to "3". The simplest wo

Tomcat Native 1.1.19 pre-release

2010-01-05 Thread Mladen Turk
Hi, I've build the 1.1.19 pre-release http://people.apache.org/~mturk/native/ It is build from 1.1.x branch using the revision 859968 If no one finds any problems with that, I'll tag the 1.1.19 in few hours and create a full release with vote proposal. Regards -- ^TM

Re: [tcnative] slight apr and openssl version confusion

2010-01-05 Thread Mladen Turk
On 01/05/2010 10:59 AM, Rainer Jung wrote: On 05.01.2010 10:04, Mladen Turk wrote: On 01/05/2010 09:11 AM, jean-frederic clere wrote: I think the file native/srclib/VERSIONS should be created by configure and doesn't need to be in repository. This file is more like a README. It says

Re: [tcnative] slight apr and openssl version confusion

2010-01-05 Thread Mladen Turk
On 01/05/2010 09:11 AM, jean-frederic clere wrote: I think the file native/srclib/VERSIONS should be created by configure and doesn't need to be in repository. This file is more like a README. It says which version is recommended/required for the builds. Regards -- ^TM -

Re: T&R Tomcat Native 1.1.19

2010-01-04 Thread Mladen Turk
On 01/04/2010 03:59 PM, Rainer Jung wrote: Should we update the recommended version in AprLifecycleListener to 19? At the moment we have recommended=17 and required=17. This should be recommended=18 and required=17 since the .18 contains the SSL MITM fixes. Required should stay at 17 cause it

Re: T&R Tomcat Native 1.1.19

2010-01-04 Thread Mladen Turk
On 01/04/2010 04:21 PM, Konstantin Kolinko wrote: The compiled "tcnative-.dll" DLLs on http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.18/binaries/win(32|64) all show "1.1.18.0" on the Version tab in the File Properties dialog in Windows Explorer. The same with the ones in 6.0.2

Re: T&R Tomcat Native 1.1.19

2010-01-04 Thread Mladen Turk
On 01/04/2010 02:10 PM, Henri Gomez wrote: It's not the case in the OS/X version Nope. the windows .rc file wasn't updated before 1.1.18 tag, so when you compile a .dll and check it's resource version, it reports 1.1.16 This can be a problem with some third party install tools that depend on

T&R Tomcat Native 1.1.19

2010-01-04 Thread Mladen Turk
Hi, Version 1.1.18 wasn't properly tagged, so it carries the 1.1.16 version in the windows binary builds (only when you check the .dll version itself) It's a minor issue already fixed in the SVN, so before releasing new Tomcat I'd like we have the native release clean. I'll make a tag and fixed

Re: [VOTE] Release build 6.0.21 (try 2)

2009-12-23 Thread Mladen Turk
On 12/23/2009 11:59 AM, Rainer Jung wrote: So I suggest we try that for TC 7 and find out how to do that in a good way (or not) before we try with 6.0. Let's stick to the existing process for 6.0 and do the experiments with 7. We can easily make a script similar to the one we have for mod_jk

Re: svn commit: r892800 - in /tomcat/jk/trunk: native/common/jk_status.c xdocs/miscellaneous/changelog.xml

2009-12-23 Thread Mladen Turk
On 12/23/2009 08:50 AM, Konstantin Kolinko wrote: 2009/12/21: Author: mturk Date: Mon Dec 21 12:39:29 2009 New Revision: 892800 URL: http://svn.apache.org/viewvc?rev=892800&view=rev Log: Fix #48305. Skip if property ends with .secret Modified: tomcat/jk/trunk/native/common/jk_status.c

Re: [VOTE] Release build 6.0.21 (try 2)

2009-12-22 Thread Mladen Turk
On 12/23/2009 02:12 AM, Rainer Jung wrote: release candidates (marking the files with rcX or dev or whatever) the only safe thing would be to burn version number 6.0.21 and go for 6.0.22. +1 Let's make a proper release. I'd suggest to make a release on a specific SVN revision instead tag. Th

Re: svn commit: r893253 - in /tomcat/jk/trunk/native/common: jk_ajp_common.c jk_shm.h jk_status.c

2009-12-22 Thread Mladen Turk
On 12/22/2009 08:28 PM, Rainer Jung wrote: On 22.12.2009 20:05, Mladen Turk wrote: I have a tendency to not put to much new stuff in 29 because it would be nice to have a stable release with only bug fixes. Adding stuff to the watchdog might be nice for a not to far 30 release? Of course

Re: svn commit: r893253 - in /tomcat/jk/trunk/native/common: jk_ajp_common.c jk_shm.h jk_status.c

2009-12-22 Thread Mladen Turk
On 12/22/2009 07:18 PM, Rainer Jung wrote: On 22.12.2009 19:09, mt...@apache.org wrote: Something missing and hard to guess. The total number of currently opened connection per worker Cool! Even more cool option would be the mechanism to close all those connection from status. Possible only

Re: svn commit: r893253 - in /tomcat/jk/trunk/native/common: jk_ajp_common.c jk_shm.h jk_status.c

2009-12-22 Thread Mladen Turk
On 12/22/2009 07:18 PM, Rainer Jung wrote: On 22.12.2009 19:09, mt...@apache.org wrote: Something missing and hard to guess. The total number of currently opened connection per worker Cool! Right, It's actually amazing ab -c 10 -n 1000 ... with event mpm opens 24+ connections Regards -- ^

Re: [VOTE] Release build 6.0.21

2009-12-22 Thread Mladen Turk
On 12/22/2009 10:11 AM, jean-frederic clere wrote: On 12/22/2009 09:28 AM, Henri Gomez wrote: Up till now we always had tcnative-1.dll not libtcnative-1.dll so it's just broken build comming from private builds, because there is no 1.1.18 binaries in w.a.o/dist/ Meaning: 1. Wrong tcnative 2. Bui

Re: [VOTE] Release build 6.0.21

2009-12-21 Thread Mladen Turk
On 12/22/2009 08:15 AM, William A. Rowe Jr. wrote: Mladen Turk wrote: On 12/21/2009 11:39 PM, jean-frederic clere wrote: The candidates binaries are available here: http://people.apache.org/~jfclere/tomcat-6/v6.0.21/ According to the release process, the 6.0.21 tag is: [X] Broken [ ] Alpha

Re: [VOTE] Release build 6.0.21

2009-12-21 Thread Mladen Turk
On 12/21/2009 11:39 PM, jean-frederic clere wrote: The candidates binaries are available here: http://people.apache.org/~jfclere/tomcat-6/v6.0.21/ According to the release process, the 6.0.21 tag is: [X] Broken [ ] Alpha [ ] Beta [ ] Stable tcnative-1.dll in the zips is build with dynamically

Re: svn commit: r892803 - in /tomcat/jk/trunk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2009-12-21 Thread Mladen Turk
On 12/21/2009 07:54 PM, Rainer Jung wrote: On 21.12.2009 13:55, mt...@apache.org wrote: Fix #48276. Just like with setting port to 0, if the resolve fails, mark the worker as disabled If we want to support pre allocation of workers with names not yet reolvable I'm fine with a global setting t

Re: running tomcat problem JNI native lib 1.1.18 + tomcat 6.0.20 + Solaris 5.1

2009-12-17 Thread Mladen Turk
On 12/17/2009 05:23 PM, Semyon wrote: Hello, all I'm building native library for: Tomcat 6.0.20 JNI 1.1.18 APR 1.4.1 OS: Solaris 5.10 compiler: gcc -m64 Library was built ok. When I begin starting tomcat I have such logs: Does anybody know about such problem? Probably because you are usin

Re: svn commit: r890856 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-12-15 Thread Mladen Turk
On 12/15/2009 05:13 PM, j...@apache.org wrote: Some votes... those with>=3 I will commit today or so Shouldn't that be a responsibility of the proposer? Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

Re: svn commit: r890738 - /tomcat/jk/trunk/native/common/jk_util.c

2009-12-15 Thread Mladen Turk
On 12/15/2009 02:12 PM, Rainer Jung wrote: Why is that better? Uses significant bits out of pthread pointer. I'm concerned, that it breaks thread id's as logged by other components. For instance on Solaris I think the thread id logged by mod_jk is the same as by httpd when using %{tid}P in t

<    1   2   3   4   5   6   7   8   9   10   >