[GitHub] tomcat issue #125: Provide port offset functionality (BZ-61171)

2018-10-29 Thread m-czernek
Github user m-czernek commented on the issue: https://github.com/apache/tomcat/pull/125 @markt-asf I'll check your review into a lot more detail later, possibly tonight, but at this moment: - You set `portOffset` on Server - All connectors are offset

[GitHub] tomcat pull request #125: Provide port offset functionality (BZ-61171)

2018-10-07 Thread m-czernek
GitHub user m-czernek opened a pull request: https://github.com/apache/tomcat/pull/125 Provide port offset functionality (BZ-61171) This PR resolves [BZ61171](https://bz.apache.org/bugzilla/show_bug.cgi?id=61171) and adds the port offset functionality. The implementation

[GitHub] tomcat pull request #117: Enhance the CATALINA_BASE documentation

2018-08-23 Thread m-czernek
Github user m-czernek commented on a diff in the pull request: https://github.com/apache/tomcat/pull/117#discussion_r212238007 --- Diff: webapps/docs/introduction.xml --- @@ -89,6 +80,122 @@ same as $CATALINA_HOME. + + Throughout the documentation

[GitHub] tomcat pull request #117: Enhance the CATALINA_BASE documentation

2018-08-13 Thread m-czernek
Github user m-czernek commented on a diff in the pull request: https://github.com/apache/tomcat/pull/117#discussion_r209548456 --- Diff: webapps/docs/introduction.xml --- @@ -89,6 +80,122 @@ same as $CATALINA_HOME. + + Throughout the documentation

[GitHub] tomcat pull request #117: Enhance the CATALINA_BASE documentation

2018-08-13 Thread m-czernek
Github user m-czernek commented on a diff in the pull request: https://github.com/apache/tomcat/pull/117#discussion_r209532683 --- Diff: webapps/docs/introduction.xml --- @@ -89,6 +80,122 @@ same as $CATALINA_HOME. + + Throughout the documentation

[GitHub] tomcat pull request #117: Enhance the CATALINA_BASE documentation

2018-08-02 Thread m-czernek
GitHub user m-czernek opened a pull request: https://github.com/apache/tomcat/pull/117 Enhance the CATALINA_BASE documentation As per the mailing list discussion, we'd like to enhance the catalina.home and catalina.base documentation so that it is present in the main html

[GitHub] tomcat issue #98: Fix for BZ62048

2018-06-18 Thread m-czernek
Github user m-czernek commented on the issue: https://github.com/apache/tomcat/pull/98 I see this is still open. I'm closing this PR, refactor, and re-open at another time. In the meantime, please follow discussion in https://bz.apache.org/bugzilla/show_bug.cgi?id=62048 . Thank you

[GitHub] tomcat pull request #98: Fix for BZ62048

2018-06-18 Thread m-czernek
Github user m-czernek closed the pull request at: https://github.com/apache/tomcat/pull/98 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #98: Fix for BZ62048

2018-02-09 Thread m-czernek
GitHub user m-czernek opened a pull request: https://github.com/apache/tomcat/pull/98 Fix for BZ62048 Hi, providing a small workaround for https://bz.apache.org/bugzilla/show_bug.cgi?id=62048 as suggested by Christopher in the BZ. I tried to make the logout link

[GitHub] tomcat pull request #97: Bz48672

2018-02-07 Thread m-czernek
GitHub user m-czernek opened a pull request: https://github.com/apache/tomcat/pull/97 Bz48672 Providing documentation patch for the https://bz.apache.org/bugzilla/show_bug.cgi?id=48672 bugzilla (and removing the TODO from the HTML interface). Feel free to suggest any