Github user rmaucher commented on the issue:
https://github.com/apache/tomcat/pull/134
Correct, this doesn't give the right info, I thought it did. Still not that
convinced though, you don't see that kind of timestamp often (if at all), right
Github user rmaucher commented on the issue:
https://github.com/apache/tomcat/pull/134
I'm not convinced by the use case, so I don't see why this one adds
something useful. Right-click + pageinfo wouldn't show the needed info
Github user rmaucher commented on the issue:
https://github.com/apache/tomcat/pull/125
Ok, so I'm guilty for all the system properties in Tomcat ... Sorry. So
now, it's not good anymore. System properties are still fine for end users, but
only by using ${...} property replacement
Github user rmaucher commented on the issue:
https://github.com/apache/tomcat/pull/126
Ok. But this portion of the code in the connectors is asynchronous, so a
throttling solution based on Thread.sleep isn't good enough for inclusion. A
throttling feature, by itself, would
Github user rmaucher commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/126#discussion_r224803205
--- Diff: java/org/apache/tomcat/util/net/RateLimiter.java ---
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user rmaucher commented on the issue:
https://github.com/apache/tomcat/pull/126
-1 from me. This is a bad combination of too big and too specific to be
included IMO. Also, and more importantly, it will replace a non blocking /
async IO feature with something that uses threads
Github user rmaucher commented on the issue:
https://github.com/apache/tomcat/pull/84
Abstraction is ok, more importantly limiting the number of impls will make
it much much easier to maintain.
---
-
To unsubscribe
Github user rmaucher commented on the issue:
https://github.com/apache/tomcat/pull/73
Well, it looks ok to me overall, so I'll add a bit of javadoc and merge it.
Any issue with backporting it ?
---
-
To unsubscribe
