Re: [PR] Csrf filter improvements [tomcat]

2023-12-20 Thread via GitHub
michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1432402971 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
markt-asf commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431736198 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431641166 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431639832 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431618064 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431615348 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431612056 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-19 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431610887 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-18 Thread via GitHub
michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1430461949 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-18 Thread via GitHub
michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1430459964 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-18 Thread via GitHub
markt-asf commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1430459910 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-18 Thread via GitHub
isapir commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1430457497 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase { private

Re: [PR] Csrf filter improvements [tomcat]

2023-12-18 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1430451465 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

2023-12-18 Thread via GitHub
ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1430450663 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] [WIP] initial implementation of webresource based on path API [tomcat]

2023-12-18 Thread via GitHub
KoteswararaoGundapaneni commented on PR #630: URL: https://github.com/apache/tomcat/pull/630#issuecomment-1860268262 Any valid update regarding the work status of this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Csrf filter improvements [tomcat]

2023-12-16 Thread via GitHub
michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1428761992 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] [WIP] initial implementation of webresource based on path API [tomcat]

2023-12-15 Thread via GitHub
KoteswararaoGundapaneni commented on PR #630: URL: https://github.com/apache/tomcat/pull/630#issuecomment-1858736665 Am ready to take part in this based on the work allocated as per the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Csrf filter improvements [tomcat]

2023-12-15 Thread via GitHub
ChristopherSchultz commented on PR #681: URL: https://github.com/apache/tomcat/pull/681#issuecomment-1858319793 Commit [e2f78ec](https://github.com/apache/tomcat/pull/681/commits/e2f78eca0c7626303e5e50f1f033770b466f1755) adds nonce-check skipping to the URLs that won't get nonces added to

Re: [PR] Csrf filter improvements [tomcat]

2023-12-15 Thread via GitHub
ChristopherSchultz commented on PR #681: URL: https://github.com/apache/tomcat/pull/681#issuecomment-1858296301 My initial testing indicates that caching is working as expected with these changes. -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] Csrf filter improvements [tomcat]

2023-12-15 Thread via GitHub
ChristopherSchultz opened a new pull request, #681: URL: https://github.com/apache/tomcat/pull/681 Please see https://lists.apache.org/thread/47syblyghh3tromyf6bkvl8q14w70f3x for the initial conversation. I see some potential improvements for the CSRF prevention filter that will be

Re: [PR] Dir redirect use301 [tomcat]

2023-12-15 Thread via GitHub
markt-asf commented on PR #524: URL: https://github.com/apache/tomcat/pull/524#issuecomment-1857955904 A variation of this has been applied to 11.0.x as Servlet 6.1 has added additional methods to allow the status code to be specified in a sendRedirect() call. -- This is an automated

Re: [I] How can I know the migrated jar is actually "touched" or not after running MigrationCLI [tomcat-jakartaee-migration]

2023-12-11 Thread via GitHub
zoumuzou commented on issue #51: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/51#issuecomment-1851193071 OK, thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Bump org.apache.tomcat:tomcat-catalina from 10.1.15 to 10.1.16 in /modules/owb [tomcat]

2023-12-10 Thread via GitHub
dependabot[bot] opened a new pull request, #680: URL: https://github.com/apache/tomcat/pull/680 Bumps org.apache.tomcat:tomcat-catalina from 10.1.15 to 10.1.16. [![Dependabot compatibility

Re: [PR] PDS-4683 upgrade tomcat for security reasons [tomcat-maven-plugin]

2023-12-04 Thread via GitHub
glendagonzales closed pull request #42: PDS-4683 upgrade tomcat for security reasons URL: https://github.com/apache/tomcat-maven-plugin/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Update README.md [tomcat]

2023-11-29 Thread via GitHub
aooohan closed pull request #679: Update README.md URL: https://github.com/apache/tomcat/pull/679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Update README.md [tomcat]

2023-11-29 Thread via GitHub
BTrees opened a new pull request, #679: URL: https://github.com/apache/tomcat/pull/679 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump derby from 10.4.2.0 to 10.14.2.0 in /standard-test [tomcat-taglibs-standard]

2023-11-20 Thread via GitHub
dependabot[bot] commented on PR #3: URL: https://github.com/apache/tomcat-taglibs-standard/pull/3#issuecomment-1819973270 Superseded by #9. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump derby from 10.4.2.0 to 10.14.2.0 in /standard-test [tomcat-taglibs-standard]

2023-11-20 Thread via GitHub
dependabot[bot] closed pull request #3: Bump derby from 10.4.2.0 to 10.14.2.0 in /standard-test URL: https://github.com/apache/tomcat-taglibs-standard/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] Bump org.apache.derby:derby from 10.4.2.0 to 10.17.1.0 in /standard-test [tomcat-taglibs-standard]

2023-11-20 Thread via GitHub
dependabot[bot] opened a new pull request, #9: URL: https://github.com/apache/tomcat-taglibs-standard/pull/9 Bumps org.apache.derby:derby from 10.4.2.0 to 10.17.1.0. [![Dependabot compatibility

Re: [PR] Bump derby from 10.4.2.0 to 10.14.2.0 in /standard-examples [tomcat-taglibs-standard]

2023-11-20 Thread via GitHub
dependabot[bot] closed pull request #2: Bump derby from 10.4.2.0 to 10.14.2.0 in /standard-examples URL: https://github.com/apache/tomcat-taglibs-standard/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Bump derby from 10.4.2.0 to 10.14.2.0 in /standard-examples [tomcat-taglibs-standard]

2023-11-20 Thread via GitHub
dependabot[bot] commented on PR #2: URL: https://github.com/apache/tomcat-taglibs-standard/pull/2#issuecomment-1819973208 Superseded by #8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Bump org.apache.derby:derby from 10.4.2.0 to 10.17.1.0 in /standard-examples [tomcat-taglibs-standard]

2023-11-20 Thread via GitHub
dependabot[bot] opened a new pull request, #8: URL: https://github.com/apache/tomcat-taglibs-standard/pull/8 Bumps org.apache.derby:derby from 10.4.2.0 to 10.17.1.0. [![Dependabot compatibility

Re: [PR] Making sure that stop is not "blocked" by the check() in HostConfig [tomcat]

2023-11-20 Thread via GitHub
jfclere closed pull request #641: Making sure that stop is not "blocked" by the check() in HostConfig URL: https://github.com/apache/tomcat/pull/641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Making sure that stop is not "blocked" by the check() in HostConfig [tomcat]

2023-11-20 Thread via GitHub
jfclere commented on PR #641: URL: https://github.com/apache/tomcat/pull/641#issuecomment-1819080600 See https://github.com/apache/tomcat/commit/dce1fc833b5192ec0ccee7d4120a050cee5da8de the exceptions are gone but now the stop() is blocked by the check(String name) but the fix is easy

Re: [PR] Add support for RequestBoudaries in DBCP [tomcat]

2023-11-19 Thread via GitHub
aooohan closed pull request #678: Add support for RequestBoudaries in DBCP URL: https://github.com/apache/tomcat/pull/678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add support for RequestBoudaries in DBCP [tomcat]

2023-11-19 Thread via GitHub
aooohan commented on PR #678: URL: https://github.com/apache/tomcat/pull/678#issuecomment-1818083370 This is an internal fork project which not belong to Tomcat. You should move this change to [Apache Commons DBCP](https://github.com/apache/commons-dbcp). -- This is an automated message

Re: [PR] Add support for RequestBoudaries in DBCP [tomcat]

2023-11-17 Thread via GitHub
KoteswararaoGundapaneni commented on PR #678: URL: https://github.com/apache/tomcat/pull/678#issuecomment-1817359611 still there is no presence of beginRequest in our code when i checked in dbcp -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Add support for RequestBoudaries in DBCP [tomcat]

2023-11-17 Thread via GitHub
KoteswararaoGundapaneni commented on PR #678: URL: https://github.com/apache/tomcat/pull/678#issuecomment-1817334170 Hi Meedbek Please allow to work on this for offline to assist -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] Add support for RequestBoudaries in DBCP [tomcat]

2023-11-17 Thread via GitHub
meedbek opened a new pull request, #678: URL: https://github.com/apache/tomcat/pull/678 JDBC 4.3 introduced `beginRequest` and `endRequest` methods for connection pools which are called to mark request boundaries. `beginRequest` should be called when borrowing a connection and

Re: [PR] Added option to use custom SSLContext [tomcat]

2023-11-17 Thread via GitHub
KoteswararaoGundapaneni commented on PR #673: URL: https://github.com/apache/tomcat/pull/673#issuecomment-1816164863 Requesting to panel the change request to be considering and request has been taken care by the process that's done above -- This is an automated message from the Apache

Re: [PR] #49 support ear file type as archive file [tomcat-jakartaee-migration]

2023-11-17 Thread via GitHub
markt-asf merged PR #50: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Before closing the database connection, roll back the transaction [tomcat]

2023-11-08 Thread via GitHub
markt-asf commented on PR #667: URL: https://github.com/apache/tomcat/pull/667#issuecomment-1801356054 Closing since behaviour is intentionally configurable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Before closing the database connection, roll back the transaction [tomcat]

2023-11-08 Thread via GitHub
markt-asf closed pull request #667: Before closing the database connection, roll back the transaction URL: https://github.com/apache/tomcat/pull/667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Added support for JDBC 4.3 beginRequest and endRequest methods. [tomcat]

2023-11-07 Thread via GitHub
fmeheust commented on code in PR #677: URL: https://github.com/apache/tomcat/pull/677#discussion_r1384572235 ## modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java: ## @@ -812,6 +829,28 @@ protected PooledConnection createConnection(long now,

Re: [PR] Added support for JDBC 4.3 beginRequest and endRequest methods. [tomcat]

2023-11-07 Thread via GitHub
fmeheust commented on code in PR #677: URL: https://github.com/apache/tomcat/pull/677#discussion_r1384567373 ## modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/ConnectionBoundariesTest.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Added support for JDBC 4.3 beginRequest and endRequest methods. [tomcat]

2023-11-06 Thread via GitHub
aooohan commented on code in PR #677: URL: https://github.com/apache/tomcat/pull/677#discussion_r1384334368 ## modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/ConnectionBoundariesTest.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[PR] Added support for JDBC 4.3 beginRequest and endRequest methods. [tomcat]

2023-11-06 Thread via GitHub
fmeheust opened a new pull request, #677: URL: https://github.com/apache/tomcat/pull/677 JDBC 4.3 added the methods beginRequest and endRequest to java.sql.Connection. These methods hint the driver of the beginning and completion of a request (independent unit of work). Connection pooling

Re: [PR] Fix explicit chunked encoding specification [tomcat]

2023-11-02 Thread via GitHub
markt-asf commented on PR #676: URL: https://github.com/apache/tomcat/pull/676#issuecomment-1790213186 No, this PR will not be applied. Applications should not be setting the Transfer-Encoding header. Or the Connection header for that matter. If you want to strongly suggest to the

Re: [PR] Fix explicit chunked encoding specification [tomcat]

2023-11-01 Thread via GitHub
w1ida commented on PR #676: URL: https://github.com/apache/tomcat/pull/676#issuecomment-1789983590 > The description for the PR confuses request and response. It appears from the code that this PR relates to the response. > > This PR will not be applied. Whether or not to chunk the

Re: [PR] Fix explicit chunked encoding specification [tomcat]

2023-11-01 Thread via GitHub
markt-asf commented on PR #676: URL: https://github.com/apache/tomcat/pull/676#issuecomment-1788896749 The description for the PR confuses request and response. It appears from the code that this PR relates to the response. This PR will not be applied. Whether or not to chunk the

Re: [PR] Fix explicit chunked encoding specification [tomcat]

2023-11-01 Thread via GitHub
markt-asf closed pull request #676: Fix explicit chunked encoding specification URL: https://github.com/apache/tomcat/pull/676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] Fix explicit chunked encoding specification [tomcat]

2023-11-01 Thread via GitHub
w1ida opened a new pull request, #676: URL: https://github.com/apache/tomcat/pull/676 Summary: This commit fixes a bug in the code related to handling chunked transfer encoding. The original code only handled chunked transfer encoding when http11 was true, entityBody was true, and

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

2023-10-31 Thread via GitHub
michael-o closed pull request #675: BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs URL: https://github.com/apache/tomcat/pull/675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

2023-10-31 Thread via GitHub
michael-o commented on PR #675: URL: https://github.com/apache/tomcat/pull/675#issuecomment-1787001486 Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

2023-10-31 Thread via GitHub
rmaucher commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1377379112 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -56,6 +56,8 @@ import org.apache.tomcat.util.codec.binary.Base64; import

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

2023-10-31 Thread via GitHub
aooohan commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1377275894 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) { } return bytes;

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

2023-10-31 Thread via GitHub
michael-o commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1377274168 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) { } return bytes;

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

2023-10-31 Thread via GitHub
aooohan commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1377262792 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) { } return bytes;

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

2023-10-31 Thread via GitHub
michael-o commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1377209435 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) { } return bytes;

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

2023-10-31 Thread via GitHub
michael-o commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1377209435 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) { } return bytes;

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

2023-10-31 Thread via GitHub
aooohan commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1376990387 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) { } return bytes;

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

2023-10-31 Thread via GitHub
aooohan commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1376990387 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) { } return bytes;

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

2023-10-30 Thread via GitHub
aooohan commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1376990387 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) { } return bytes;

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

2023-10-30 Thread via GitHub
michael-o commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1376474963 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -56,6 +56,8 @@ import org.apache.tomcat.util.codec.binary.Base64; import

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

2023-10-30 Thread via GitHub
michael-o commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1376474963 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -56,6 +56,8 @@ import org.apache.tomcat.util.codec.binary.Base64; import

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

2023-10-30 Thread via GitHub
ChristopherSchultz commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1376435849 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -56,6 +56,8 @@ import org.apache.tomcat.util.codec.binary.Base64; import

[PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

2023-10-30 Thread via GitHub
michael-o opened a new pull request, #675: URL: https://github.com/apache/tomcat/pull/675 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] BZ 67818: SSL#setVerify()/SSLContext#setVerify() silently set undocum… [tomcat-native]

2023-10-30 Thread via GitHub
michael-o closed pull request #22: BZ 67818: SSL#setVerify()/SSLContext#setVerify() silently set undocum… URL: https://github.com/apache/tomcat-native/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] BZ 67818: SSL#setVerify()/SSLContext#setVerify() silently set undocum… [tomcat-native]

2023-10-30 Thread via GitHub
michael-o commented on PR #22: URL: https://github.com/apache/tomcat-native/pull/22#issuecomment-1784891589 Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fix NioChannel's toString() throwing NullPointerException in some cases [tomcat]

2023-10-25 Thread via GitHub
chenggwang commented on PR #671: URL: https://github.com/apache/tomcat/pull/671#issuecomment-1780424297 > Thanks for the PR. Thanks for all the REVIEWS! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Add support for CIDR notation in `RemoteIpFilter` [tomcat]

2023-10-25 Thread via GitHub
aooohan commented on PR #632: URL: https://github.com/apache/tomcat/pull/632#issuecomment-1780327810 Hi, If you want this PR to merge smoothly, please modify this change according to markt‘s comment. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Fix NioChannel's toString() throwing NullPointerException in some cases [tomcat]

2023-10-25 Thread via GitHub
aooohan commented on PR #671: URL: https://github.com/apache/tomcat/pull/671#issuecomment-1780324734 Thanks for the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fix NioChannel's toString() throwing NullPointerException in some cases [tomcat]

2023-10-25 Thread via GitHub
aooohan merged PR #671: URL: https://github.com/apache/tomcat/pull/671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Update ssh key [tomcat-maven-plugin]

2023-10-24 Thread via GitHub
umar-sheik closed pull request #41: Update ssh key URL: https://github.com/apache/tomcat-maven-plugin/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Update ssh key [tomcat-maven-plugin]

2023-10-24 Thread via GitHub
umar-sheik opened a new pull request, #41: URL: https://github.com/apache/tomcat-maven-plugin/pull/41 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fix bz67675 [tomcat]

2023-10-24 Thread via GitHub
markt-asf merged PR #674: URL: https://github.com/apache/tomcat/pull/674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Added option to use custom SSLContext [tomcat]

2023-10-24 Thread via GitHub
Hakky54 commented on PR #673: URL: https://github.com/apache/tomcat/pull/673#issuecomment-1777163986 I am not sure whether you would consider to have this option at all. Would you prefer me to close the issue? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Fix bz67675 [tomcat]

2023-10-24 Thread via GitHub
michael-o commented on PR #674: URL: https://github.com/apache/tomcat/pull/674#issuecomment-1776796215 Yes, through shading only to make them private. Looking at the vast amount of code you have written already I bet that ther are also others which would like to use such a PEM to Java

Re: [PR] Fix bz67675 [tomcat]

2023-10-24 Thread via GitHub
markt-asf commented on PR #674: URL: https://github.com/apache/tomcat/pull/674#issuecomment-1776785906 Added a test key using AES128 (test passed without additional code changes). Fixed typo. Removed debug code that wasn't intended to be part of the commit. I might be persuaded to

Re: [PR] Fix bz67675 [tomcat]

2023-10-24 Thread via GitHub
michael-o commented on PR #674: URL: https://github.com/apache/tomcat/pull/674#issuecomment-1776767268 Built from your branch and I can confirm that this works with a selfsigned and one issued by our enterprise CA. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Fix bz67675 [tomcat]

2023-10-23 Thread via GitHub
michael-o commented on PR #674: URL: https://github.com/apache/tomcat/pull/674#issuecomment-1775942678 Thanks for the hard work. I will try this tomorrow/Wednesday! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Fix bz67675 [tomcat]

2023-10-23 Thread via GitHub
michael-o commented on code in PR #674: URL: https://github.com/apache/tomcat/pull/674#discussion_r1369211534 ## test/org/apache/tomcat/util/net/jsse/TestPEMFile.java: ## @@ -118,4 +127,17 @@ private String getPath(String file) throws IOException { return

Re: [PR] Fix bz67675 [tomcat]

2023-10-23 Thread via GitHub
michael-o commented on PR #674: URL: https://github.com/apache/tomcat/pull/674#issuecomment-1775933882 The more ASN.1 I see in Tomcat the more I think is that we should import Kerby ASN.1 at some point in time... -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Fix bz67675 [tomcat]

2023-10-23 Thread via GitHub
michael-o commented on code in PR #674: URL: https://github.com/apache/tomcat/pull/674#discussion_r1369136617 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -64,8 +66,40 @@ public class PEMFile { private static final byte[] OID_EC_PUBLIC_KEY =

Re: [PR] Fix bz67675 [tomcat]

2023-10-23 Thread via GitHub
michael-o commented on PR #674: URL: https://github.com/apache/tomcat/pull/674#issuecomment-1775825928 There is also AES128 with OpenSSL anf should be tried as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-23 Thread via GitHub
michael-o commented on PR #672: URL: https://github.com/apache/tomcat/pull/672#issuecomment-1774954495 Merged into all branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-23 Thread via GitHub
michael-o closed pull request #672: BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile URL: https://github.com/apache/tomcat/pull/672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-20 Thread via GitHub
rmaucher commented on PR #672: URL: https://github.com/apache/tomcat/pull/672#issuecomment-1772689379 Ok, and I'll update the new OpenSSLContext to do things properly (eventually) since it would be better to use a memory BIO rather than a file BIO. -- This is an automated message from

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-20 Thread via GitHub
michael-o commented on PR #672: URL: https://github.com/apache/tomcat/pull/672#issuecomment-1772580776 I'd like to merge this weekend unless there will be objections after my change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Added option to use custom SSLContext [tomcat]

2023-10-20 Thread via GitHub
Hakky54 commented on PR #673: URL: https://github.com/apache/tomcat/pull/673#issuecomment-1772265010 I see indeed clearly that it was not the intention of the developers/maintainers to expose a setter method to set a custom sslcontext which is later on ignored. As it is clearly not a bug

Re: [PR] Added option to use custom SSLContext [tomcat]

2023-10-20 Thread via GitHub
rmaucher commented on PR #673: URL: https://github.com/apache/tomcat/pull/673#issuecomment-1772201584 It doesn't work like that because it was not supposed to. The item that is/was supposed to be configured is the SSLImplementation, which then provides the SSLUtil which will create the

[PR] Added option to use custom SSLContext [tomcat]

2023-10-19 Thread via GitHub
Hakky54 opened a new pull request, #673: URL: https://github.com/apache/tomcat/pull/673 Tomcat supports configuring a custom SSLContext when configuring the `SSLHostConfigCertificate`. However the custom SSLContext gets ignored during the server startup and ssl initialization. A new

Re: [PR] BZ 67818: SSL#setVerify()/SSLContext#setVerify() silently set undocum… [tomcat-native]

2023-10-19 Thread via GitHub
michael-o commented on PR #22: URL: https://github.com/apache/tomcat-native/pull/22#issuecomment-1770439509 > This comes from: [270c9ac](https://github.com/apache/tomcat-native/commit/270c9acf8651bb1cbb4fa884e12a9761c8293938) And in ssl.c it was added in one big commit. I don't know what

Re: [PR] BZ 67818: SSL#setVerify()/SSLContext#setVerify() silently set undocum… [tomcat-native]

2023-10-19 Thread via GitHub
rmaucher commented on PR #22: URL: https://github.com/apache/tomcat-native/pull/22#issuecomment-1770410908 No testsuite failures from this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] BZ 67818: SSL#setVerify()/SSLContext#setVerify() silently set undocum… [tomcat-native]

2023-10-19 Thread via GitHub
rmaucher commented on PR #22: URL: https://github.com/apache/tomcat-native/pull/22#issuecomment-1770378729 This comes from: https://github.com/apache/tomcat-native/commit/270c9acf8651bb1cbb4fa884e12a9761c8293938 And in ssl.c it was added in one big commit. I don't know what the

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-19 Thread via GitHub
rmaucher commented on PR #672: URL: https://github.com/apache/tomcat/pull/672#issuecomment-1770353017 The Java code is a lot simpler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Reinstantiate an updated patch for OpenSSL 1.1.1 on Windows [tomcat-native]

2023-10-19 Thread via GitHub
michael-o closed pull request #21: Reinstantiate an updated patch for OpenSSL 1.1.1 on Windows URL: https://github.com/apache/tomcat-native/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Reinstantiate an updated patch for OpenSSL 1.1.1 on Windows [tomcat-native]

2023-10-19 Thread via GitHub
michael-o commented on PR #21: URL: https://github.com/apache/tomcat-native/pull/21#issuecomment-1770165905 Closing this and will leave the branch for some time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] BZ 67818: SSL#setVerify()/SSLContext#setVerify() silently set undocum… [tomcat-native]

2023-10-18 Thread via GitHub
michael-o opened a new pull request, #22: URL: https://github.com/apache/tomcat-native/pull/22 …ented default verify paths -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] BZ 66670: Add SSLHostConfig#certificateKeyPasswordFile and SSLHostConfig#certificateKeystorePasswordFile [tomcat]

2023-10-18 Thread via GitHub
michael-o commented on PR #672: URL: https://github.com/apache/tomcat/pull/672#issuecomment-1769101843 Guys, I have now changed the code by reading the password file for OpenSSL in Java, instead of C. Please have a look again. -- This is an automated message from the Apache Git Service.

<    1   2   3   4   5   6   7   8   9   10   >