ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1434521612
##
webapps/docs/config/filter.xml:
##
@@ -319,6 +326,34 @@
of java.security.SecureRandom will be used.
+
+A list of URL pattern
michael-o commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1434518590
##
webapps/docs/config/filter.xml:
##
@@ -291,6 +291,13 @@
request. The default value is 403.
+
+A flag to enable or disable enforcement
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1434514917
##
webapps/docs/config/filter.xml:
##
@@ -291,6 +291,13 @@
request. The default value is 403.
+
+A flag to enable or disable en
michael-o commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1434513367
##
webapps/docs/config/filter.xml:
##
@@ -319,6 +326,34 @@
of java.security.SecureRandom will be used.
+
+A list of URL patterns that wi
michael-o commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1434512783
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -198,15 +416,27 @@ protected boolean skipNonceCheck(HttpServletRequest
request) {
String
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1434511388
##
webapps/docs/config/filter.xml:
##
@@ -319,6 +326,34 @@
of java.security.SecureRandom will be used.
+
+A list of URL pattern
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1434510673
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -198,15 +416,27 @@ protected boolean skipNonceCheck(HttpServletRequest
request) {
michael-o commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1433225531
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -198,15 +416,27 @@ protected boolean skipNonceCheck(HttpServletRequest
request) {
String
ChristopherSchultz commented on PR #681:
URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864951885
> Re 4: I think that if one is wise enough to write a RegExp, they could use
"|" to combine several patterns, and do not really need splitting by comma. Or
do you envision a use c
kkolinko commented on PR #681:
URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864889547
Re 8: Whatever is easier.
(Maybe it will be easier to extract some logic into an utility class and
test that utility class. My concern is just that the logic is not trivial, is
complicat
kkolinko commented on PR #681:
URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864873921
Re 4: I think that if one is wise enough to write a RegExp, they could use
"|" to combine several patterns, and do not really need splitting by comma. Or
do you envision a use case, where d
ChristopherSchultz commented on PR #681:
URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864828084
> 1. There are case-insensitive file systems out there... I wonder whether
those default extensions should be treated case-insensitively. (If one is
serving a web site from an USB
kkolinko commented on PR #681:
URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864808958
1. There are case-insensitive file systems out there... I wonder whether
those default extensions should be treated case-insensitively. (If one is
serving a web site from an USB stick or a
michael-o commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1432909931
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
private
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1432880460
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1432856054
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1432853641
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
michael-o commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1432402971
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
private
markt-asf commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1431736198
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
private
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1431641166
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1431639832
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1431618064
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1431615348
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1431612056
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1431610887
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
michael-o commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1430461949
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
private
michael-o commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1430459964
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
private
markt-asf commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1430459910
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
private
isapir commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1430457497
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
private St
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1430451465
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1430450663
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
KoteswararaoGundapaneni commented on PR #630:
URL: https://github.com/apache/tomcat/pull/630#issuecomment-1860268262
Any valid update regarding the work status of this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
michael-o commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1428761992
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
private
KoteswararaoGundapaneni commented on PR #630:
URL: https://github.com/apache/tomcat/pull/630#issuecomment-1858736665
Am ready to take part in this based on the work allocated as per the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ChristopherSchultz commented on PR #681:
URL: https://github.com/apache/tomcat/pull/681#issuecomment-1858319793
Commit
[e2f78ec](https://github.com/apache/tomcat/pull/681/commits/e2f78eca0c7626303e5e50f1f033770b466f1755)
adds nonce-check skipping to the URLs that won't get nonces added to t
ChristopherSchultz commented on PR #681:
URL: https://github.com/apache/tomcat/pull/681#issuecomment-1858296301
My initial testing indicates that caching is working as expected with these
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
ChristopherSchultz opened a new pull request, #681:
URL: https://github.com/apache/tomcat/pull/681
Please see https://lists.apache.org/thread/47syblyghh3tromyf6bkvl8q14w70f3x
for the initial conversation.
I see some potential improvements for the CSRF prevention filter that will
be w
markt-asf commented on PR #524:
URL: https://github.com/apache/tomcat/pull/524#issuecomment-1857955904
A variation of this has been applied to 11.0.x as Servlet 6.1 has added
additional methods to allow the status code to be specified in a sendRedirect()
call.
--
This is an automated mes
zoumuzou commented on issue #51:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/51#issuecomment-1851193071
OK, thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] opened a new pull request, #680:
URL: https://github.com/apache/tomcat/pull/680
Bumps org.apache.tomcat:tomcat-catalina from 10.1.15 to 10.1.16.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=or
glendagonzales closed pull request #42: PDS-4683 upgrade tomcat for security
reasons
URL: https://github.com/apache/tomcat-maven-plugin/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
aooohan closed pull request #679: Update README.md
URL: https://github.com/apache/tomcat/pull/679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-un
BTrees opened a new pull request, #679:
URL: https://github.com/apache/tomcat/pull/679
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dependabot[bot] commented on PR #3:
URL:
https://github.com/apache/tomcat-taglibs-standard/pull/3#issuecomment-1819973270
Superseded by #9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
dependabot[bot] closed pull request #3: Bump derby from 10.4.2.0 to 10.14.2.0
in /standard-test
URL: https://github.com/apache/tomcat-taglibs-standard/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
dependabot[bot] opened a new pull request, #9:
URL: https://github.com/apache/tomcat-taglibs-standard/pull/9
Bumps org.apache.derby:derby from 10.4.2.0 to 10.17.1.0.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-na
dependabot[bot] closed pull request #2: Bump derby from 10.4.2.0 to 10.14.2.0
in /standard-examples
URL: https://github.com/apache/tomcat-taglibs-standard/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
dependabot[bot] commented on PR #2:
URL:
https://github.com/apache/tomcat-taglibs-standard/pull/2#issuecomment-1819973208
Superseded by #8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
dependabot[bot] opened a new pull request, #8:
URL: https://github.com/apache/tomcat-taglibs-standard/pull/8
Bumps org.apache.derby:derby from 10.4.2.0 to 10.17.1.0.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-na
jfclere closed pull request #641: Making sure that stop is not "blocked" by the
check() in HostConfig
URL: https://github.com/apache/tomcat/pull/641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
jfclere commented on PR #641:
URL: https://github.com/apache/tomcat/pull/641#issuecomment-1819080600
See
https://github.com/apache/tomcat/commit/dce1fc833b5192ec0ccee7d4120a050cee5da8de
the exceptions are gone but now the stop() is blocked by the check(String
name) but the fix is easy do
aooohan closed pull request #678: Add support for RequestBoudaries in DBCP
URL: https://github.com/apache/tomcat/pull/678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
aooohan commented on PR #678:
URL: https://github.com/apache/tomcat/pull/678#issuecomment-1818083370
This is an internal fork project which not belong to Tomcat. You should move
this change to [Apache Commons DBCP](https://github.com/apache/commons-dbcp).
--
This is an automated message f
KoteswararaoGundapaneni commented on PR #678:
URL: https://github.com/apache/tomcat/pull/678#issuecomment-1817359611
still there is no presence of beginRequest in our code when i checked in dbcp
--
This is an automated message from the Apache Git Service.
To respond to the message, please
KoteswararaoGundapaneni commented on PR #678:
URL: https://github.com/apache/tomcat/pull/678#issuecomment-1817334170
Hi Meedbek Please allow to work on this for offline to assist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
meedbek opened a new pull request, #678:
URL: https://github.com/apache/tomcat/pull/678
JDBC 4.3 introduced `beginRequest` and `endRequest` methods for connection
pools which are called to mark request boundaries.
`beginRequest` should be called when borrowing a connection and `endReq
KoteswararaoGundapaneni commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1816164863
Requesting to panel the change request to be considering and request has
been taken care by the process that's done above
--
This is an automated message from the Apache G
markt-asf merged PR #50:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
markt-asf commented on PR #667:
URL: https://github.com/apache/tomcat/pull/667#issuecomment-1801356054
Closing since behaviour is intentionally configurable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
markt-asf closed pull request #667: Before closing the database connection,
roll back the transaction
URL: https://github.com/apache/tomcat/pull/667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
fmeheust commented on code in PR #677:
URL: https://github.com/apache/tomcat/pull/677#discussion_r1384572235
##
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java:
##
@@ -812,6 +829,28 @@ protected PooledConnection createConnection(long now,
PooledC
fmeheust commented on code in PR #677:
URL: https://github.com/apache/tomcat/pull/677#discussion_r1384567373
##
modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/ConnectionBoundariesTest.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
aooohan commented on code in PR #677:
URL: https://github.com/apache/tomcat/pull/677#discussion_r1384334368
##
modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/ConnectionBoundariesTest.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
fmeheust opened a new pull request, #677:
URL: https://github.com/apache/tomcat/pull/677
JDBC 4.3 added the methods beginRequest and endRequest to
java.sql.Connection. These methods hint the driver of the beginning and
completion of a request (independent unit of work). Connection pooling m
markt-asf commented on PR #676:
URL: https://github.com/apache/tomcat/pull/676#issuecomment-1790213186
No, this PR will not be applied. Applications should not be setting the
Transfer-Encoding header. Or the Connection header for that matter.
If you want to strongly suggest to the con
w1ida commented on PR #676:
URL: https://github.com/apache/tomcat/pull/676#issuecomment-1789983590
> The description for the PR confuses request and response. It appears from
the code that this PR relates to the response.
>
> This PR will not be applied. Whether or not to chunk the re
markt-asf commented on PR #676:
URL: https://github.com/apache/tomcat/pull/676#issuecomment-1788896749
The description for the PR confuses request and response. It appears from
the code that this PR relates to the response.
This PR will not be applied. Whether or not to chunk the resp
markt-asf closed pull request #676: Fix explicit chunked encoding specification
URL: https://github.com/apache/tomcat/pull/676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
w1ida opened a new pull request, #676:
URL: https://github.com/apache/tomcat/pull/676
Summary:
This commit fixes a bug in the code related to handling chunked transfer
encoding. The original code only handled chunked transfer encoding when http11
was true, entityBody was true, and connec
michael-o closed pull request #675: BZ 67926: PEMFile prints unidentifiable
string representation of ASN.1 OIDs
URL: https://github.com/apache/tomcat/pull/675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
michael-o commented on PR #675:
URL: https://github.com/apache/tomcat/pull/675#issuecomment-1787001486
Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
rmaucher commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1377379112
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -56,6 +56,8 @@
import org.apache.tomcat.util.codec.binary.Base64;
import org.apache.tomcat.util.file.ConfigF
aooohan commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1377275894
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) {
}
return bytes;
michael-o commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1377274168
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) {
}
return bytes;
aooohan commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1377262792
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) {
}
return bytes;
michael-o commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1377209435
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) {
}
return bytes;
michael-o commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1377209435
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) {
}
return bytes;
aooohan commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1376990387
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) {
}
return bytes;
aooohan commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1376990387
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) {
}
return bytes;
aooohan commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1376990387
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) {
}
return bytes;
michael-o commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1376474963
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -56,6 +56,8 @@
import org.apache.tomcat.util.codec.binary.Base64;
import org.apache.tomcat.util.file.Config
michael-o commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1376474963
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -56,6 +56,8 @@
import org.apache.tomcat.util.codec.binary.Base64;
import org.apache.tomcat.util.file.Config
ChristopherSchultz commented on code in PR #675:
URL: https://github.com/apache/tomcat/pull/675#discussion_r1376435849
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -56,6 +56,8 @@
import org.apache.tomcat.util.codec.binary.Base64;
import org.apache.tomcat.util.fi
michael-o opened a new pull request, #675:
URL: https://github.com/apache/tomcat/pull/675
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
michael-o closed pull request #22: BZ 67818:
SSL#setVerify()/SSLContext#setVerify() silently set undocum…
URL: https://github.com/apache/tomcat-native/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
michael-o commented on PR #22:
URL: https://github.com/apache/tomcat-native/pull/22#issuecomment-1784891589
Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
chenggwang commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1780424297
> Thanks for the PR.
Thanks for all the REVIEWS!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
aooohan commented on PR #632:
URL: https://github.com/apache/tomcat/pull/632#issuecomment-1780327810
Hi, If you want this PR to merge smoothly, please modify this change
according to markt‘s comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
aooohan commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1780324734
Thanks for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
aooohan merged PR #671:
URL: https://github.com/apache/tomcat/pull/671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
umar-sheik closed pull request #41: Update ssh key
URL: https://github.com/apache/tomcat-maven-plugin/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
umar-sheik opened a new pull request, #41:
URL: https://github.com/apache/tomcat-maven-plugin/pull/41
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
markt-asf merged PR #674:
URL: https://github.com/apache/tomcat/pull/674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
Hakky54 commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1777163986
I am not sure whether you would consider to have this option at all. Would
you prefer me to close the issue?
--
This is an automated message from the Apache Git Service.
To respond to the
michael-o commented on PR #674:
URL: https://github.com/apache/tomcat/pull/674#issuecomment-1776796215
Yes, through shading only to make them private. Looking at the vast amount
of code you have written already I bet that ther are also others which would
like to use such a PEM to Java Keyst
markt-asf commented on PR #674:
URL: https://github.com/apache/tomcat/pull/674#issuecomment-1776785906
Added a test key using AES128 (test passed without additional code changes).
Fixed typo.
Removed debug code that wasn't intended to be part of the commit.
I might be persuaded to in
michael-o commented on PR #674:
URL: https://github.com/apache/tomcat/pull/674#issuecomment-1776767268
Built from your branch and I can confirm that this works with a selfsigned
and one issued by our enterprise CA.
--
This is an automated message from the Apache Git Service.
To respond to
michael-o commented on PR #674:
URL: https://github.com/apache/tomcat/pull/674#issuecomment-1775942678
Thanks for the hard work. I will try this tomorrow/Wednesday!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
michael-o commented on code in PR #674:
URL: https://github.com/apache/tomcat/pull/674#discussion_r1369211534
##
test/org/apache/tomcat/util/net/jsse/TestPEMFile.java:
##
@@ -118,4 +127,17 @@ private String getPath(String file) throws IOException {
return f.getCanonic
michael-o commented on PR #674:
URL: https://github.com/apache/tomcat/pull/674#issuecomment-1775933882
The more ASN.1 I see in Tomcat the more I think is that we should import
Kerby ASN.1 at some point in time...
--
This is an automated message from the Apache Git Service.
To respond to t
401 - 500 of 1118 matches
Mail list logo