[Bug 60808] ServletRequest.getParameterMap() not fully immutable

2017-03-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60808 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 60808] ServletRequest.getParameterMap() not fully immutable

2017-03-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60808 --- Comment #4 from Woonsan Ko --- I've created a new PR: https://github.com/apache/tomcat/pull/47, following Mark's suggestion to use containment instead of inheritance. Indeed, it helps reduce code size and safer in the future changes in JVM.

[Bug 60808] ServletRequest.getParameterMap() not fully immutable

2017-03-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60808 --- Comment #3 from Woonsan Ko --- Hi Mark, Yes, that makes more sense to use containment instead of extending. Even if newer JVM has more new API support in the future, ParameterMap implementing j.u.Map with a contained delegate map should be

[Bug 60808] ServletRequest.getParameterMap() not fully immutable

2017-03-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60808 --- Comment #2 from Mark Thomas --- Generally, I think it would be safer (in terms of future additions to Map and changes to the implementation of LinkedHashMap) and probably require less code if ParameterMap used composition rather than extens

[Bug 60808] ServletRequest.getParameterMap() not fully immutable

2017-03-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60808 --- Comment #1 from Woonsan Ko --- Patch available via PR: https://github.com/apache/tomcat/pull/46 Please review the PR. Thanks, Woonsan -- You are receiving this mail because: You are the assignee for the bug.