https://bz.apache.org/bugzilla/show_bug.cgi?id=61105
Violeta Georgieva changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
https://bz.apache.org/bugzilla/show_bug.cgi?id=61105
--- Comment #13 from Matt Farwell ---
It would great to see this functionality backported. Bringing it into Tomcat
8.5 and set it as disabled by default makes sense to me.
--
You are receiving this mail because:
You are the assignee for the
https://bz.apache.org/bugzilla/show_bug.cgi?id=61105
--- Comment #12 from Mark Thomas ---
Happy to see it back-ported. I'd disable by default though so there is no
change of behaviour in stable versions.
--
You are receiving this mail because:
You are the assignee for the bug.
-
https://bz.apache.org/bugzilla/show_bug.cgi?id=61105
--- Comment #11 from Violeta Georgieva ---
The change is applied and will be available in 9.0.0.M22 onwards.
The log files will be kept by default 90 days.
Do we want this change in the previous versions? May be with different default
value?
https://bz.apache.org/bugzilla/show_bug.cgi?id=61105
--- Comment #10 from Violeta Georgieva ---
(In reply to Konstantin Kolinko from comment #9)
> (In reply to Violeta Georgieva from comment #8)
> > Any comments?
>
> Generally: I like it.
>
> 1. Typo in method name: obtainDateFormPath s/Form/F
https://bz.apache.org/bugzilla/show_bug.cgi?id=61105
--- Comment #9 from Konstantin Kolinko ---
(In reply to Violeta Georgieva from comment #8)
> Any comments?
Generally: I like it.
1. Typo in method name: obtainDateFormPath s/Form/From/
2. Building a pattern,
> pattern = Pattern.compile("^(
https://bz.apache.org/bugzilla/show_bug.cgi?id=61105
--- Comment #8 from Violeta Georgieva ---
Any comments?
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@to
https://bz.apache.org/bugzilla/show_bug.cgi?id=61105
--- Comment #7 from Violeta Georgieva ---
Hi,
(In reply to Konstantin Kolinko from comment #5)
> (In reply to Violeta Georgieva from comment #3)
> > Hi,
> >
> > What do you think about this approach?
> > https://github.com/apache/tomcat/pull/
https://bz.apache.org/bugzilla/show_bug.cgi?id=61105
--- Comment #6 from Huxing Zhang ---
Hi,
> There was no concern expressed about the log files that are currently not
> rolled (generally, I suspect, because well written apps won;t trigger content
> to those files).
We do have concerns about
2017 Jun 6 (Tue) 03:45
To:dev
Subject:[Bug 61105] Roll log files by default
https://bz.apache.org/bugzilla/show_bug.cgi?id=61105
--- Comment #2 from Mark Thomas ---
The conversation at TomcatCon was around putting a (relatively large) limit on
the number of files that are kept by default. Pic
https://bz.apache.org/bugzilla/show_bug.cgi?id=61105
--- Comment #5 from Konstantin Kolinko ---
(In reply to Violeta Georgieva from comment #3)
> Hi,
>
> What do you think about this approach?
> https://github.com/apache/tomcat/pull/60
>
+public static final int DEFAULT_MAX_DAYS = 90;
+
https://bz.apache.org/bugzilla/show_bug.cgi?id=61105
--- Comment #4 from Violeta Georgieva ---
Hi,
In the PR [1] there is a proposal for merging the proposed functionality with
https://github.com/apache/tomee/blob/master/tomee/tomee-juli/src/main/java/org/apache/tomee/jul/handler/rotating/LocalF
https://bz.apache.org/bugzilla/show_bug.cgi?id=61105
--- Comment #3 from Violeta Georgieva ---
Hi,
What do you think about this approach?
https://github.com/apache/tomcat/pull/60
Thanks,
Violeta
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61105
--- Comment #2 from Mark Thomas ---
The conversation at TomcatCon was around putting a (relatively large) limit on
the number of files that are kept by default. Picking a number of of thin air,
how does 90 days sound?
There was no concern expr
https://bz.apache.org/bugzilla/show_bug.cgi?id=61105
--- Comment #1 from Violeta Georgieva ---
Hi,
Currently the log files (except catalina.out which is available on OSes !=
Windows) are rotated by default based on the date.
We can introduce in addition a configuration for the file size and also
15 matches
Mail list logo
