https://bz.apache.org/bugzilla/show_bug.cgi?id=63505
--- Comment #8 from Eugène Adell ---
Created attachment 37407
--> https://bz.apache.org/bugzilla/attachment.cgi?id=37407=edit
refactoring as suggested in comment 6
This zip contains 4 Java files corresponding to the suggestion made by
https://bz.apache.org/bugzilla/show_bug.cgi?id=63505
--- Comment #7 from Mark Thomas ---
I agree we need to deprecate the JDBCREalm although that is a little off-topic
here.
I think we need:
- a (non-abstract?) base class that uses PreparedStatements
- a concrete implementation as per the
https://bz.apache.org/bugzilla/show_bug.cgi?id=63505
--- Comment #6 from Christopher Schultz ---
(In reply to Eugène Adell from comment #5)
> Exactly, both files are the same except I needed to override these 2
> functions and also add variables for handling the procedures names (and what
>
https://bz.apache.org/bugzilla/show_bug.cgi?id=63505
Christopher Schultz changed:
What|Removed |Added
Attachment #36628|text/x-csrc |text/plain
mime type|
https://bz.apache.org/bugzilla/show_bug.cgi?id=63505
--- Comment #5 from Eugène Adell ---
Exactly, both files are the same except I needed to override these 2 functions
and also add variables for handling the procedures names (and what comes with
them : getters/setters of course). Maybe making
https://bz.apache.org/bugzilla/show_bug.cgi?id=63505
--- Comment #4 from Christopher Schultz ---
There might be some refactoring that could help, here. It seems that mostly you
are overriding the getPassword(Connection,String) and
getRoles(Connection,String) methods from DataSourceRealm, right?
https://bz.apache.org/bugzilla/show_bug.cgi?id=63505
Christopher Schultz changed:
What|Removed |Added
Keywords||PatchAvailable
--
You are
https://bz.apache.org/bugzilla/show_bug.cgi?id=63505
--- Comment #3 from Eugène Adell ---
The first one retrieves the user's password, the second the user's roles.
Better ideas to names these attributes are of course welcome.
--
You are receiving this mail because:
You are the assignee for
https://bz.apache.org/bugzilla/show_bug.cgi?id=63505
--- Comment #2 from Christopher Schultz ---
What are userProcStoc and roleProcStoc abbreviations for? Those names look
weird.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63505
--- Comment #1 from Eugène Adell ---
Created attachment 36628
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36628=edit
a new class implementing this enhancement
This class is based on DataSourceRealm source code (copy/paste of this
https://bz.apache.org/bugzilla/show_bug.cgi?id=63505
Eugène Adell changed:
What|Removed |Added
CC||eugene.ad...@gmail.com
--
You are
11 matches
Mail list logo
