michael-o commented on issue #178: Bug 63556 - Mark request as forwarded in
RemoteIpValve/RemoteIpFilter
URL: https://github.com/apache/tomcat/pull/178#issuecomment-509672500
@markt-asf Done. Will now run the tests again
michael-o commented on issue #178: Bug 63556 - Mark request as forwarded in
RemoteIpValve/RemoteIpFilter
URL: https://github.com/apache/tomcat/pull/178#issuecomment-509669901
* Will fix `changelog.xml`
* Indeed, I have blindly copied from `REMOTE_ADDR_ATTRIBUTE`. I can drop
markt-asf commented on issue #178: Bug 63556 - Mark request as forwarded in
RemoteIpValve/RemoteIpFilter
URL: https://github.com/apache/tomcat/pull/178#issuecomment-509663648
Only a couple of minor comments.
- We try and keep the changelog to a maximum width of 80 chars. We probably
https://bz.apache.org/bugzilla/show_bug.cgi?id=63556
--- Comment #1 from Michael Osipov ---
PR delivered: https://github.com/apache/tomcat/pull/178
Will then back port.
--
You are receiving this mail because:
You are the assignee for the bug.
michael-o opened a new pull request #178: Bug 63556 - Mark request as forwarded
in RemoteIpValve/RemoteIpFilter
URL: https://github.com/apache/tomcat/pull/178
This is WIP, please review. I will squash, backport to 8.5.x and merge into
both branches
https://bz.apache.org/bugzilla/show_bug.cgi?id=63556
Michael Osipov changed:
What|Removed |Added
Blocks||62496
CC|
