[Bug 68089] ApplicationHttpRequest.getSpecial() and removeSpecial() use linear scans

2024-03-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68089 --- Comment #13 from John Engebretson --- This changed reached prod and improved performance. Low impact. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 68089] ApplicationHttpRequest.getSpecial() and removeSpecial() use linear scans

2024-02-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68089 --- Comment #12 from John Engebretson --- String compaction made charAt() more expensive, thanks to checks on format and range. String.length() remains an integer check. That said, charAt() isn't that bad, so it's an option if functionally

[Bug 68089] ApplicationHttpRequest.getSpecial() and removeSpecial() use linear scans

2024-02-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68089 --- Comment #11 from Christopher Schultz --- (In reply to Mark Thomas from comment #9) > I did look at using !startsWith("jakarta") but that is ~2x slower than a > length check. > > I've coded up the length check and am just running some

[Bug 68089] ApplicationHttpRequest.getSpecial() and removeSpecial() use linear scans

2024-02-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68089 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[Bug 68089] ApplicationHttpRequest.getSpecial() and removeSpecial() use linear scans

2024-02-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68089 --- Comment #9 from Mark Thomas --- I did look at using !startsWith("jakarta") but that is ~2x slower than a length check. I've coded up the length check and am just running some tests locally. -- You are receiving this mail because: You

[Bug 68089] ApplicationHttpRequest.getSpecial() and removeSpecial() use linear scans

2024-02-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68089 --- Comment #8 from John Engebretson --- Created attachment 39575 --> https://bz.apache.org/bugzilla/attachment.cgi?id=39575=edit Support class for the speed test -- You are receiving this mail because: You are the assignee for the bug.

[Bug 68089] ApplicationHttpRequest.getSpecial() and removeSpecial() use linear scans

2024-02-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68089 --- Comment #7 from John Engebretson --- Created attachment 39574 --> https://bz.apache.org/bugzilla/attachment.cgi?id=39574=edit Speed test -- You are receiving this mail because: You are the assignee for the bug.

[Bug 68089] ApplicationHttpRequest.getSpecial() and removeSpecial() use linear scans

2024-02-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68089 John Engebretson changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[Bug 68089] ApplicationHttpRequest.getSpecial() and removeSpecial() use linear scans

2023-11-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68089 --- Comment #5 from John Engebretson --- For posterity: this issue also dominates the runtime of org.apache.catalina.core.ApplicationHttpRequest$AttributeNamesEnumerator.findNext(). -- You are receiving this mail because: You are the

[Bug 68089] ApplicationHttpRequest.getSpecial() and removeSpecial() use linear scans

2023-11-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68089 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Bug 68089] ApplicationHttpRequest.getSpecial() and removeSpecial() use linear scans

2023-11-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68089 --- Comment #3 from John Engebretson --- Good idea to measure ApplicationHttpRequest.getAttribute()! Our production environment shows 0.27% cpu spent in that method, of which 0.1% cpu is spent in method-local time (including the inlined array

[Bug 68089] ApplicationHttpRequest.getSpecial() and removeSpecial() use linear scans

2023-11-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68089 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #2 from Mark Thomas

[Bug 68089] ApplicationHttpRequest.getSpecial() and removeSpecial() use linear scans

2023-11-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68089 Remy Maucherat changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Remy

[Bug 68089] ApplicationHttpRequest.getSpecial() and removeSpecial() use linear scans

2023-11-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68089 Anurag Dubey changed: What|Removed |Added CC||anura...@amazon.com -- You are