[GitHub] [tomcat] davoustp commented on issue #170: Connections validated without explicit validation query leave a transaction open

2019-10-01 Thread GitBox
davoustp commented on issue #170: Connections validated without explicit validation query leave a transaction open URL: https://github.com/apache/tomcat/pull/170#issuecomment-536993033 Thx Mark! This is an automated message

[GitHub] [tomcat] davoustp commented on issue #170: Connections validated without explicit validation query leave a transaction open

2019-09-27 Thread GitBox
davoustp commented on issue #170: Connections validated without explicit validation query leave a transaction open URL: https://github.com/apache/tomcat/pull/170#issuecomment-535816682 Hi, any idea if and when this fix will be merged into a Tomcat release? Thx

[GitHub] [tomcat] davoustp commented on issue #170: Connections validated without explicit validation query leave a transaction open

2019-06-19 Thread GitBox
davoustp commented on issue #170: Connections validated without explicit validation query leave a transaction open URL: https://github.com/apache/tomcat/pull/170#issuecomment-503435774 Done. Please let me know what you think.

[GitHub] [tomcat] davoustp commented on issue #170: Connections validated without explicit validation query leave a transaction open

2019-06-18 Thread GitBox
davoustp commented on issue #170: Connections validated without explicit validation query leave a transaction open URL: https://github.com/apache/tomcat/pull/170#issuecomment-503323483 Agreed, the driver is expected to be as thin and stateless as possible. Indeed, using a flag to track

[GitHub] [tomcat] davoustp commented on issue #170: Connections validated without explicit validation query leave a transaction open

2019-06-18 Thread GitBox
davoustp commented on issue #170: Connections validated without explicit validation query leave a transaction open URL: https://github.com/apache/tomcat/pull/170#issuecomment-503212478 You mean that `silentlyRollbackTransactionIfNeeded()` at line 532? There is no `finally` block in this