[GitHub] [tomcat] greeng00se commented on pull request #660: Optimize when call getSessionCookieName & getSessionUriParamName

2023-09-06 Thread via GitHub
greeng00se commented on PR #660: URL: https://github.com/apache/tomcat/pull/660#issuecomment-1709145552 @markt-asf thx for good comment XD -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [tomcat] greeng00se commented on pull request #660: Optimize when call getSessionCookieName & getSessionUriParamName

2023-09-05 Thread via GitHub
greeng00se commented on PR #660: URL: https://github.com/apache/tomcat/pull/660#issuecomment-1707265409 @markt-asf Thanks for the nice comment. I hadn't considered that partial compiler optimisation. I agree, readable code should be a priority and I moved the null-check logic to a