isapir commented on code in PR #598: URL: https://github.com/apache/tomcat/pull/598#discussion_r1133421847
########## java/org/apache/catalina/storeconfig/ConnectorStoreAppender.java: ########## @@ -29,6 +29,7 @@ import java.util.List; import java.util.Set; +import org.apache.catalina.Globals; Review Comment: I see that we also have a file named `java/org/apache/catalina/storeconfig/Constants.java` but it does not set `CATALINA_BASE_PROP`. I am guessing there is a reasoning behind the different `Constants` classes so trying to figure it out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
