[GitHub] [tomcat] markt-asf commented on issue #249: Support for default values in property value expressions

2020-04-02 Thread GitBox
markt-asf commented on issue #249: Support for default values in property value expressions URL: https://github.com/apache/tomcat/pull/249#issuecomment-607903803 Thanks for thr PR. A variation has been applied to all currently supported branches.

[GitHub] [tomcat] markt-asf commented on issue #249: Support for default values in property value expressions

2020-03-31 Thread GitBox
markt-asf commented on issue #249: Support for default values in property value expressions URL: https://github.com/apache/tomcat/pull/249#issuecomment-606489783 Nothing comes to mind immediately. We typically go through all the open PRs before we start the release process. We aim to

[GitHub] [tomcat] markt-asf commented on issue #249: Support for default values in property value expressions

2020-03-02 Thread GitBox
markt-asf commented on issue #249: Support for default values in property value expressions URL: https://github.com/apache/tomcat/pull/249#issuecomment-593575547 Of course, this is the name, not the value and if the name with ":" is tried first that should be fine.

[GitHub] [tomcat] markt-asf commented on issue #249: Support for default values in property value expressions

2020-03-02 Thread GitBox
markt-asf commented on issue #249: Support for default values in property value expressions URL: https://github.com/apache/tomcat/pull/249#issuecomment-593566006 Hmm. That makes ":" a reserved character in property values. That is going to have an impact on backwards compatibility. ":" is