[GitHub] [tomcat] markt-asf commented on pull request #479: Fix Response#sendRedirect() if no request context exists.

2022-03-01 Thread GitBox
markt-asf commented on pull request #479: URL: https://github.com/apache/tomcat/pull/479#issuecomment-1055537623 Based on this discussion, the original fix is correct. I'll merge this shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tomcat] markt-asf commented on pull request #479: Fix Response#sendRedirect() if no request context exists.

2022-03-01 Thread GitBox
markt-asf commented on pull request #479: URL: https://github.com/apache/tomcat/pull/479#issuecomment-1055206076 Thanks for that example. The right way to fix this will depend on the answer to the question "If a rewrite valve is configured at the Host level, is it a requirement that a

[GitHub] [tomcat] markt-asf commented on pull request #479: Fix Response#sendRedirect() if no request context exists.

2022-02-28 Thread GitBox
markt-asf commented on pull request #479: URL: https://github.com/apache/tomcat/pull/479#issuecomment-1054062262 I can see valid use cases that wouldn't meet at least one of those criteria so I don't think it is quite that simple. Having a concrete use case to discuss might make things a

[GitHub] [tomcat] markt-asf commented on pull request #479: Fix Response#sendRedirect() if no request context exists.

2022-02-25 Thread GitBox
markt-asf commented on pull request #479: URL: https://github.com/apache/tomcat/pull/479#issuecomment-1050857542 This looks like invalid configuration at this point. Generally, an NPE is preferable to a change that masks a configuration issue. -- This is an automated message from