[GitHub] [tomcat] markt-asf commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement

2023-05-31 Thread via GitHub
markt-asf commented on PR #623: URL: https://github.com/apache/tomcat/pull/623#issuecomment-1570534844 > @markt-asf that looks better that what was there ;-) Thanks. Can you recall if there was a use case for this Valve on a single node? Or was it always intended for use

[GitHub] [tomcat] markt-asf commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement

2023-05-31 Thread via GitHub
markt-asf commented on PR #623: URL: https://github.com/apache/tomcat/pull/623#issuecomment-1570461148 I haven't deprecated this yet. I'm waiting on input from the OP of BZ 66513 and/or @jfclere as the original author of the Valve in case there is a use case I have missed. -- This is an

[GitHub] [tomcat] markt-asf commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement

2023-05-30 Thread via GitHub
markt-asf commented on PR #623: URL: https://github.com/apache/tomcat/pull/623#issuecomment-1568591682 Map eviction is handled in the finally block. That we can only make this work on a single node is why Rémy is proposing that we remove/deprecate this Valve. -- This is an