[GitHub] [tomcat] martin-g commented on pull request #351: Remove White Spaces from the JSP files

2020-09-25 Thread GitBox
martin-g commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-698157237 Since there is no new test for this I am not sure but looking at the code I think "Remove white space" is not quite accurate. It is rather "Remove empty lines". Because

[GitHub] [tomcat] martin-g commented on pull request #351: Remove White Spaces from the JSP files

2020-09-24 Thread GitBox
martin-g commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-698157237 Since there is no new test for this I am not sure but looking at the code I think "Remove white space" is not quite accurate. It is rather "Remove empty lines". Because

[GitHub] [tomcat] martin-g commented on pull request #351: Remove White Spaces from the JSP files

2020-09-18 Thread GitBox
martin-g commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-695042633 Have you considered using gzip compression for such big responses? It'd help much better that the white space stripping. On Fri, Sep 18, 2020, 20:39 kamnani wrote: