michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r540877133
##
File path: webapps/docs/config/http.xml
##
@@ -208,6 +208,24 @@
The default is POST
+
Review comment:
Having both enabled mig
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r540877133
##
File path: webapps/docs/config/http.xml
##
@@ -208,6 +208,24 @@
The default is POST
+
Review comment:
Having both enabled mig
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r533488953
##
File path: java/org/apache/tomcat/util/net/LocalStrings.properties
##
@@ -88,6 +88,7 @@ endpoint.init.bind=Socket bind failed: [{0}] [{1}]
endpoint.ini
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r533484404
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the pool
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532913829
##
File path: java/org/apache/coyote/AbstractProtocol.java
##
@@ -351,12 +351,15 @@ public String getName() {
private String getNameInternal() {
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532875949
##
File path: java/org/apache/coyote/AbstractProtocol.java
##
@@ -351,12 +351,15 @@ public String getName() {
private String getNameInternal() {
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532841983
##
File path: java/org/apache/coyote/AbstractProtocol.java
##
@@ -351,12 +351,15 @@ public String getName() {
private String getNameInternal() {
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532716306
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the pool
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532692425
##
File path: java/org/apache/tomcat/jni/Library.java
##
@@ -247,7 +247,7 @@ public static synchronized boolean initialize(String
libraryName) throws Exce
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532692219
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the pool
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532587344
##
File path: java/org/apache/tomcat/util/net/AbstractEndpoint.java
##
@@ -568,6 +569,14 @@ public final int getLocalPort() {
protected abstract InetS
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532584495
##
File path: java/org/apache/tomcat/jni/Library.java
##
@@ -177,6 +177,9 @@ private Library(String libraryName)
/* Is the O_NONBLOCK flag inherited f
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532584495
##
File path: java/org/apache/tomcat/jni/Library.java
##
@@ -177,6 +177,9 @@ private Library(String libraryName)
/* Is the O_NONBLOCK flag inherited f
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532523457
##
File path: webapps/docs/config/http.xml
##
@@ -1152,6 +1156,11 @@
permissions appropriately configured to restrict access as required.
+ Tomca
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532523379
##
File path: webapps/docs/config/http.xml
##
@@ -212,7 +212,11 @@
Where supported, the path to a unix domain socket that this
Connector will
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r53252
##
File path: java/org/apache/coyote/AbstractProtocol.java
##
@@ -347,22 +352,27 @@ public String getName() {
private String getNameInternal() {
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532520621
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the pool
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532284639
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the pool
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532274020
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the pool
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532271195
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the pool
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532269203
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the pool
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532268550
##
File path: java/org/apache/coyote/AbstractProtocol.java
##
@@ -347,22 +352,27 @@ public String getName() {
private String getNameInternal() {
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532265524
##
File path: java/org/apache/tomcat/util/IntrospectionUtils.java
##
@@ -136,6 +138,19 @@ public static boolean setProperty(Object o, String name,
String
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r532256127
##
File path: java/org/apache/tomcat/util/IntrospectionUtils.java
##
@@ -136,6 +138,19 @@ public static boolean setProperty(Object o, String name,
String
24 matches
Mail list logo
