[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-22 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r655173166 ## File path: java/org/apache/catalina/realm/DataSourceRealm.java ## @@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() { } +/** +

[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-21 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r655234294 ## File path: java/org/apache/catalina/realm/DataSourceRealm.java ## @@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() { } +/** +

[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-21 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r655204617 ## File path: java/org/apache/catalina/realm/DataSourceRealm.java ## @@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() { } +/** +

[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-21 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r655182143 ## File path: java/org/apache/catalina/realm/DataSourceRealm.java ## @@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() { } +/** +

[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-21 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r655178151 ## File path: java/org/apache/catalina/TomcatPrincipal.java ## @@ -47,4 +48,58 @@ * exception to LoginContext */ void

[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-21 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r655177819 ## File path: java/org/apache/catalina/realm/DataSourceRealm.java ## @@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() { } +/** +

[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-21 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r655176832 ## File path: java/org/apache/catalina/realm/DataSourceRealm.java ## @@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() { } +/** +

[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-21 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r655175314 ## File path: java/org/apache/catalina/realm/DataSourceRealm.java ## @@ -572,6 +801,21 @@ protected void startInternal() throws LifecycleException {

[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-21 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r655174381 ## File path: java/org/apache/catalina/realm/DataSourceRealm.java ## @@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() { } +/** +

[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-21 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r655173373 ## File path: java/org/apache/catalina/realm/JNDIRealm.java ## @@ -469,6 +474,19 @@ */ protected boolean useContextClassLoader = true; +

[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-21 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r655173166 ## File path: java/org/apache/catalina/realm/DataSourceRealm.java ## @@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() { } +/** +

[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-20 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r655087748 ## File path: java/org/apache/catalina/realm/DataSourceRealm.java ## @@ -572,6 +801,21 @@ protected void startInternal() throws LifecycleException {

[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-20 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r655087196 ## File path: java/org/apache/catalina/realm/DataSourceRealm.java ## @@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() { } +/** +

[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-20 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r655086726 ## File path: java/org/apache/catalina/realm/DataSourceRealm.java ## @@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() { } +/** +

[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-20 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r655086451 ## File path: java/org/apache/catalina/realm/DataSourceRealm.java ## @@ -107,6 +134,22 @@ private volatile boolean connectionSuccess = true; +

[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-20 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r654974567 ## File path: java/org/apache/catalina/realm/DataSourceRealm.java ## @@ -223,6 +266,34 @@ public void setUserTable( String userTable ) {

[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-20 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r654974479 ## File path: java/org/apache/catalina/TomcatPrincipal.java ## @@ -47,4 +48,58 @@ * exception to LoginContext */ void

[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-20 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r654974123 ## File path: java/org/apache/catalina/TomcatPrincipal.java ## @@ -47,4 +48,58 @@ * exception to LoginContext */ void

[GitHub] [tomcat] michael-o commented on a change in pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-06-20 Thread GitBox
michael-o commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r654963957 ## File path: java/org/apache/catalina/TomcatPrincipal.java ## @@ -47,4 +48,58 @@ * exception to LoginContext */ void