[GitHub] [tomcat] zhanhb commented on issue #174: Clean method parseRange

2019-06-25 Thread GitBox
zhanhb commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505359318 My suggestion for multiple range support: support is enough, don't let it be an entrance for DDOS attack. For this feature is specified in rfc document, many

[GitHub] [tomcat] zhanhb commented on issue #174: Clean method parseRange

2019-06-25 Thread GitBox
zhanhb commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505352885 Here's how I parse request `Range` now, glad if this can help you.

[GitHub] [tomcat] zhanhb commented on issue #174: Clean method parseRange

2019-06-25 Thread GitBox
zhanhb commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505350158 If strong weak tag is implemented, maybe strong etag validator can be applied on header `If-Range`. Just maybe, we can see on the client side, chrome doesn't do

[GitHub] [tomcat] zhanhb commented on issue #174: Clean method parseRange

2019-06-25 Thread GitBox
zhanhb commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505345715 Here's a test case for PUT, no other cases yet now. ```sh curl -i -X PUT --header 'Content-Range: bytes=1-5/4' --data 'abcdef'

[GitHub] [tomcat] zhanhb commented on issue #174: Clean method parseRange

2019-06-24 Thread GitBox
zhanhb commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505224327 https://github.com/apache/tomcat/blob/54ea770e6213a7bed64ac9d90d7cfcf2dffc6a61/java/org/apache/catalina/servlets/DefaultServlet.java#L1391 How abouting chaning

[GitHub] [tomcat] zhanhb commented on issue #174: Clean method parseRange

2019-06-24 Thread GitBox
zhanhb commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505220224 It's not easy for me to run a single test case now. I execute curl instead. I'll try to run single test case instead of execute command curl.