Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/115
Thanks for the PR. We have fixed this but with a simpler approach that
makes use of `ConcurrentDateFormat.formatRfc1123()`
---
Github user rainerjung commented on the issue:
https://github.com/apache/tomcat/pull/115
@michael-o IMHO because an invalid header value will push most parsing code
to the error handling code path. And only by additional rules should that code
handle it like a valid header in the
Github user michael-o commented on the issue:
https://github.com/apache/tomcat/pull/115
@rainerjung My question simply was that if `Expires: 0` denotes a value in
the past (expired already), why should I explicitly use a valid header in the
past which requires more code to create as
Github user rainerjung commented on the issue:
https://github.com/apache/tomcat/pull/115
@michael-o APR_DATE_BAD: the date string was null, or unparsable or the
parsed date does not exist. A date in the past would not result in
APR_DATE_BAD. A timestamp before the unix epoch should
Github user michael-o commented on the issue:
https://github.com/apache/tomcat/pull/115
Here is the reference commit:
https://github.com/apache/httpd/commit/60087a708b051c3c987b80abdfdc3f2e046ebc4d
@rainerjung How is `APR_DATE_BAD` defined? Unparsable? Or before Unix
epoch?
Github user rainerjung commented on the issue:
https://github.com/apache/tomcat/pull/115
Note that although the RFC demands to handle an invalid Expires header
(like Expires: 0) like one with a timestamp in the past, I coincidentally ran
into a problem yesterday, where the Apache web
Github user pandareen commented on the issue:
https://github.com/apache/tomcat/pull/115
Good thought @michael-o. I'll get some info from chromium...
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
Github user michael-o commented on the issue:
https://github.com/apache/tomcat/pull/115
Thanks for the explanation. I hardly believe that Chrome does not implement
`Expires: 0`. At best, we inquire with the Chromium project.
---
Github user pandareen commented on the issue:
https://github.com/apache/tomcat/pull/115
Okay let me explain.
Case 1. [https://i.imgur.com/tofjYaM.png](https://i.imgur.com/tofjYaM.png)
- When chrome gets a `Cache-Control: no-cache` directive in response header, it
sends
Github user michael-o commented on the issue:
https://github.com/apache/tomcat/pull/115
@pandareen, how do you know that Chrome does not understand it?
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
Github user pandareen commented on the issue:
https://github.com/apache/tomcat/pull/115
@michael-o I built tomcat using `Expires` header as `0`, but chrome is
still not understanding.
Here's a screenshot: [https://i.imgur.com/cSnuVIr.png](url)
---
Github user michael-o commented on the issue:
https://github.com/apache/tomcat/pull/115
I'd rather use `0` according to the spec. Moreover, it has less bytes to
transfer.
---
-
To unsubscribe, e-mail:
Github user pandareen commented on the issue:
https://github.com/apache/tomcat/pull/115
@michael-o I think 0 would be confusing. Preformatted string in static
final sounds simpler to me.
---
-
To unsubscribe,
Github user michael-o commented on the issue:
https://github.com/apache/tomcat/pull/115
The format is described here:
https://tools.ietf.org/html/rfc7231#section-7.1.1.1
Why not the stuff altogether and store the preformatted string in a static
final? We can also use the value of
14 matches
Mail list logo
