[GitHub] tomcat issue #126: The feature of the transfer rate control are added to the...

2018-10-13 Thread rmaucher
Github user rmaucher commented on the issue: https://github.com/apache/tomcat/pull/126 Ok. But this portion of the code in the connectors is asynchronous, so a throttling solution based on Thread.sleep isn't good enough for inclusion. A throttling feature, by itself, would be

[GitHub] tomcat issue #126: The feature of the transfer rate control are added to the...

2018-10-12 Thread Yuanuo
Github user Yuanuo commented on the issue: https://github.com/apache/tomcat/pull/126 Ok. It has been closed, but I still want to express my views here. I am very sorry about my English level. These texts are all done with Google Translate. 1. In any actual

[GitHub] tomcat issue #126: The feature of the transfer rate control are added to the...

2018-10-12 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/126 -1 here too for much the same reason. A filter would work better for this. Ignoring the thread related concerns, I'd also point out that new features without a description of the use case or

[GitHub] tomcat issue #126: The feature of the transfer rate control are added to the...

2018-10-12 Thread rmaucher
Github user rmaucher commented on the issue: https://github.com/apache/tomcat/pull/126 -1 from me. This is a bad combination of too big and too specific to be included IMO. Also, and more importantly, it will replace a non blocking / async IO feature with something that uses threads