[GitHub] tomcat issue #137: Add HTML lang="en"

2019-01-29 Thread ChristopherSchultz
Github user ChristopherSchultz commented on the issue: https://github.com/apache/tomcat/pull/137 > 404/403/401.jsp pages in manager and host-manager may benefit from localization, and in that case the lang attribute has to be calculated dynamically to reflect the actual language

[GitHub] tomcat issue #137: Add HTML lang="en"

2019-01-29 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/137 > Anyway, those package.html files are just fragments consumed by javadoc tool. I suspect that changing the attributes of the HTML element does not have any effect on generated Javadoc

[GitHub] tomcat issue #137: Add HTML lang="en"

2019-01-29 Thread kkolinko
Github user kkolinko commented on the issue: https://github.com/apache/tomcat/pull/137 > The changes to package.html and similar look good. The doctype declaration in package.html says HTML 3.2 and I that version does not have the lang attribute on HTML element. HTML 4.01

[GitHub] tomcat issue #137: Add HTML lang="en"

2019-01-28 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/137 I'm all in favour of improving accessibility. The changes to package.html and similar look good. The changes to anything under test/ need to be reverted. Those are test artefacts. The