GitHub user zemian opened a pull request:
https://github.com/apache/tomcat/pull/72
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59901
Caching jsp file read to improve performance
Hi, I added jsp file content cache inside ParserController for this
enhancement. This reduced two read I found during the parsing for both XML jsp
and standard jsp.
Impl notes: The ParserController instance seems to be bounded to
JspServletWrapper lifecycle though, so this will cache only per
JspServletWrapper instance context as well. I have seen that some tag file
processing will create nested instances of JspServletWrapper, and in this case,
we still not able to use the cache. I wasn't sure was there a better place to
add the cache that can reuse by multiple JspServletWrapper instances at this
point. Please let me know what you think what you think so far.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zemian/tomcat zemian_59901-jsp-file-cache
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomcat/pull/72.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #72
----
commit 9dff7cf58645eb0e2f2b08333b225373d9144361
Author: Zemian Deng <zemian.d...@bnymellon.com>
Date: 2017-08-06T21:09:07Z
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59901
Caching jsp file read to improve performance
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
