Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-09 Thread Violeta Georgieva
2017-01-09 13:55 GMT+02:00 Mark Thomas : > > On 06/01/2017 15:58, Rémy Maucherat wrote: > > 2017-01-06 16:52 GMT+01:00 Violeta Georgieva : > > > >> With r1775598 changes, the declaration of the scripting variable now is in > >> try/finally block and it is not visible outside this block. > >> > >> h

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-09 Thread Mark Thomas
On 06/01/2017 15:58, Rémy Maucherat wrote: > 2017-01-06 16:52 GMT+01:00 Violeta Georgieva : > >> With r1775598 changes, the declaration of the scripting variable now is in >> try/finally block and it is not visible outside this block. >> >> http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/or

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Rémy Maucherat
2017-01-06 16:52 GMT+01:00 Violeta Georgieva : > With r1775598 changes, the declaration of the scripting variable now is in > try/finally block and it is not visible outside this block. > > http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/a > pache/jasper/compiler/Generator.java?view=mar

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Violeta Georgieva
2017-01-06 16:57 GMT+02:00 Violeta Georgieva : > > > > 2017-01-06 15:44 GMT+02:00 Violeta Georgieva : > > > > > > > > 2017-01-06 15:24 GMT+02:00 Rémy Maucherat : > > > > > > 2017-01-06 13:58 GMT+01:00 Violeta Georgieva : > > > > > > > I'm observing the exception below: > > > > > > > > > > Maybe but

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Violeta Georgieva
2017-01-06 15:44 GMT+02:00 Violeta Georgieva : > > > > 2017-01-06 15:24 GMT+02:00 Rémy Maucherat : > > > > 2017-01-06 13:58 GMT+01:00 Violeta Georgieva : > > > > > I'm observing the exception below: > > > > > > > Maybe but I fail to see the actual problem in the generated code, and it's > > not nor

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Rémy Maucherat
2017-01-06 14:44 GMT+01:00 Violeta Georgieva : > 2017-01-06 15:24 GMT+02:00 Rémy Maucherat : > > > > 2017-01-06 13:58 GMT+01:00 Violeta Georgieva : > > > > > I'm observing the exception below: > > > > > > > Maybe but I fail to see the actual problem in the generated code, and > it's > > not normal

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Violeta Georgieva
2017-01-06 15:24 GMT+02:00 Rémy Maucherat : > > 2017-01-06 13:58 GMT+01:00 Violeta Georgieva : > > > I'm observing the exception below: > > > > Maybe but I fail to see the actual problem in the generated code, and it's > not normal anyway that it makes a difference when the change is to replace >

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Rémy Maucherat
2017-01-06 13:58 GMT+01:00 Violeta Georgieva : > I'm observing the exception below: > Maybe but I fail to see the actual problem in the generated code, and it's not normal anyway that it makes a difference when the change is to replace with . However, I should have used tagHandlerVar rather tha

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Mark Thomas
On 06/01/2017 12:58, Violeta Georgieva wrote: > Hi, > > 2017-01-06 1:38 GMT+02:00 Mark Thomas : >> >> The proposed Apache Tomcat 8.5.10 release is now available for voting. >> >> The major changes compared to the 8.5.9 release are: >> >> - HTTP/2 fixes and improvements >> >> - Simpler JSP file enc

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Violeta Georgieva
Hi, 2017-01-06 1:38 GMT+02:00 Mark Thomas : > > The proposed Apache Tomcat 8.5.10 release is now available for voting. > > The major changes compared to the 8.5.9 release are: > > - HTTP/2 fixes and improvements > > - Simpler JSP file encoding detector that delegates XML prolog > encoding detect

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Martin Grigorov
[ X ] Stable - go ahead and release as 8.5.10 Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, Jan 6, 2017 at 12:38 AM, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.10 release is now available for voting. > > The major changes compared to the 8.5.9 re

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Rémy Maucherat
2017-01-06 0:38 GMT+01:00 Mark Thomas : > The proposed Apache Tomcat 8.5.10 release is now available for voting. > > The major changes compared to the 8.5.9 release are: > > - HTTP/2 fixes and improvements > > - Simpler JSP file encoding detector that delegates XML prolog > encoding detection to

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Huxing Zhang
@tomcat.apache.org Subject:[VOTE] Release Apache Tomcat 8.5.10 The proposed Apache Tomcat 8.5.10 release is now available for voting. The major changes compared to the 8.5.9 release are: - HTTP/2 fixes and improvements - Simpler JSP file encoding detector that delegates XML prolog encoding detection to

[VOTE] Release Apache Tomcat 8.5.10

2017-01-05 Thread Mark Thomas
The proposed Apache Tomcat 8.5.10 release is now available for voting. The major changes compared to the 8.5.9 release are: - HTTP/2 fixes and improvements - Simpler JSP file encoding detector that delegates XML prolog encoding detection to the JRE rather than using a custom XML parser. - I