This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 12c0094a2ebd6e9d929bb735ca83689b8b5a1a71
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Thu Aug 10 15:44:21 2023 +0100

    Consistent synchronization - reported by Coverity
---
 java/org/apache/catalina/core/StandardService.java | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/java/org/apache/catalina/core/StandardService.java 
b/java/org/apache/catalina/core/StandardService.java
index c6216f6174..49af86a62b 100644
--- a/java/org/apache/catalina/core/StandardService.java
+++ b/java/org/apache/catalina/core/StandardService.java
@@ -267,7 +267,10 @@ public class StandardService extends LifecycleMBeanBase 
implements Service {
      */
     @Override
     public Connector[] findConnectors() {
-        return connectors;
+        synchronized (connectorsLock) {
+            // shallow copy
+            return connectors.clone();
+        }
     }
 
 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to