https://issues.apache.org/bugzilla/show_bug.cgi?id=52724
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
OS/Version| |All
Severity|critical |enhancement
--- Comment #1 from Mark Thomas <ma...@apache.org> 2012-03-05 20:12:51 UTC ---
(In reply to comment #0)
For all of the cases raised (at least those that are valid) the JVM is about 10
lines away from shutting down which makes any possible resource leak pretty
much irrelevant. This demonstrates the necessity of understanding the code
before claiming that a critical bug exists.
I was tempted to resolve this bug as INVALID but it is true that the code could
be cleaner and that would prevent someone creating a duplicate (and similarly
pointless) issue in the future.
I have therefore changed this bug to an enhancement and cleaned up the code.
Responding to the specific points:
> 1. the InputSource object "is" created at line 452 is not closed.
It is an InputSource not an InputStream. There is no close() method.
> 2. when the statements at lines 455-457 throw some exception, the "fis" can
> not
> be closed as expected.
And less than a second later the JVM shuts down. Not an issue. Cleaned up
anyway.
> 3. when the statements at lines 480-483 throw some exception, the "socket" and
> the "stream" can not be closed as expected.
Non-issue for the same reason as 2.
> 4. when the statements at lines 574-576 throw some exception, the
> "inputStream"
> can not be closed as expected.
Non-issue for the same reason as 2.
Before raising a bug, especially a critical one, it is important to do
sufficient research to be very sure of your ground. If someone can't be
bothered to do the research to ensure a bug is valid, don't expect the Tomcat
committers to bother to explain why they have closed a bug as INVALID.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
