Re: mod_headers as a Filter

2021-06-24 Thread Rémy Maucherat
On Wed, Jun 23, 2021 at 8:43 PM Mark Thomas wrote: > > On 07/05/2021 09:33, Rémy Maucherat wrote: > > On Wed, Apr 28, 2021 at 10:45 AM Rémy Maucherat wrote: > > > >> On Wed, Apr 28, 2021 at 9:07 AM Mark Thomas wrote: > >> > >>> I'm wondering if there is merit in a Valve-like mechanism for Coyote

Re: mod_headers as a Filter

2021-06-23 Thread Mark Thomas
On 07/05/2021 09:33, Rémy Maucherat wrote: On Wed, Apr 28, 2021 at 10:45 AM Rémy Maucherat wrote: On Wed, Apr 28, 2021 at 9:07 AM Mark Thomas wrote: I'm wondering if there is merit in a Valve-like mechanism for Coyote. Name TBD but would look something like: - callbacks - after request

Re: mod_headers as a Filter

2021-05-07 Thread Rémy Maucherat
On Wed, Apr 28, 2021 at 10:45 AM Rémy Maucherat wrote: > On Wed, Apr 28, 2021 at 9:07 AM Mark Thomas wrote: > >> I'm wondering if there is merit in a Valve-like mechanism for Coyote. >> Name TBD but would look something like: >> - callbacks >>- after request headers are parsed / before the r

Re: mod_headers as a Filter

2021-04-28 Thread Rémy Maucherat
On Wed, Apr 28, 2021 at 9:07 AM Mark Thomas wrote: > I'm wondering if there is merit in a Valve-like mechanism for Coyote. > Name TBD but would look something like: > - callbacks >- after request headers are parsed / before the request is prepared >- after the request is prepared >- b

Re: mod_headers as a Filter

2021-04-28 Thread Mark Thomas
On 27/04/2021 22:14, Rémy Maucherat wrote: I remember after doing the rewrite valve I got asked a bit about mod_headers because "why not". However, now I recall I found out it would be far less practical. So I very quickly moved on since it was also less useful than rewrite. I would still prob

Re: mod_headers as a Filter

2021-04-27 Thread Rémy Maucherat
On Tue, Apr 27, 2021 at 7:05 PM Mark Thomas wrote: > Hi all, > > I've started to look at this and I am struggling to see a way to > implement something that looks like mod_headers as a Filter. > > Request headers are fairly simple. The process looks something like: > a) take a copy of all the he

Re: mod_headers as a Filter

2021-04-27 Thread Romain Manni-Bucau
Isnt the response buffer size giving a sufficient hint or callback like (dont rewrite before it is reached or body starts to be read)? Guess filter must force some size if not set but sounds like something to check, no? Le mar. 27 avr. 2021 à 21:32, Raymond Augé a écrit : > Couldn't you add a ca

Re: mod_headers as a Filter

2021-04-27 Thread Raymond Augé
Couldn't you add a callback/hook to commit() impl and trigger the rules during that callback/hook? But with that the filter is merely a shell for pushing rules into that callback/hook registry. - Ray On Tue, Apr 27, 2021 at 1:04 PM Mark Thomas wrote: > Hi all, > > I've started to look at this