Re: SCI discovery ordering

2013-09-23 Thread Mark Thomas
On 22/09/2013 10:55, Jeremy Boynes wrote: On Sep 22, 2013, at 1:44 AM, Mark Thomas ma...@apache.org wrote: On 22/09/2013 00:27, Jeremy Boynes wrote: As a concrete example of how this impacts the behaviour, consider the case where the application includes its own JSP engine. With the RI's

Re: SCI discovery ordering

2013-09-22 Thread Mark Thomas
On 22/09/2013 00:27, Jeremy Boynes wrote: If the intent of the language in the spec is to give the application implementation priority if it comes first in the delegation order, this should apply to discovery as well as classloading per the ServiceLoader semantic. No, the intent of the

Re: SCI discovery ordering

2013-09-22 Thread Jeremy Boynes
On Sep 22, 2013, at 1:44 AM, Mark Thomas ma...@apache.org wrote: On 22/09/2013 00:27, Jeremy Boynes wrote: As a concrete example of how this impacts the behaviour, consider the case where the application includes its own JSP engine. With the RI's delegation model, the application's

Re: SCI discovery ordering

2013-09-22 Thread Jeremy Boynes
On Sep 22, 2013, at 10:55 AM, Jeremy Boynes jboy...@apache.org wrote: On Sep 22, 2013, at 1:44 AM, Mark Thomas ma...@apache.org wrote: On 22/09/2013 00:27, Jeremy Boynes wrote: As a concrete example of how this impacts the behaviour, consider the case where the application includes its

Re: SCI discovery ordering

2013-09-21 Thread Jeremy Boynes
On Sep 20, 2013, at 8:50 AM, Mark Thomas ma...@apache.org wrote: On 20/09/2013 16:02, Jeremy Boynes wrote: The only ordering concern for SCIs in the spec is that they are discovered following the classloader delegation model. This will typically be configured to load application classes

SERVLET_SPEC-79, was: SCI discovery ordering

2013-09-21 Thread Jeremy Boynes
On Sep 20, 2013, at 2:43 PM, Nick Williams nicho...@nicholaswilliams.net wrote: On Sep 20, 2013, at 4:33 PM, Jeremy Boynes wrote: On Fri, Sep 20, 2013 at 8:50 AM, Mark Thomas ma...@apache.org wrote: On 20/09/2013 16:02, Jeremy Boynes wrote: The only ordering concern for SCIs in the

Re: SCI discovery ordering

2013-09-20 Thread Mark Thomas
On 20/09/2013 06:11, Jeremy Boynes wrote: On Sep 19, 2013, at 8:31 AM, Jeremy Boynes jboy...@apache.org wrote: On Sep 19, 2013, at 6:07 AM, ma...@apache.org wrote: Author: markt Date: Thu Sep 19 13:07:02 2013 New Revision: 1524727 URL: http://svn.apache.org/r1524727 Log: Always load

Re: SCI discovery ordering

2013-09-20 Thread Remy Maucherat
On Fri, 2013-09-20 at 08:38 +0100, Mark Thomas wrote: a) The container defined SCIs need to be loaded first. Any other solution places an unnecessary burden on application developers. It is reasonable for application developers to expect that if a container advertises support for WebSocket,

Re: SCI discovery ordering

2013-09-20 Thread Jeremy Boynes
On Sep 20, 2013, at 12:38 AM, Mark Thomas ma...@apache.org wrote: On 20/09/2013 06:11, Jeremy Boynes wrote: On Sep 19, 2013, at 8:31 AM, Jeremy Boynes jboy...@apache.org wrote: On Sep 19, 2013, at 6:07 AM, ma...@apache.org wrote: Author: markt Date: Thu Sep 19 13:07:02 2013 New

Re: SCI discovery ordering

2013-09-20 Thread Mark Thomas
On 20/09/2013 16:02, Jeremy Boynes wrote: The only ordering concern for SCIs in the spec is that they are discovered following the classloader delegation model. This will typically be configured to load application classes first, something r1524727 does not do. The intention of the language

Re: SCI discovery ordering

2013-09-20 Thread Jeremy Boynes
On Fri, Sep 20, 2013 at 8:50 AM, Mark Thomas ma...@apache.org wrote: On 20/09/2013 16:02, Jeremy Boynes wrote: The only ordering concern for SCIs in the spec is that they are discovered following the classloader delegation model. This will typically be configured to load application

Re: SCI discovery ordering

2013-09-20 Thread Nick Williams
On Sep 20, 2013, at 4:33 PM, Jeremy Boynes wrote: On Fri, Sep 20, 2013 at 8:50 AM, Mark Thomas ma...@apache.org wrote: On 20/09/2013 16:02, Jeremy Boynes wrote: The only ordering concern for SCIs in the spec is that they are discovered following the classloader delegation model. This will

SCI discovery ordering

2013-09-19 Thread Jeremy Boynes
On Sep 19, 2013, at 6:07 AM, ma...@apache.org wrote: Author: markt Date: Thu Sep 19 13:07:02 2013 New Revision: 1524727 URL: http://svn.apache.org/r1524727 Log: Always load container SCIs first This seems at odds with the requirement that the order in which these services are discovered

Re: SCI discovery ordering

2013-09-19 Thread Mark Thomas
On 19/09/2013 16:31, Jeremy Boynes wrote: On Sep 19, 2013, at 6:07 AM, ma...@apache.org wrote: Author: markt Date: Thu Sep 19 13:07:02 2013 New Revision: 1524727 URL: http://svn.apache.org/r1524727 Log: Always load container SCIs first This seems at odds with the requirement that the

Re: SCI discovery ordering

2013-09-19 Thread Jeremy Boynes
On Sep 19, 2013, at 8:36 AM, Mark Thomas ma...@apache.org wrote: On 19/09/2013 16:31, Jeremy Boynes wrote: On Sep 19, 2013, at 6:07 AM, ma...@apache.org wrote: Author: markt Date: Thu Sep 19 13:07:02 2013 New Revision: 1524727 URL: http://svn.apache.org/r1524727 Log: Always load

Re: SCI discovery ordering

2013-09-19 Thread Nick Williams
On Sep 19, 2013, at 11:32 AM, Jeremy Boynes wrote: On Sep 19, 2013, at 8:36 AM, Mark Thomas ma...@apache.org wrote: On 19/09/2013 16:31, Jeremy Boynes wrote: On Sep 19, 2013, at 6:07 AM, ma...@apache.org wrote: Author: markt Date: Thu Sep 19 13:07:02 2013 New Revision: 1524727 URL:

Re: SCI discovery ordering

2013-09-19 Thread Mark Thomas
On 19/09/2013 17:39, Nick Williams wrote: On Sep 19, 2013, at 11:32 AM, Jeremy Boynes wrote: There's a clear model already without assumptions about SCI ordering: SCIs fire before SCLs, and SCLs can be ordered explicitly by web.xml. There are no ordering requirements for SCIs except that

Re: SCI discovery ordering

2013-09-19 Thread Jeremy Boynes
On Thu, Sep 19, 2013 at 11:28 AM, Mark Thomas ma...@apache.org wrote: On 19/09/2013 17:39, Nick Williams wrote: On Sep 19, 2013, at 11:32 AM, Jeremy Boynes wrote: There's a clear model already without assumptions about SCI ordering: SCIs fire before SCLs, and SCLs can be ordered

Re: SCI discovery ordering

2013-09-19 Thread Jeremy Boynes
On Sep 19, 2013, at 8:31 AM, Jeremy Boynes jboy...@apache.org wrote: On Sep 19, 2013, at 6:07 AM, ma...@apache.org wrote: Author: markt Date: Thu Sep 19 13:07:02 2013 New Revision: 1524727 URL: http://svn.apache.org/r1524727 Log: Always load container SCIs first This seems at odds