Re: svn commit: r763298 - in /tomcat/trunk/java/org/apache/catalina: core/StandardContext.java core/StandardHost.java tribes/membership/Membership.java util/InstanceSupport.java util/LifecycleSupport.

2009-04-11 Thread Filip Hanik - Dev Lists
Ian Darwin wrote: Filip Hanik - Dev Lists wrote: I'm generally against this find bugs 'may be bugs' issues. is there an actual bug here? It's generally making the code better. What do you object to about it? very simple, if one is about to refactor code, how about removing syncs and using

Re: svn commit: r763298 - in /tomcat/trunk/java/org/apache/catalina: core/StandardContext.java core/StandardHost.java tribes/membership/Membership.java util/InstanceSupport.java util/LifecycleSupport.

2009-04-10 Thread Mark Thomas
Filip Hanik - Dev Lists wrote: I'm generally against this find bugs 'may be bugs' issues. is there an actual bug here? Reported bug, no. Bugs uses could hit, yes. Hence why this is in trunk and not being proposed for backport. Are all the syncs necessary? I haven't looked in detail but I

Re: svn commit: r763298 - in /tomcat/trunk/java/org/apache/catalina: core/StandardContext.java core/StandardHost.java tribes/membership/Membership.java util/InstanceSupport.java util/LifecycleSupport.

2009-04-09 Thread Filip Hanik - Dev Lists
I'm generally against this find bugs 'may be bugs' issues. is there an actual bug here? Filip ma...@apache.org wrote: Author: markt Date: Wed Apr 8 16:08:42 2009 New Revision: 763298 URL: http://svn.apache.org/viewvc?rev=763298view=rev Log: Fix

Re: svn commit: r763298 - in /tomcat/trunk/java/org/apache/catalina: core/StandardContext.java core/StandardHost.java tribes/membership/Membership.java util/InstanceSupport.java util/LifecycleSupport.

2009-04-09 Thread Ian Darwin
Filip Hanik - Dev Lists wrote: I'm generally against this find bugs 'may be bugs' issues. is there an actual bug here? It's generally making the code better. What do you object to about it? - To unsubscribe, e-mail: